From 94a3f930cbdfb413a4f172d213c73c49bb72230c Mon Sep 17 00:00:00 2001 From: YeungYeah Date: Sun, 10 Apr 2022 20:16:44 +0800 Subject: [PATCH 1/2] fix: change port used in buildTrackerURL variable port should use port from parameter instead of a const Port --- torrentfile/tracker.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/torrentfile/tracker.go b/torrentfile/tracker.go index 7176510..9112bd0 100644 --- a/torrentfile/tracker.go +++ b/torrentfile/tracker.go @@ -24,7 +24,7 @@ func (t *TorrentFile) buildTrackerURL(peerID [20]byte, port uint16) (string, err params := url.Values{ "info_hash": []string{string(t.InfoHash[:])}, "peer_id": []string{string(peerID[:])}, - "port": []string{strconv.Itoa(int(Port))}, + "port": []string{strconv.Itoa(int(port))}, "uploaded": []string{"0"}, "downloaded": []string{"0"}, "compact": []string{"1"}, From ab1aeff12166b416387c67ad00996a68aeb3efa8 Mon Sep 17 00:00:00 2001 From: YeungYeah Date: Sun, 10 Apr 2022 20:36:44 +0800 Subject: [PATCH 2/2] fix: expected port in test --- torrentfile/tracker_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/torrentfile/tracker_test.go b/torrentfile/tracker_test.go index 8d9a8fe..93f48e0 100644 --- a/torrentfile/tracker_test.go +++ b/torrentfile/tracker_test.go @@ -25,7 +25,7 @@ func TestBuildTrackerURL(t *testing.T) { peerID := [20]byte{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20} const port uint16 = 6882 url, err := to.buildTrackerURL(peerID, port) - expected := "http://bttracker.debian.org:6969/announce?compact=1&downloaded=0&info_hash=%D8%F79%CE%C3%28%95l%CC%5B%BF%1F%86%D9%FD%CF%DB%A8%CE%B6&left=351272960&peer_id=%01%02%03%04%05%06%07%08%09%0A%0B%0C%0D%0E%0F%10%11%12%13%14&port=6881&uploaded=0" + expected := "http://bttracker.debian.org:6969/announce?compact=1&downloaded=0&info_hash=%D8%F79%CE%C3%28%95l%CC%5B%BF%1F%86%D9%FD%CF%DB%A8%CE%B6&left=351272960&peer_id=%01%02%03%04%05%06%07%08%09%0A%0B%0C%0D%0E%0F%10%11%12%13%14&port=6882&uploaded=0" assert.Nil(t, err) assert.Equal(t, url, expected) }