From bd451584982ecf4ca5b1e5938cf168e17e30d837 Mon Sep 17 00:00:00 2001 From: Andy Pan Date: Tue, 31 Mar 2020 09:53:17 +0800 Subject: [PATCH] Resolved code issues of gofmt and golint (#55) * Resolved code issues of gofmt and golint Code quality: https://goreportcard.com/report/github.com/google/uuid * Fix typo * Update comment --- uuid_test.go | 4 +--- version4.go | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/uuid_test.go b/uuid_test.go index 2a43fb1..4e04e7c 100644 --- a/uuid_test.go +++ b/uuid_test.go @@ -59,7 +59,6 @@ var tests = []test{ {"f47ac10b-58cc-4372-e567-0e02b2c3d479", 4, Future, true}, {"f47ac10b-58cc-4372-f567-0e02b2c3d479", 4, Future, true}, - {"f47ac10b158cc-5372-a567-0e02b2c3d479", 0, Invalid, false}, {"f47ac10b-58cc25372-a567-0e02b2c3d479", 0, Invalid, false}, {"f47ac10b-58cc-53723a567-0e02b2c3d479", 0, Invalid, false}, @@ -67,7 +66,6 @@ var tests = []test{ {"f47ac10b-58cc-5372-a567-0e02-2c3d479", 0, Invalid, false}, {"g47ac10b-58cc-4372-a567-0e02b2c3d479", 0, Invalid, false}, - {"{f47ac10b-58cc-0372-8567-0e02b2c3d479}", 0, RFC4122, true}, {"{f47ac10b-58cc-0372-8567-0e02b2c3d479", 0, Invalid, false}, {"f47ac10b-58cc-0372-8567-0e02b2c3d479}", 0, Invalid, false}, @@ -481,7 +479,7 @@ func TestBadRand(t *testing.T) { func TestSetRand(t *testing.T) { myString := "805-9dd6-1a877cb526c678e71d38-7122-44c0-9b7c-04e7001cc78783ac3e82-47a3-4cc3-9951-13f3339d88088f5d685a-11f7-4078-ada9-de44ad2daeb7" - + SetRand(strings.NewReader(myString)) uuid1 := New() uuid2 := New() diff --git a/version4.go b/version4.go index 9ad1aba..c110465 100644 --- a/version4.go +++ b/version4.go @@ -30,6 +30,7 @@ func NewRandom() (UUID, error) { return NewRandomFromReader(rander) } +// NewRandomFromReader returns a UUID based on bytes read from a given io.Reader. func NewRandomFromReader(r io.Reader) (UUID, error) { var uuid UUID _, err := io.ReadFull(r, uuid[:]) @@ -40,4 +41,3 @@ func NewRandomFromReader(r io.Reader) (UUID, error) { uuid[8] = (uuid[8] & 0x3f) | 0x80 // Variant is 10 return uuid, nil } -