2019-12-13 11:55:45 +02:00
|
|
|
package cmd
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
2020-07-30 10:35:46 +02:00
|
|
|
"net/http"
|
|
|
|
"os"
|
|
|
|
"path/filepath"
|
|
|
|
"testing"
|
2020-07-27 12:01:59 +02:00
|
|
|
|
2020-10-01 13:34:51 +02:00
|
|
|
piperhttp "github.com/SAP/jenkins-library/pkg/http"
|
|
|
|
"github.com/SAP/jenkins-library/pkg/mock"
|
|
|
|
|
2019-12-13 11:55:45 +02:00
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
2020-07-30 10:35:46 +02:00
|
|
|
type httpClientMock struct {
|
|
|
|
expectedError error
|
|
|
|
downloadedFiles map[string]string // src, dest
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *httpClientMock) SetOptions(options piperhttp.ClientOptions) {
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *httpClientMock) DownloadFile(url, filename string, header http.Header, cookies []*http.Cookie) error {
|
|
|
|
|
|
|
|
if c.expectedError != nil {
|
|
|
|
return c.expectedError
|
|
|
|
}
|
|
|
|
|
|
|
|
if c.downloadedFiles == nil {
|
|
|
|
c.downloadedFiles = make(map[string]string)
|
|
|
|
}
|
|
|
|
c.downloadedFiles[url] = filename
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-12-13 11:55:45 +02:00
|
|
|
func TestRunDetect(t *testing.T) {
|
|
|
|
|
|
|
|
t.Run("success case", func(t *testing.T) {
|
2020-02-27 13:11:22 +02:00
|
|
|
s := mock.ShellMockRunner{}
|
2020-07-30 10:35:46 +02:00
|
|
|
fileUtilsMock := mock.FilesMock{}
|
|
|
|
fileUtilsMock.AddFile("detect.sh", []byte(""))
|
|
|
|
httpClient := httpClientMock{}
|
|
|
|
err := runDetect(detectExecuteScanOptions{}, &s, &fileUtilsMock, &httpClient)
|
2019-12-13 11:55:45 +02:00
|
|
|
|
2020-07-30 10:35:46 +02:00
|
|
|
assert.Equal(t, httpClient.downloadedFiles["https://detect.synopsys.com/detect.sh"], "detect.sh")
|
2020-10-27 15:29:22 +02:00
|
|
|
assert.True(t, fileUtilsMock.HasRemovedFile("detect.sh"))
|
2020-07-30 10:35:46 +02:00
|
|
|
assert.NoError(t, err)
|
2020-02-27 13:11:22 +02:00
|
|
|
assert.Equal(t, ".", s.Dir, "Wrong execution directory used")
|
|
|
|
assert.Equal(t, "/bin/bash", s.Shell[0], "Bash shell expected")
|
2020-07-30 10:35:46 +02:00
|
|
|
expectedScript := "./detect.sh --blackduck.url= --blackduck.api.token= --detect.project.name=\\\"\\\" --detect.project.version.name=\\\"\\\" --detect.code.location.name=\\\"\\\""
|
2020-02-27 13:11:22 +02:00
|
|
|
assert.Equal(t, expectedScript, s.Calls[0])
|
2019-12-13 11:55:45 +02:00
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("failure case", func(t *testing.T) {
|
2020-07-30 10:35:46 +02:00
|
|
|
s := mock.ShellMockRunner{ShouldFailOnCommand: map[string]error{"./detect.sh --blackduck.url= --blackduck.api.token= --detect.project.name=\\\"\\\" --detect.project.version.name=\\\"\\\" --detect.code.location.name=\\\"\\\"": fmt.Errorf("Test Error")}}
|
|
|
|
fileUtilsMock := mock.FilesMock{}
|
2020-10-27 15:29:22 +02:00
|
|
|
fileUtilsMock.AddFile("detect.sh", []byte(""))
|
2020-07-30 10:35:46 +02:00
|
|
|
httpClient := httpClientMock{}
|
|
|
|
err := runDetect(detectExecuteScanOptions{}, &s, &fileUtilsMock, &httpClient)
|
2020-10-27 15:29:22 +02:00
|
|
|
assert.EqualError(t, err, "Test Error")
|
|
|
|
assert.True(t, fileUtilsMock.HasRemovedFile("detect.sh"))
|
2020-07-30 10:35:46 +02:00
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("maven parameters", func(t *testing.T) {
|
|
|
|
s := mock.ShellMockRunner{}
|
|
|
|
fileUtilsMock := mock.FilesMock{
|
|
|
|
CurrentDir: "root_folder",
|
|
|
|
}
|
|
|
|
fileUtilsMock.AddFile("detect.sh", []byte(""))
|
|
|
|
httpClient := httpClientMock{}
|
|
|
|
err := runDetect(detectExecuteScanOptions{
|
|
|
|
M2Path: ".pipeline/local_repo",
|
|
|
|
ProjectSettingsFile: "project-settings.xml",
|
|
|
|
GlobalSettingsFile: "global-settings.xml",
|
|
|
|
}, &s, &fileUtilsMock, &httpClient)
|
2019-12-13 11:55:45 +02:00
|
|
|
|
2020-07-30 10:35:46 +02:00
|
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, ".", s.Dir, "Wrong execution directory used")
|
|
|
|
assert.Equal(t, "/bin/bash", s.Shell[0], "Bash shell expected")
|
|
|
|
absoluteLocalPath := string(os.PathSeparator) + filepath.Join("root_folder", ".pipeline", "local_repo")
|
|
|
|
|
|
|
|
expectedParam := "\"--detect.maven.build.command='--global-settings global-settings.xml --settings project-settings.xml -Dmaven.repo.local=" + absoluteLocalPath + "'\""
|
|
|
|
assert.Contains(t, s.Calls[0], expectedParam)
|
2019-12-13 11:55:45 +02:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAddDetectArgs(t *testing.T) {
|
2020-07-30 10:35:46 +02:00
|
|
|
httpClient := piperhttp.Client{}
|
|
|
|
fileUtilsMock := mock.FilesMock{}
|
|
|
|
|
2019-12-13 11:55:45 +02:00
|
|
|
testData := []struct {
|
|
|
|
args []string
|
|
|
|
options detectExecuteScanOptions
|
|
|
|
expected []string
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
args: []string{"--testProp1=1"},
|
|
|
|
options: detectExecuteScanOptions{
|
2020-07-27 12:01:59 +02:00
|
|
|
ScanProperties: []string{"--scan1=1", "--scan2=2"},
|
|
|
|
ServerURL: "https://server.url",
|
2020-10-01 13:34:51 +02:00
|
|
|
Token: "apiToken",
|
2020-07-27 12:01:59 +02:00
|
|
|
ProjectName: "testName",
|
|
|
|
Version: "1.0",
|
|
|
|
VersioningModel: "major-minor",
|
|
|
|
CodeLocation: "",
|
|
|
|
Scanners: []string{"signature"},
|
|
|
|
ScanPaths: []string{"path1", "path2"},
|
2019-12-13 11:55:45 +02:00
|
|
|
},
|
|
|
|
expected: []string{
|
|
|
|
"--testProp1=1",
|
|
|
|
"--scan1=1",
|
|
|
|
"--scan2=2",
|
|
|
|
"--blackduck.url=https://server.url",
|
|
|
|
"--blackduck.api.token=apiToken",
|
2020-07-28 10:48:19 +02:00
|
|
|
"--detect.project.name=\\\"testName\\\"",
|
|
|
|
"--detect.project.version.name=\\\"1.0\\\"",
|
|
|
|
"--detect.code.location.name=\\\"testName/1.0\\\"",
|
2019-12-13 11:55:45 +02:00
|
|
|
"--detect.blackduck.signature.scanner.paths=path1,path2",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
args: []string{"--testProp1=1"},
|
|
|
|
options: detectExecuteScanOptions{
|
2020-07-27 12:01:59 +02:00
|
|
|
ServerURL: "https://server.url",
|
2020-10-01 13:34:51 +02:00
|
|
|
Token: "apiToken",
|
2020-07-27 12:01:59 +02:00
|
|
|
ProjectName: "testName",
|
|
|
|
Version: "1.0",
|
|
|
|
VersioningModel: "major-minor",
|
|
|
|
CodeLocation: "testLocation",
|
2020-07-28 10:48:19 +02:00
|
|
|
FailOn: []string{"BLOCKER", "MAJOR"},
|
2020-07-27 12:01:59 +02:00
|
|
|
Scanners: []string{"source"},
|
|
|
|
ScanPaths: []string{"path1", "path2"},
|
2020-07-28 10:48:19 +02:00
|
|
|
Groups: []string{"testGroup"},
|
2019-12-13 11:55:45 +02:00
|
|
|
},
|
|
|
|
expected: []string{
|
|
|
|
"--testProp1=1",
|
|
|
|
"--blackduck.url=https://server.url",
|
|
|
|
"--blackduck.api.token=apiToken",
|
2020-07-28 10:48:19 +02:00
|
|
|
"--detect.project.name=\\\"testName\\\"",
|
|
|
|
"--detect.project.version.name=\\\"1.0\\\"",
|
|
|
|
"--detect.project.user.groups=\\\"testGroup\\\"",
|
|
|
|
"--detect.policy.check.fail.on.severities=BLOCKER,MAJOR",
|
|
|
|
"--detect.code.location.name=\\\"testLocation\\\"",
|
|
|
|
"--detect.source.path=path1",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
args: []string{"--testProp1=1"},
|
|
|
|
options: detectExecuteScanOptions{
|
|
|
|
ServerURL: "https://server.url",
|
2020-10-01 13:34:51 +02:00
|
|
|
Token: "apiToken",
|
2020-07-28 10:48:19 +02:00
|
|
|
ProjectName: "testName",
|
|
|
|
CodeLocation: "testLocation",
|
|
|
|
FailOn: []string{"BLOCKER", "MAJOR"},
|
|
|
|
Scanners: []string{"source"},
|
|
|
|
ScanPaths: []string{"path1", "path2"},
|
|
|
|
Groups: []string{"testGroup", "testGroup2"},
|
|
|
|
Version: "1.0",
|
|
|
|
VersioningModel: "major-minor",
|
|
|
|
},
|
|
|
|
expected: []string{
|
|
|
|
"--testProp1=1",
|
|
|
|
"--blackduck.url=https://server.url",
|
|
|
|
"--blackduck.api.token=apiToken",
|
|
|
|
"--detect.project.name=\\\"testName\\\"",
|
|
|
|
"--detect.project.version.name=\\\"1.0\\\"",
|
|
|
|
"--detect.project.user.groups=\\\"testGroup\\\",\\\"testGroup2\\\"",
|
|
|
|
"--detect.policy.check.fail.on.severities=BLOCKER,MAJOR",
|
|
|
|
"--detect.code.location.name=\\\"testLocation\\\"",
|
2019-12-13 11:55:45 +02:00
|
|
|
"--detect.source.path=path1",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for k, v := range testData {
|
|
|
|
t.Run(fmt.Sprintf("run %v", k), func(t *testing.T) {
|
2020-07-30 10:35:46 +02:00
|
|
|
got, err := addDetectArgs(v.args, v.options, &fileUtilsMock, &httpClient)
|
|
|
|
assert.NoError(t, err)
|
2019-12-13 11:55:45 +02:00
|
|
|
assert.Equal(t, v.expected, got)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|