1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
sap-jenkins-library/cmd/abapEnvironmentPushATCSystemConfig.go

559 lines
22 KiB
Go
Raw Normal View History

Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
package cmd
import (
"bytes"
"encoding/json"
"fmt"
"io"
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
"net/http"
"net/http/cookiejar"
"os"
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
"path/filepath"
"reflect"
"strconv"
"strings"
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
"time"
"github.com/SAP/jenkins-library/pkg/abaputils"
"github.com/SAP/jenkins-library/pkg/command"
piperhttp "github.com/SAP/jenkins-library/pkg/http"
"github.com/SAP/jenkins-library/pkg/log"
"github.com/SAP/jenkins-library/pkg/telemetry"
"github.com/pkg/errors"
)
func abapEnvironmentPushATCSystemConfig(config abapEnvironmentPushATCSystemConfigOptions, telemetryData *telemetry.CustomData) {
// for command execution use Command
c := command.Command{}
// reroute command output to logging framework
c.Stdout(log.Writer())
c.Stderr(log.Writer())
var autils = abaputils.AbapUtils{
Exec: &c,
}
client := piperhttp.Client{}
err := runAbapEnvironmentPushATCSystemConfig(&config, telemetryData, &autils, &client)
if err != nil {
log.Entry().WithError(err).Fatal("step execution failed")
}
}
func runAbapEnvironmentPushATCSystemConfig(config *abapEnvironmentPushATCSystemConfigOptions, telemetryData *telemetry.CustomData, autils abaputils.Communication, client piperhttp.Sender) error {
subOptions := convertATCSysOptions(config)
Feature atc config - Correction in Batch (#3536) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement * Correction in Batch - ConfUUID * dummy Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-14 12:04:44 +02:00
// Determine the host, user and password, either via the input parameters or via a cloud foundry service key.
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
connectionDetails, err := autils.GetAbapCommunicationArrangementInfo(subOptions, "/sap/opu/odata4/sap/satc_ci_cf_api/srvd_a2x/sap/satc_ci_cf_sv_api/0001")
if err != nil {
return errors.Errorf("Parameters for the ABAP Connection not available: %v", err)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
cookieJar, err := cookiejar.New(nil)
if err != nil {
return errors.Errorf("could not create a Cookie Jar: %v", err)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
clientOptions := piperhttp.ClientOptions{
MaxRequestDuration: 180 * time.Second,
CookieJar: cookieJar,
Username: connectionDetails.User,
Password: connectionDetails.Password,
}
client.SetOptions(clientOptions)
if connectionDetails.XCsrfToken, err = fetchXcsrfTokenFromHead(connectionDetails, client); err != nil {
return err
}
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
return pushATCSystemConfig(config, connectionDetails, client)
}
func pushATCSystemConfig(config *abapEnvironmentPushATCSystemConfigOptions, connectionDetails abaputils.ConnectionDetailsHTTP, client piperhttp.Sender) error {
//check, if given ATC System configuration File
parsedConfigurationJson, atcSystemConfiguartionJsonFile, err := checkATCSystemConfigurationFile(config)
if err != nil {
return err
}
//check, if ATC configuration with given name already exists in Backend
configDoesExist, configName, configUUID, configLastChangedBackend, err := checkConfigExistsInBackend(config, atcSystemConfiguartionJsonFile, connectionDetails, client)
if err != nil {
return err
}
if !configDoesExist {
//regular push of configuration
configUUID = ""
return handlePushConfiguration(config, configUUID, configDoesExist, atcSystemConfiguartionJsonFile, connectionDetails, client)
}
if !parsedConfigurationJson.LastChangedAt.IsZero() {
if configLastChangedBackend.Before(parsedConfigurationJson.LastChangedAt) && !config.PatchIfExisting {
//config exists, is not recent but must NOT be patched
log.Entry().Info("pushing ATC System Configuration skipped. Reason: ATC System Configuration with name " + configName + " exists and is outdated (Backend: " + configLastChangedBackend.Local().String() + " vs. File: " + parsedConfigurationJson.LastChangedAt.Local().String() + ") but should not be overwritten (check step configuration parameter).")
return nil
}
if configLastChangedBackend.After(parsedConfigurationJson.LastChangedAt) || configLastChangedBackend == parsedConfigurationJson.LastChangedAt {
//configuration exists and is most recent
log.Entry().Info("pushing ATC System Configuration skipped. Reason: ATC System Configuration with name " + configName + " exists and is most recent (Backend: " + configLastChangedBackend.Local().String() + " vs. File: " + parsedConfigurationJson.LastChangedAt.Local().String() + "). Therefore no update needed.")
return nil
}
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
if configLastChangedBackend.Before(parsedConfigurationJson.LastChangedAt) || parsedConfigurationJson.LastChangedAt.IsZero() {
if config.PatchIfExisting {
//configuration exists and is older than current config (or does not provide information about lastChanged) and should be patched
return handlePushConfiguration(config, configUUID, configDoesExist, atcSystemConfiguartionJsonFile, connectionDetails, client)
} else {
//config exists, is not recent but must NOT be patched
log.Entry().Info("pushing ATC System Configuration skipped. Reason: ATC System Configuration with name " + configName + " exists but should not be overwritten (check step configuration parameter).")
return nil
}
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
return nil
}
func checkATCSystemConfigurationFile(config *abapEnvironmentPushATCSystemConfigOptions) (parsedConfigJsonWithExpand, []byte, error) {
var parsedConfigurationJson parsedConfigJsonWithExpand
var emptyConfigurationJson parsedConfigJsonWithExpand
var atcSystemConfiguartionJsonFile []byte
parsedConfigurationJson, atcSystemConfiguartionJsonFile, err := readATCSystemConfigurationFile(config)
if err != nil {
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, err
}
//check if parsedConfigurationJson is not initial or Configuration Name not supplied
if reflect.DeepEqual(parsedConfigurationJson, emptyConfigurationJson) ||
parsedConfigurationJson.ConfName == "" {
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, errors.Errorf("pushing ATC System Configuration failed. Reason: Configured File does not contain required ATC System Configuration attributes (File: " + config.AtcSystemConfigFilePath + ")")
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, nil
}
func readATCSystemConfigurationFile(config *abapEnvironmentPushATCSystemConfigOptions) (parsedConfigJsonWithExpand, []byte, error) {
var parsedConfigurationJson parsedConfigJsonWithExpand
var emptyConfigurationJson parsedConfigJsonWithExpand
var atcSystemConfiguartionJsonFile []byte
var filename string
filelocation, err := filepath.Glob(config.AtcSystemConfigFilePath)
if err != nil {
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, err
}
if len(filelocation) == 0 {
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, errors.Errorf("pushing ATC System Configuration failed. Reason: Configured Filelocation is empty (File: " + config.AtcSystemConfigFilePath + ")")
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
filename, err = filepath.Abs(filelocation[0])
if err != nil {
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, err
}
atcSystemConfiguartionJsonFile, err = os.ReadFile(filename)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
if err != nil {
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, err
}
if len(atcSystemConfiguartionJsonFile) == 0 {
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, errors.Errorf("pushing ATC System Configuration failed. Reason: Configured File is empty (File: " + config.AtcSystemConfigFilePath + ")")
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
err = json.Unmarshal(atcSystemConfiguartionJsonFile, &parsedConfigurationJson)
if err != nil {
return emptyConfigurationJson, atcSystemConfiguartionJsonFile, errors.Errorf("pushing ATC System Configuration failed. Unmarshal Error of ATC Configuration File ("+config.AtcSystemConfigFilePath+"): %v", err)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
return parsedConfigurationJson, atcSystemConfiguartionJsonFile, err
}
func handlePushConfiguration(config *abapEnvironmentPushATCSystemConfigOptions, confUUID string, configDoesExist bool, atcSystemConfiguartionJsonFile []byte, connectionDetails abaputils.ConnectionDetailsHTTP, client piperhttp.Sender) error {
var err error
if configDoesExist {
err = doPatchATCSystemConfig(config, confUUID, atcSystemConfiguartionJsonFile, connectionDetails, client)
if err != nil {
return err
}
log.Entry().Info("ATC System Configuration successfully pushed from file " + config.AtcSystemConfigFilePath + " and patched in system")
}
if !configDoesExist {
err = doPushATCSystemConfig(config, atcSystemConfiguartionJsonFile, connectionDetails, client)
if err != nil {
return err
}
log.Entry().Info("ATC System Configuration successfully pushed from file " + config.AtcSystemConfigFilePath + " and created in system")
}
return nil
}
func fetchXcsrfTokenFromHead(connectionDetails abaputils.ConnectionDetailsHTTP, client piperhttp.Sender) (string, error) {
log.Entry().WithField("ABAP Endpoint: ", connectionDetails.URL).Debug("Fetching Xcrsf-Token")
uriConnectionDetails := connectionDetails
uriConnectionDetails.URL = ""
connectionDetails.XCsrfToken = "fetch"
// Loging into the ABAP System - getting the x-csrf-token and cookies
resp, err := abaputils.GetHTTPResponse("HEAD", connectionDetails, nil, client)
if err != nil {
err = abaputils.HandleHTTPError(resp, err, "authentication on the ABAP system failed", connectionDetails)
return connectionDetails.XCsrfToken, errors.Errorf("X-Csrf-Token fetch failed for Service ATC System Configuration: %v", err)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
defer resp.Body.Close()
log.Entry().WithField("StatusCode", resp.Status).WithField("ABAP Endpoint", connectionDetails.URL).Debug("Authentication on the ABAP system successful")
uriConnectionDetails.XCsrfToken = resp.Header.Get("X-Csrf-Token")
connectionDetails.XCsrfToken = uriConnectionDetails.XCsrfToken
return connectionDetails.XCsrfToken, err
}
func doPatchATCSystemConfig(config *abapEnvironmentPushATCSystemConfigOptions, confUUID string, atcSystemConfiguartionJsonFile []byte, connectionDetails abaputils.ConnectionDetailsHTTP, client piperhttp.Sender) error {
batchATCSystemConfigFile, err := buildATCSystemConfigBatchRequest(confUUID, atcSystemConfiguartionJsonFile)
if err != nil {
return err
}
return doBatchATCSystemConfig(config, batchATCSystemConfigFile, connectionDetails, client)
}
func buildATCSystemConfigBatchRequest(confUUID string, atcSystemConfiguartionJsonFile []byte) (string, error) {
var batchRequestString string
//splitting json into configuration base and configuration properties & build a batch request for oData - patch config & patch priorities
//first remove expansion to priorities to get only "base" Configuration
configBaseJsonBody, err := buildParsedATCSystemConfigBaseJsonBody(confUUID, bytes.NewBuffer(atcSystemConfiguartionJsonFile).String())
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
if err != nil {
return batchRequestString, err
}
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
var parsedConfigPriorities parsedConfigPriorities
err = json.Unmarshal(atcSystemConfiguartionJsonFile, &parsedConfigPriorities)
if err != nil {
return batchRequestString, err
}
//build the Batch request string
contentID := 1
batchRequestString = addBeginOfBatch(batchRequestString)
//now adding opening Changeset as at least config base is to be patched
batchRequestString = addChangesetBegin(batchRequestString, contentID)
if err != nil {
return batchRequestString, err
}
batchRequestString = addPatchConfigBaseChangeset(batchRequestString, confUUID, configBaseJsonBody)
if len(parsedConfigPriorities.Priorities) > 0 {
// in case Priorities need patches too
var priority priorityJson
for i, priorityLine := range parsedConfigPriorities.Priorities {
//for each line, add content id
contentID += 1
priority.Priority = priorityLine.Priority
priorityJsonBody, err := json.Marshal(&priority)
if err != nil {
log.Entry().Errorf("problem with marshall of single priority in line "+strconv.Itoa(i), err)
continue
}
batchRequestString = addChangesetBegin(batchRequestString, contentID)
//now PATCH command for priority
batchRequestString = addPatchSinglePriorityChangeset(batchRequestString, confUUID, priorityLine.Test, priorityLine.MessageId, string(priorityJsonBody))
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
}
//at the end, add closing inner and outer boundary tags
batchRequestString = addEndOfBatch(batchRequestString)
log.Entry().Info("Batch Request String: " + batchRequestString)
return batchRequestString, nil
}
func buildParsedATCSystemConfigBaseJsonBody(confUUID string, atcSystemConfiguartionJsonFile string) (string, error) {
var i interface{}
var outputString string = ``
if err := json.Unmarshal([]byte(atcSystemConfiguartionJsonFile), &i); err != nil {
return outputString, errors.Errorf("problem with unmarshall input "+atcSystemConfiguartionJsonFile+": %v", err)
}
if m, ok := i.(map[string]interface{}); ok {
delete(m, "_priorities")
}
if output, err := json.Marshal(i); err != nil {
return outputString, errors.Errorf("problem with marshall output "+atcSystemConfiguartionJsonFile+": %v", err)
} else {
output = output[1:] // remove leading '{'
outputString = string(output)
//injecting the configuration ID
confIDString := `{"conf_id":"` + confUUID + `",`
outputString = confIDString + outputString
return outputString, err
}
}
func addPatchConfigBaseChangeset(inputString string, confUUID string, configBaseJsonBody string) string {
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
entityIdString := `(root_id='1',conf_id=` + confUUID + `)`
newString := addCommandEntityChangeset("PATCH", "configuration", entityIdString, inputString, configBaseJsonBody)
return newString
}
func addPatchSinglePriorityChangeset(inputString string, confUUID string, test string, messageId string, priorityJsonBody string) string {
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
entityIdString := `(root_id='1',conf_id=` + confUUID + `,test='` + test + `',message_id='` + messageId + `')`
newString := addCommandEntityChangeset("PATCH", "priority", entityIdString, inputString, priorityJsonBody)
return newString
}
func addChangesetBegin(inputString string, contentID int) string {
newString := inputString + `
--changeset
Content-Type: application/http
Content-Transfer-Encoding: binary
Content-ID: ` + strconv.Itoa(contentID) + `
`
return newString
}
func addBeginOfBatch(inputString string) string {
//Starting always with outer boundary - followed by mandatory Contenttype and boundary for changeset
newString := inputString + `
--request-separator
Content-Type: multipart/mixed;boundary=changeset
`
return newString
}
func addEndOfBatch(inputString string) string {
//Starting always with outer boundary - followed by mandatory Contenttype and boundary for changeset
newString := inputString + `
--changeset--
--request-separator--`
return newString
}
func addCommandEntityChangeset(command string, entity string, entityIdString string, inputString string, jsonBody string) string {
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
newString := inputString + `
` + command + ` ` + entity + entityIdString + ` HTTP/1.1
Content-Type: application/json
`
if len(jsonBody) > 0 {
newString += jsonBody + `
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
`
}
return newString
}
func doPushATCSystemConfig(config *abapEnvironmentPushATCSystemConfigOptions, atcSystemConfiguartionJsonFile []byte, connectionDetails abaputils.ConnectionDetailsHTTP, client piperhttp.Sender) error {
abapEndpoint := connectionDetails.URL
connectionDetails.URL = abapEndpoint + "/configuration"
resp, err := abaputils.GetHTTPResponse("POST", connectionDetails, atcSystemConfiguartionJsonFile, client)
return HandleHttpResponse(resp, err, "Post Request for Creating ATC System Configuration", connectionDetails)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
func doBatchATCSystemConfig(config *abapEnvironmentPushATCSystemConfigOptions, batchRequestBodyFile string, connectionDetails abaputils.ConnectionDetailsHTTP, client piperhttp.Sender) error {
abapEndpoint := connectionDetails.URL
connectionDetails.URL = abapEndpoint + "/$batch"
header := make(map[string][]string)
header["X-Csrf-Token"] = []string{connectionDetails.XCsrfToken}
header["Content-Type"] = []string{"multipart/mixed;boundary=request-separator"}
batchRequestBodyFileByte := []byte(batchRequestBodyFile)
resp, err := client.SendRequest("POST", connectionDetails.URL, bytes.NewBuffer(batchRequestBodyFileByte), header, nil)
return HandleHttpResponse(resp, err, "Batch Request for Patching ATC System Configuration", connectionDetails)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
func checkConfigExistsInBackend(config *abapEnvironmentPushATCSystemConfigOptions, atcSystemConfiguartionJsonFile []byte, connectionDetails abaputils.ConnectionDetailsHTTP, client piperhttp.Sender) (bool, string, string, time.Time, error) {
var configName string
var configUUID string
var configLastChangedAt time.Time
//extract Configuration Name from atcSystemConfiguartionJsonFile
var parsedConfigurationJson parsedConfigJsonWithExpand
err := json.Unmarshal(atcSystemConfiguartionJsonFile, &parsedConfigurationJson)
if err != nil {
return false, configName, configUUID, configLastChangedAt, err
}
//call a get on config with filter on given name
configName = parsedConfigurationJson.ConfName
abapEndpoint := connectionDetails.URL
connectionDetails.URL = abapEndpoint + "/configuration" + "?$filter=conf_name%20eq%20" + "'" + configName + "'"
if err != nil {
return false, configName, configUUID, configLastChangedAt, err
}
resp, err := abaputils.GetHTTPResponse("GET", connectionDetails, nil, client)
if err != nil {
return false, configName, configUUID, configLastChangedAt, err
}
var body []byte
body, err = io.ReadAll(resp.Body)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
if err != nil {
return false, configName, configUUID, configLastChangedAt, err
}
var parsedoDataResponse parsedOdataResp
if err = json.Unmarshal(body, &parsedoDataResponse); err != nil {
return false, configName, configUUID, configLastChangedAt, errors.New("GET Request for check existence of ATC System Configuration - Unexpected Response - Problem with Unmarshal body: " + string(body))
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
if len(parsedoDataResponse.Value) > 0 {
configUUID = parsedoDataResponse.Value[0].ConfUUID
configLastChangedAt = parsedoDataResponse.Value[0].LastChangedAt
log.Entry().Info("ATC System Configuration " + configName + " does exist and last changed at " + configLastChangedAt.Local().String())
return true, configName, configUUID, configLastChangedAt, nil
} else {
//response value is empty, so NOT found entity with this name!
log.Entry().Info("ATC System Configuration " + configName + " does not exist!")
return false, configName, "", configLastChangedAt, nil
}
}
func HandleHttpResponse(resp *http.Response, err error, message string, connectionDetails abaputils.ConnectionDetailsHTTP) error {
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
var bodyText []byte
var readError error
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
if resp == nil {
// Response is nil in case of a timeout
log.Entry().WithError(err).WithField("ABAP Endpoint", connectionDetails.URL).Error("Request failed")
} else {
log.Entry().WithField("StatusCode", resp.Status).Info(message)
bodyText, readError = io.ReadAll(resp.Body)
if readError != nil {
defer resp.Body.Close()
return readError
}
log.Entry().Infof("Response body: %s", bodyText)
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
errorDetails, parsingError := getErrorDetailsFromBody(resp, bodyText)
if parsingError == nil &&
errorDetails != "" {
err = errors.New(errorDetails)
}
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
defer resp.Body.Close()
return err
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
func getErrorDetailsFromBody(resp *http.Response, bodyText []byte) (errorString string, err error) {
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
// Include the error message of the ABAP Environment system, if available
var abapErrorResponse AbapError
var abapResp map[string]*json.RawMessage
//errors could also be reported inside an e.g. BATCH request wich returned with status code 200!!!
contentType := resp.Header.Get("Content-type")
if len(bodyText) != 0 &&
strings.Contains(contentType, "multipart/mixed") {
//scan for inner errors! (by now count as error only RespCode starting with 4 or 5)
if strings.Contains(string(bodyText), "HTTP/1.1 4") ||
strings.Contains(string(bodyText), "HTTP/1.1 5") {
errorString = fmt.Sprintf("Outer Response Code: %v - but at least one Inner response returned StatusCode 4* or 5*. Please check Log for details.", resp.StatusCode)
} else {
log.Entry().Info("no Inner Response Errors")
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
if errorString != "" {
return errorString, nil
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
}
if len(bodyText) != 0 &&
strings.Contains(contentType, "application/json") {
errUnmarshal := json.Unmarshal(bodyText, &abapResp)
if errUnmarshal != nil {
return errorString, errUnmarshal
}
if _, ok := abapResp["error"]; ok {
if err := json.Unmarshal(*abapResp["error"], &abapErrorResponse); err != nil {
return errorString, err
}
if (AbapError{}) != abapErrorResponse {
log.Entry().WithField("ErrorCode", abapErrorResponse.Code).Error(abapErrorResponse.Message.Value)
errorString = fmt.Sprintf("%s - %s", abapErrorResponse.Code, abapErrorResponse.Message.Value)
return errorString, nil
}
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
}
return errorString, errors.New("Could not parse the JSON error response. stringified body " + string(bodyText))
Add step abapEnvironmentPushATCSystemConfig (#3426) * Checkin Go File - Push ATC Config * ATC Push Config - Testfile * Initial generated go files for ATC System Configuration * ApiProxyUpload Command (#3295) * ApiProxyUpload Command * Code Review Fixes * CodeReview Changes * CodeReview Fixes * YAML fixes * CodeReview Fix * Code Review Fixes * CodeReview Fixes * Code Climate Fixes * Code Review Fixes * Code Review Fixes Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> * Fetch Xcrsf-Token * Update abapEnvironmentPushATCSystemConfig.yaml * docs: fix urls (#3400) * fix stash and adapt unit tests accordingly (#3403) * Push ATC System Configuration - File read, send request, parse response * fetchATCXcsrfToken * fix(whitesourceExecuteScan): added missing credential declaration for the docker config (#3404) * insert command in piper.go * feat(cnbBuild): remove docker config after parsing (#3417) Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * more funcs * more funcs * Revert "feat: Add debug output to getConfig (#3341)" (#3396) This reverts commit b760bf48e76ab010c520d70ae4d967c0a5b56f9d. Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat (kubernetesDeploy) allow secret creation in cluster with kubectl as deploy tool (#3398) * defaulting deocker config json location * function change * harmonising secret creation via json config apply * adding the env path to kaniko * env var * adding path * adding path * adding path * rolling back changes for path * adapting condition for secret creation * conditions based on username and password only * fix unit test as per new secret creation * update documentation with regards to secret creation * fixing yaml lint empty line * fixing trailing line from kaniko yaml * error condition when path of the docker config json file is not found Co-authored-by: anilkeshav27 <you@example.com> * readPipelineEnv -> Serialize Directly to os.Stdout (#3180) * Serialize CPE Directly to os.Stdout * Response Error Handling 1 * Add easy mode for AUnit & ATC (#3389) * remove mandatory flag from config files * Enable repo.yml as config * Adapt to merge * Refactoring * Refactoring * avoid panic * Add comments * Add easy mode for atc * Add tests * Add test * Refactor * Add test for MPS * Updates * Rename functions * Add files to gitignore * Rename * Renaming * Renaming * Renaming * Improve error messages * Update documentation * Add logging * Rename * Extend gitignore * fix(sonar): fix file patterns for gcs upload (#3406) Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> * testing piper forks (#3420) * developer doku update on how to test with forked repos Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com> * Error Messages parsing * Update yaml parameter * feat (npmExecuteScripts) create seperate npmrc file for publish to private repo (#3422) * creating new npm rc file * publishing to registry staging * exposing base64 version of env variables * changing encoding param * fixing unit test for the new path * debugging env var * remove debug message * update docu * changing new npmrc file name * adding new npmrc to ignore * adding new npmrc to ignore Co-authored-by: anilkeshav27 <you@example.com> * minor * small changes * small changes * UNIT Test * Unit Test 2 * Update .gitignore Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md: Unable to update target vectors with unchanged SWC version (#3392) * Update abapEnvironmentAddons.md * Update documentation/docs/scenarios/abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Update abapEnvironmentAddons.md Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> * Returning earlier & parseOdataResp 1 * new Parameter for overwrite existing * feat(cnbBuild): preserve maven test results in the workspace (#3429) Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> * Update Introduction (#3433) * Check Existence of configuration * Quote strings in addon.yml (#3435) * including vaultSecretFile to parameter generator docu (#3436) Co-authored-by: anilkeshav27 <you@example.com> * fix: wrong command line format for multiple extension files (#3434) * feat(cnbBuild) containerImageName will be defaulted if possible (#3437) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> * Corr. check existence * check existence 2 * existence handling 2 * refinement existence handling & param rename * config yaml change - no mandatory for bool param * PATCH for existing Configuration * fix: correct typo in log message (#3439) Closes #3438 * feat(protecode): add versioning model (#3373) * changes to detectExec before master merge * changes for detectExecuteScan * self generated code added * fix syntax errors and update docu * added unit tests for fail and Group * fix failOn bug * add Groups as string array * add Groups as string array * tests and validation for groups, failOn * Updated docs and added more tests * documentation md files should not be changed * Handle merge conflicts from PR 1845 * fix merge errors * remove duplicate groups, merge error * adding buildCode and buildTool as params * switching build options * building maven modules * parameter correction * parameter correction * gnerate with new build parameter * adding comments * removing piper lib master and modifying goUtils to download 1.5.7 release * first cleaning then installing * multi module maven built * multi module maven built removing unwanted code * multi module maven built moving inside switch * testing * modifying the default use case to also call maven build * modifying the default use case to also call maven build wih -- * corrected maven build command * corrected maven build command with %v * skipping test runs * testing for MTA project with single pom * adding absolute path to m2 path * clean up * adding switch for mta and maven and removing env from containers * commiting changes for new detect step * correting log message * code clean up * unit tests changes to detectExecute * basic tests for new change * restoring piperGoUtils to download correct piper binary * code clean up * code clean up * protecodeExecuteScan :: versioning model draft - 1 * protecodeExecuteScan :: version model draft-2 * protecodeExecuteScan :: changing filename and version concatenation * protecodeExecuteScan :: update documentation * protecodeExecuteScan :: double URL encoding has been corrected & console messaging improved * protecodeExecuteScan :: fixed Go/generate validation fail * protecodeExecuteScan :: fixing failed unit tests * protecodeExecuteScan :: Version field added * protecodeExecuteScan :: Version field add => minor changes * protecodeExecuteScan :: Version field add => fixing tests Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Keshav <anil.keshav@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * GCS Upload fixes (#3387) * Fixed argument type in persist function * Fixed gcp upload to be usable in internal piper * Fixed import of packages * Updated logs Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Unit Test 2 * Unit Tests * Add gcs upload to mavenExecuteIntegration step (#3432) * Add gcs upload to mavenExecuteIntegration step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Check times refine * Permwrite 0644 * disable http retry (#3447) * Update maxWaitTime timeout for WhiteSource (#3284) * Update scanPolling.go Changing maxWaitTime from 15 to 30 to overcome WhiteSource results reflection in the backend issue. * Update configHelper.go * Reset configHelper changes to fix PR 3284 Committer: raghunathd8 Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> * removed trailing spaces * yaml Update * minor mock for token & Unit Tests * rename Parameter Patch * lil refactor & Unit Test * fixes PATCH & more Unit Tests * add log at certain points * not writing configuration file back * feat(malwareExecuteScan): refactoring and docker support (#3421) * feat(malwareExecuteScan): add support for scanning docker images * refactoring * print out finding if available * generate toolrecord for malware scan * persist scan report * docs * fix * fix * rollback cmd/init_unix.go * auhenticated pull * fix * fix: report shall be consistent with the api model * gcs upload * fix linter * Fix potential nil reference (#3460) * Add gcs upload to karmaExecuteTests step (#3431) * Add gcs upload to karmaExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to gaugeExecuteTests step (#3410) * Add gcs upload to gaugeExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to newmanExecute step (#3408) * Add gcs upload to newmanExecute step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(GitHub): fetch commit statistics (#3381) * fetch GH statistics * move GH and Sonar integration tests to own files * fix imports * add integration test case * add result type * Apply suggestions from code review * feat: add command to fetch default files (#3445) * some ideas.. * Add getDefaults command (WIP) (#3444) * add getYAML function for configs * create getDefaults command(based on getConfig) * add getDefaults command to CLI * read defaults files, using github tokens as well * write defaults to stdout as JSON object with YAMLs embedded * catch case where no input files are given * actually write output to file if outputFile is specified * mark defaultsFile flag as required * add basic tests * add output (string) test * adapt generateDefaults() to return output (used for test of previous commit) * Changes to getDefaults() JSON output (#3449) * change JSON output to contain separate fields * filename -> filepath * Apply suggestions from code review * Apply suggestions from code review * Update pkg/config/config_test.go Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> * BATCH request preparation * Add gcs upload to mtaBuild step (#3405) * Add gcs upload to mtaBuild * Patterns was updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to mavenBuild step (#3394) * Add gcs upload to mavenBuild step * Patterns were updated * go generate * removed patterns related to sapGenerateEnvironmentInfo step Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(gradleExecuteBuild): add stage scope to path parameter, fix project dir exist issue (#3401) * add stage scope to path parameter, fix project dir exist issue * fix unit test for gradleExecuteBuild Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add gcs upload to uiVeri5ExecuteTests step (#3409) * Add gcs upload to uiVeri5ExecuteTests step * go generate Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Address further nil references (#3462) * Address further nil references * Message text * Final checks * fix (npmExecuteScripts) allow npm pack before npm publish (#3455) * adding config to piperNpmr * scope in cli * adding scope to repo url and npmrc * publish to scoped * removing scope * changing scope position * adding scope to userconfig * adding registry= * pack and then tar * not removing tmp folder * adding flag * pack before publish * adding log * debug * debug with change directory * publishing created tar ball * debug * üath * adding main npmrc * renaming old npmrc file * error renaming old npmrc file * renaming err * correcting npmrc file path * renaming file back to original * current working directory * renaming the npmrc file * avoiding change directory * with current working dir * adding dot * renaming npmrc and defer removal * rename files * Update pkg/npm/publish.go * Update pkg/npm/publish.go Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Add testing for helm during acceptance stage (#3402) * Add kubernetesDeploy to Acceptance * Add more kubernetesDeploy * Add helm tests * Change documentation * Fix docu * Change generated * Add tests * Add groovy tests * Fix tests * Change tests Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> * Batch Request for Patches * Fix(gctsDeploy) : add client in config url, disable retry for create and pull (#3464) * minor Unit Test correction * lil cleanup * lil refactoring * removed nuneeded linebreaks * refactoring Command on Entity in Batch * some Unit Tests for Build Batch Request * more Unittests - Build Batch Request * fix(fortifyExecuteScan): User assignment based on PR ownership (#3472) * Debug PR user details * Check association * Change to login * Fix PR creator assignment * Improve docs * Fix test * Update gradle version (#3476) * Update gradle version * Update generated file * small correction Text & Test * chore(kubernetesDeploy): add telemetry for deployTool (#3469) * chore(kubernetesDeploy): add telemetry for deployTool * Update cmd/kubernetesDeploy.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * rename Parameter patchIfExisting * fix (mtaBuild) keep mtar artifact name in synch with maven gav (#3454) * keep mtar name in synch with maven gav * retaining slashes * keeping dots in artifact name Co-authored-by: anilkeshav27 <you@example.com> * Update image for gradle build (#3479) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * Last Changed not Zero check added * Added pseudo_comment_policy in struct * Unit Test adaption * smaller refactoring, Unit Test, removed doubles * fix(cnbBuild) do not add complete path to telemetry (#3487) Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> * Add limitation that table keys are exported generically (#3490) * Add limitation that table keys are exported generically * Fix formatting * Clarify delta calculation of different package types (#3482) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * Add troubleshooting for missing add-on registration (#3491) Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat (Documentation) documentation for mavenBuild and npmExecuteScripts that consume dependencies from a private repo. (#3484) * build depdency docu for maven and npm * removing trailing white space in yaml * Update resources/metadata/mavenBuild.yaml * relative url for vault and mta docu * running go generate * keeping vault relative path * go generate * reverting to global paths * go generate * wild card for a higher level dir * searching on top folder only * relative level above * pointing to infrastructure * correcting links Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * fix(kanikoExecute): tmp dir (#3478) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): add support for publishing binaries (#3495) * fix(golangBuild): keep track of the artifactversion in binary names (#3498) * fix(golangBuild): keep track of the artifactversion in binary names * improve the naming scheme * fix (build dependency) typo corrections (#3494) * typo corrections * trailing white space * go generate Co-authored-by: anilkeshav27 <you@example.com> * Revert "fix(golangBuild): keep track of the artifactversion in binary names (#3498)" (#3499) This reverts commit ec783b0da65a508b3067b9baf5f9587cbbf0d30c. * sonarqube coverage: additional metrics (#3465) * sonarqube coverage: additional metrics * sonarExecuteScan: add lines of code and language distribution to sonarscan.json * sonarExecuteScan: consider branch in componentService requests * SonarQube: Do not omit empty values in SonarCoverage * sonarExecuteScan: Add integration tests for ComponentService getLinesOfCode * fix tests * sonarExecuteScan: use pullRequest in componentService Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> * fix(golangBuild): targetRepositoryUrl (#3502) * fix(golangBuild): targetRepositoryUrl * regen * fix(httpclient): folder permissions (#3506) * fix(golangBuild): use PUT instead of POST (#3504) Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * feat(golangBuild): publish to subfolder (#3503) * feat(golangBuild): publish to subfolder * edge case handling * fix * fix(golangBuild): expect status 201 instead of 200 (#3508) * feat(kanikoExecute): allow building multiple images (#3443) * feat(kanikoExecute): allow building multiple images * enhance tests * chore: allow running tests in parallel * small fixes * fix: fix destination bug * update formatting and defaults * fix yml formatting * chore: change cpe parameter names * chore: improve variable naming * Changes GetJobName value to repositoryname (#3509) * Update npmExecuteScripts step (#3211) * Update npmExecuteScripts step * Fixed failing build * Fixed path issue Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Christian Volk <christian.volk@sap.com> * Ignore violations if failOn is NONE (#3513) * fix(sonarExecuteScan): error handling for report metrics (#3512) * Generic step input from addon descriptor (#3467) * enhance build step to run based on addon.yml in steampunk environment Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> * feat(golangBuild): add BOM creation (#3496) * Added BOM creation * Fix cyclonedx install * undo config.yml changes * metadata was updated * Update golangBuild.go Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> * If statement dearrangement Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com> Co-authored-by: Mayur Belur Mohan <68264167+mayurmohan@users.noreply.github.com> Co-authored-by: Roland Stengel <r.stengel@sap.com> Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com> Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com> Co-authored-by: Jesse Awan <jesse.awan@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Marc Bormeth <marc.bormeth@sap.com> Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com> Co-authored-by: Anil Keshav <anil.keshav@sap.com> Co-authored-by: anilkeshav27 <you@example.com> Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com> Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com> Co-authored-by: Siarhei Pazdniakou <siarhei.pazdniakou@sap.com> Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com> Co-authored-by: Peter Persiel <6087940+peterpersiel@users.noreply.github.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Marcus Holl <marcus.holl@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com> Co-authored-by: Nikolay Grechanov <nikolay.grechanov@sap.com> Co-authored-by: Umidjon Urunov <79094563+UmidjonUrunov@users.noreply.github.com> Co-authored-by: D072410 <giridhar.shenoy@sap.com> Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com> Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com> Co-authored-by: Raghunath Deshpande <raghunath.deshpande@sap.com> Co-authored-by: raghunathd8 <root@docker-evaluation.openstack.eu-nl-1.cloud.sap> Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Eugene Kortelyov <eugene.kortelyov@sap.com> Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com> Co-authored-by: Thorsten Duda <thorsten.duda@sap.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@gmail.com> Co-authored-by: I550025 <r.kloe@sap.com> Co-authored-by: ffeldmann <f.feldmann@sap.com> Co-authored-by: ManjunathMS35 <manjunathms35@gmail.com> Co-authored-by: Matthias Scudlik <matthias.scudlik@sap.com> Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
2022-02-08 17:14:29 +02:00
}
func convertATCSysOptions(options *abapEnvironmentPushATCSystemConfigOptions) abaputils.AbapEnvironmentOptions {
subOptions := abaputils.AbapEnvironmentOptions{}
subOptions.CfAPIEndpoint = options.CfAPIEndpoint
subOptions.CfServiceInstance = options.CfServiceInstance
subOptions.CfServiceKeyName = options.CfServiceKeyName
subOptions.CfOrg = options.CfOrg
subOptions.CfSpace = options.CfSpace
subOptions.Host = options.Host
subOptions.Password = options.Password
subOptions.Username = options.Username
return subOptions
}
type parsedOdataResp struct {
Value []parsedConfigJsonWithExpand `json:"value"`
}
type parsedConfigJsonWithExpand struct {
ConfName string `json:"conf_name"`
ConfUUID string `json:"conf_id"`
LastChangedAt time.Time `json:"last_changed_at"`
Priorities []parsedConfigPriority `json:"_priorities"`
}
type parsedConfigPriorities struct {
Priorities []parsedConfigPriority `json:"_priorities"`
}
type parsedConfigPriority struct {
Test string `json:"test"`
MessageId string `json:"message_id"`
Priority json.Number `json:"priority"`
}
type priorityJson struct {
Priority json.Number `json:"priority"`
}
// AbapError contains the error code and the error message for ABAP errors
type AbapError struct {
Code string `json:"code"`
Message AbapErrorMessage `json:"message"`
}
// AbapErrorMessage contains the lanuage and value fields for ABAP errors
type AbapErrorMessage struct {
Lang string `json:"lang"`
Value string `json:"value"`
}