From 0006f10918f8365cc4cabcbe6dfee06c1b6eaa67 Mon Sep 17 00:00:00 2001 From: Googlom <36107508+Googlom@users.noreply.github.com> Date: Thu, 23 Nov 2023 16:21:40 +0500 Subject: [PATCH] fix log downloading in GH orchestrator (#4683) Co-authored-by: Gulom Alimov --- pkg/orchestrator/gitHubActions.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/orchestrator/gitHubActions.go b/pkg/orchestrator/gitHubActions.go index 9847fbacc..ba737c456 100644 --- a/pkg/orchestrator/gitHubActions.go +++ b/pkg/orchestrator/gitHubActions.go @@ -100,7 +100,13 @@ func (g *GitHubActionsConfigProvider) GetLog() ([]byte, error) { wg.Go(func() error { _, resp, err := g.client.Actions.GetWorkflowJobLogs(g.ctx, g.owner, g.repo, jobs[i].ID, true) if err != nil { - return errors.Wrap(err, "fetching job logs failed") + // GetWorkflowJobLogs returns "200 OK" as error when log download is successful. + // Therefore, ignore this error. + // GitHub API returns redirect URL instead of plain text logs. See: + // https://docs.github.com/en/enterprise-server@3.9/rest/actions/workflow-jobs?apiVersion=2022-11-28#download-job-logs-for-a-workflow-run + if err.Error() != "unexpected status code: 200 OK" { + return errors.Wrap(err, "fetching job logs failed") + } } defer resp.Body.Close()