Update Cloud SDK stash settings and stage defaults (#2105)

This change updates and cleans up the Cloud SDK specific stash settings
and stage defaults.

resources/com.sap.piper/pipeline/cloudSdkContainersMap.yml

@@ -1,7 +1,6 @@
 # Mapping of Go step names to their YAML metadata resource file
 stepMetadata:
   artifactPrepareVersion: versioning.yaml
-  fortifyExecuteScan: fortify.yaml
   mavenExecute: mavenExecute.yaml
   mavenExecuteStaticCodeChecks: mavenStaticCodeChecks.yaml
   mtaBuild: mtaBuild.yaml
@@ -9,8 +8,6 @@ stepMetadata:
   npmExecuteScripts: npmExecuteScripts.yaml
   npmExecuteLint: npmExecuteLint.yaml
   sonarExecuteScan: sonar.yaml
-  detectExecuteScan: detect.yaml
-  whitesourceExecuteScan: whitesource.yaml
 
 # Mapping of stages to the steps (and by extension Docker images) they use
 containerMaps:
@@ -35,10 +32,6 @@ containerMaps:
     - npmExecuteScripts
   additionalUnitTests:
     - npmExecuteScripts
-  fortifyScan:
-    - fortifyExecuteScan
-  npmAudit:
-    - executeNpm
   endToEndTests:
     - mavenExecute
     - npmExecuteScripts
@@ -50,17 +43,8 @@ containerMaps:
     - checkJMeter
     - cloudFoundryDeploy
     - neoDeploy
-  s4SdkQualityChecks:
-    - mavenExecute
   artifactDeployment:
     - nexusUpload
-  whitesourceScan:
-    - mavenExecute
-    - executeNpm
-  security:
-    - fortifyExecuteScan
-    - detectExecuteScan
-    - whitesourceExecuteScan
   compliance:
     - sonarExecuteScan
   productionDeployment:

resources/com.sap.piper/pipeline/cloudSdkJavaStashSettings.yml

@@ -50,38 +50,10 @@ frontendIntegrationTests:
       merge: true
       includes: "s4hana_pipeline/reports/**, **/target/site/**/jacoco.xml"
 
-checkmarxScan:
-  unstash: ["SOURCE", "TARGET"]
-  stashes: []
-
-whitesourceScan:
-  unstash: ["SOURCE", "M2", "NODE_MODULES", "PACKAGE_LOCK"]
-  stashes: []
-
-security:
-  unstash: ["SOURCE", "M2", "TARGET", "NODE_MODULES", "PACKAGE_LOCK"]
-  stashes: []
-
-additionalTools:
-  unstash: ["SOURCE", "M2", "NODE_MODULES", "GENERATED_CAP_FILES"]
-  stashes: []
-
 compliance:
   unstash: ['SOURCE', 'M2', 'REPORTS', 'TARGET', 'EXEC_FILES']
   stashes: []
 
-fortifyScan:
-  unstash: ["SOURCE", "M2", "TARGET"]
-  stashes: []
-
-detect:
-  unstash: ["SOURCE", "M2", "TARGET"]
-  stashes: []
-
-npmAudit:
-  unstash: ["SOURCE", "PACKAGE_LOCK"]
-  stashes: []
-
 additionalUnitTests:
   unstash: ["SOURCE", "NODE_MODULES", "GENERATED_CAP_FILES"]
   stashes:
@@ -100,12 +72,6 @@ performanceTests:
       merge: true
       includes: "s4hana_pipeline/reports/**"
 
-s4SdkQualityChecks:
-  unstash: ["SOURCE", "M2", "TARGET", "REPORTS", "EXEC_FILES"]
-  stashes:
-    - name: "REPORTS"
-      includes: "s4hana_pipeline/reports/**"
-
 artifactDeployment:
   unstash: ["SOURCE", "M2", "TARGET", "NODE_MODULES", "GENERATED_CAP_FILES"]
   stashes: []

resources/com.sap.piper/pipeline/cloudSdkJavascriptStashSettings.yml

@@ -51,29 +51,6 @@ compliance:
   unstash: ['SOURCE', 'NODE_MODULES', 'DIST']
   stashes: []
 
-npmAudit:
-  unstash: ["SOURCE", "PACKAGE_LOCK"]
-  stashes: []
-
-s4SdkQualityChecks:
-  unstash: ["SOURCE", "DIST", "REPORTS"]
-
-whitesourceScan:
-  unstash: ["SOURCE", "NODE_MODULES", "PACKAGE_LOCK"]
-  stashes: []
-
-checkmarxScan:
-  unstash: ["SOURCE"]
-  stashes: []
-
-detect:
-  unstash: ["SOURCE"]
-  stashes: []
-
-security:
-  unstash: ["SOURCE", "NODE_MODULES", "PACKAGE_LOCK"]
-  stashes: []
-
 endToEndTests:
   unstash: ["SOURCE", "DEPLOYMENTARTIFACT", "NODE_MODULES", "GENERATED_CAP_FILES"]
   stashes: []

resources/com.sap.piper/pipeline/cloudSdkMtaStashSettings.yml

@@ -50,38 +50,10 @@ frontendIntegrationTests:
       merge: true
       includes: "s4hana_pipeline/reports/**, **/target/site/**/jacoco.xml"
 
-checkmarxScan:
-  unstash: ["SOURCE", "TARGET"]
-  stashes: []
-
-whitesourceScan:
-  unstash: ["SOURCE", "M2", "NODE_MODULES", "PACKAGE_LOCK"]
-  stashes: []
-
-additionalTools:
-  unstash: ["SOURCE", "M2", "NODE_MODULES"]
-  stashes: []
-
 compliance:
   unstash: ['SOURCE', 'M2', 'NODE_MODULES', 'REPORTS', 'TARGET']
   stashes: []
 
-fortifyScan:
-  unstash: ["SOURCE", "M2", "TARGET"]
-  stashes: []
-
-detect:
-  unstash: ["SOURCE", "M2", "TARGET"]
-  stashes: []
-
-security:
-  unstash: ["SOURCE", "M2", "TARGET", "NODE_MODULES", "PACKAGE_LOCK"]
-  stashes: []
-
-npmAudit:
-  unstash: ["SOURCE", "PACKAGE_LOCK"]
-  stashes: []
-
 additionalUnitTests:
   unstash: ["SOURCE", "NODE_MODULES"]
   stashes:
@@ -100,12 +72,6 @@ performanceTests:
       merge: true
       includes: "s4hana_pipeline/reports/**"
 
-s4SdkQualityChecks:
-  unstash: ["SOURCE", "M2", "TARGET", "REPORTS", "EXEC_FILES"]
-  stashes:
-    - name: "REPORTS"
-      includes: "s4hana_pipeline/reports/**"
-
 artifactDeployment:
   unstash: ["SOURCE", "M2", "TARGET", "NODE_MODULES", "EXEC_FILES"]
   stashes: []

resources/com.sap.piper/pipeline/cloudSdkStageDefaults.yml

@@ -24,13 +24,6 @@ stages:
           - 'sonarTokenCredentialsId'
           - 'projectKey'
           - 'instance'
-  security:
-    stepConditions:
-      whitesourceExecuteScan:
-        configKeys:
-          - 'productName'
-          - 'orgAdminUserTokenCredentialsId'
-          - 'userTokenCredentialsId'
   frontendIntegrationTests:
     stepConditions:
       npmExecuteScripts:
@@ -41,10 +34,6 @@ stages:
       npmExecuteScripts:
         npmScripts:
           - 'ci-frontend-unit-test'
-  npmAudit:
-    stepConditions:
-      npmAudit:
-        filePattern: '**/package.json'
   endToEndTests:
     stepConditions:
       multicloudDeploy:
@@ -75,45 +64,6 @@ stages:
         configKeys:
           - 'cfTargets'
           - 'neoTargets'
-  checkmarxScan:
-    onlyProductiveBranch: true
-    stepConditions:
-      checkmarxScan:
-        configKeys:
-          - 'groupId'
-  sonarQubeScan:
-    stepConditions:
-      sonarQubeScan:
-        configKeys:
-          - 'projectKey'
-          - 'instance'
-  additionalTools:
-    onlyProductiveBranch: true
-    extensionExists: true
-  whitesourceScan:
-    onlyProductiveBranch: true
-    stepConditions:
-      whitesourceExecuteScan:
-        configKeys:
-          - 'productName'
-          - 'orgAdminUserTokenCredentialsId'
-          - 'userTokenCredentialsId'
-      whitesourceScan:
-        configKeys:
-          - 'product'
-          - 'credentialsId'
-  fortifyScan:
-    onlyProductiveBranch: true
-    stepConditions:
-      fortifyExecuteScan:
-        configKeys:
-          - 'fortifyCredentialsId'
-  detectScan:
-    onlyProductiveBranch: true
-    stepConditions:
-      detectScan:
-        configKeys:
-          - 'detectTokenCredentialsId'
   security:
     onlyProductiveBranch: true
     stepConditions:
@@ -128,7 +78,7 @@ stages:
           - 'fortifyCredentialsId'
       whitesourceExecuteScan:
         configKeys:
-          - 'product'
+          - 'productName'
           - 'orgAdminUserTokenCredentialsId'
           - 'userTokenCredentialsId'
   productionDeployment: