jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-12 10:55:20 +02:00
Code Issues Releases Activity

Merge pull request #203 from marcusholl/pr/condenceParameters

Browse Source 
Do not repeat the same parameter names for different configuration la…
This commit is contained in:
Marcus Holl 2018-07-13 09:04:40 +02:00 committed by GitHub
commit 1bb3cb4d1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
vars/checkChangeInDevelopment.groovy
View File

@ -9,8 +9,7 @@ import com.sap.piper.cm.ChangeManagementException
@Field def STEP_NAME = 'checkChangeInDevelopment' @Field def STEP_NAME = 'checkChangeInDevelopment'
@Field Set parameterKeys = [ @Field Set stepConfigurationKeys = [
'changeDocumentId',
'cmClientOpts', 'cmClientOpts',
'credentialsId', 'credentialsId',
'endpoint', 'endpoint',
@ -21,17 +20,7 @@ import com.sap.piper.cm.ChangeManagementException
'gitFormat' 'gitFormat'
] ]
@Field Set stepConfigurationKeys = [ @Field Set parameterKeys = stepConfigurationKeys.plus('changeDocumentId')
'changeDocumentId',
'cmClientOpts',
'credentialsId',
'endpoint',
'failIfStatusIsNotInDevelopment',
'gitFrom',
'gitTo',
'gitChangeDocumentLabel',
'gitFormat'
]
@Field Set generalConfigurationKeys = stepConfigurationKeys @Field Set generalConfigurationKeys = stepConfigurationKeys

14
vars/transportRequestCreate.groovy
View File

@ -11,18 +11,6 @@ import hudson.AbortException
@Field def STEP_NAME = 'transportRequestCreate' @Field def STEP_NAME = 'transportRequestCreate'
@Field Set parameterKeys = [
'changeDocumentId',
'clientOpts',
'developmentSystemId',
'credentialsId',
'endpoint',
'gitFrom',
'gitTo',
'gitChangeDocumentLabel',
'gitFormat'
]
@Field Set stepConfigurationKeys = [ @Field Set stepConfigurationKeys = [
'credentialsId', 'credentialsId',
'clientOpts', 'clientOpts',
@ -33,6 +21,8 @@ import hudson.AbortException
'gitFormat' 'gitFormat'
] ]
@Field Set parameterKeys = stepConfigurationKeys.plus(['changeDocumentId', 'developmentSystemId'])
@Field generalConfigurationKeys = stepConfigurationKeys @Field generalConfigurationKeys = stepConfigurationKeys
def call(parameters = [:]) { def call(parameters = [:]) {

13
vars/transportRequestRelease.groovy
View File

@ -11,20 +11,17 @@ import hudson.AbortException
@Field def STEP_NAME = 'transportRequestRelease' @Field def STEP_NAME = 'transportRequestRelease'
@Field Set parameterKeys = [
'changeDocumentId',
'cmClientOpts',
'transportRequestId',
'credentialsId',
'endpoint'
]
@Field Set stepConfigurationKeys = [ @Field Set stepConfigurationKeys = [
'credentialsId', 'credentialsId',
'cmClientOpts', 'cmClientOpts',
'endpoint' 'endpoint'
] ]
@Field Set parameterKeys = stepConfigurationKeys.plus([
'changeDocumentId',
'transportRequestId',
])
@Field Set generalConfigurationKeys = stepConfigurationKeys @Field Set generalConfigurationKeys = stepConfigurationKeys
def call(parameters = [:]) { def call(parameters = [:]) {

20
vars/transportRequestUploadFile.groovy
View File

@ -11,20 +11,6 @@ import hudson.AbortException
@Field def STEP_NAME = 'transportRequestUploadFile' @Field def STEP_NAME = 'transportRequestUploadFile'
@Field Set parameterKeys = [
'changeDocumentId',
'cmClientOpts',
'transportRequestId',
'applicationId',
'filePath',
'credentialsId',
'endpoint',
'gitFrom',
'gitTo',
'gitChangeDocumentLabel',
'gitFormat'
]
@Field Set generalConfigurationKeys = [ @Field Set generalConfigurationKeys = [
'credentialsId', 'credentialsId',
'cmClientOpts', 'cmClientOpts',
@ -35,6 +21,12 @@ import hudson.AbortException
'gitFormat' 'gitFormat'
] ]
@Field Set parameterKeys = generalConfigurationKeys.plus([
'applicationId',
'changeDocumentId',
'filePath',
'transportRequestId'])
@Field Set stepConfigurationKeys = generalConfigurationKeys @Field Set stepConfigurationKeys = generalConfigurationKeys
def call(parameters = [:]) { def call(parameters = [:]) {