1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-11-24 08:32:32 +02:00

Do not repeat the same parameter names for different configuration layers

changeId is removed from the step parameters since the changeId
is specific to the build. Hence there is no reason for providing
it from the deeper configuration layers.
This commit is contained in:
Marcus Holl 2018-07-12 09:49:18 +02:00
parent 1423522e2f
commit 2310bb4bd5
4 changed files with 15 additions and 38 deletions

View File

@ -9,8 +9,7 @@ import com.sap.piper.cm.ChangeManagementException
@Field def STEP_NAME = 'checkChangeInDevelopment'
@Field Set parameterKeys = [
'changeDocumentId',
@Field Set stepConfigurationKeys = [
'cmClientOpts',
'credentialsId',
'endpoint',
@ -21,17 +20,7 @@ import com.sap.piper.cm.ChangeManagementException
'gitFormat'
]
@Field Set stepConfigurationKeys = [
'changeDocumentId',
'cmClientOpts',
'credentialsId',
'endpoint',
'failIfStatusIsNotInDevelopment',
'gitFrom',
'gitTo',
'gitChangeDocumentLabel',
'gitFormat'
]
@Field Set parameterKeys = stepConfigurationKeys.plus('changeDocumentId')
@Field Set generalConfigurationKeys = stepConfigurationKeys

View File

@ -11,20 +11,14 @@ import hudson.AbortException
@Field def STEP_NAME = 'transportRequestCreate'
@Field Set parameterKeys = [
'changeDocumentId',
'clientOpts',
'developmentSystemId',
'credentialsId',
'endpoint'
]
@Field Set stepConfigurationKeys = [
'credentialsId',
'clientOpts',
'endpoint'
]
@Field Set parameterKeys = stepConfigurationKeys.plus(['changeDocumentId', 'developmentSystemId'])
@Field generalConfigurationKeys = stepConfigurationKeys
def call(parameters = [:]) {

View File

@ -11,20 +11,17 @@ import hudson.AbortException
@Field def STEP_NAME = 'transportRequestRelease'
@Field Set parameterKeys = [
'changeDocumentId',
'cmClientOpts',
'transportRequestId',
'credentialsId',
'endpoint'
]
@Field Set stepConfigurationKeys = [
'credentialsId',
'cmClientOpts',
'endpoint'
]
@Field Set parameterKeys = stepConfigurationKeys.plus([
'changeDocumentId',
'transportRequestId',
])
@Field Set generalConfigurationKeys = stepConfigurationKeys
def call(parameters = [:]) {

View File

@ -11,20 +11,17 @@ import hudson.AbortException
@Field def STEP_NAME = 'transportRequestUploadFile'
@Field Set parameterKeys = [
'changeDocumentId',
'transportRequestId',
'applicationId',
'filePath',
'credentialsId',
'endpoint'
]
@Field Set generalConfigurationKeys = [
'credentialsId',
'endpoint'
]
@Field Set parameterKeys = generalConfigurationKeys.plus([
'applicationId',
'changeDocumentId',
'filePath',
'transportRequestId'])
@Field Set stepConfigurationKeys = generalConfigurationKeys
def call(parameters = [:]) {