Merge pull request #302 from marcusholl/pr/noExplictGetterAnDSettersInCommonPipelineEnvironment

Remove explict getters and setters from common pipeline environment

vars/commonPipelineEnvironment.groovy

@@ -5,8 +5,8 @@ class commonPipelineEnvironment implements Serializable {
     def artifactVersion
 
     //stores the gitCommitId as well as additional git information for the build during pipeline run
-    private String gitCommitId
-    private String gitSshUrl
+    String gitCommitId
+    String gitSshUrl
 
     //stores properties for a pipeline which build an artifact and then bundles it into a container
     private Map appContainerProperties = [:]
@@ -19,7 +19,7 @@ class commonPipelineEnvironment implements Serializable {
     //influxCustomData represents measurement jenkins_custom_data in Influx. Metrics can be written into this map
     private Map influxCustomData = [:]
 
-    private String mtarFilePath
+    String mtarFilePath
 
     def reset() {
         appContainerProperties = [:]
@@ -45,22 +45,6 @@ class commonPipelineEnvironment implements Serializable {
         return appContainerProperties[property]
     }
 
-    def setArtifactVersion(version) {
-        artifactVersion = version
-    }
-
-    def getArtifactVersion() {
-        return artifactVersion
-    }
-
-    def setConfigProperties(map) {
-        configProperties = map
-    }
-
-    def getConfigProperties() {
-        return configProperties
-    }
-
     def setConfigProperty(property, value) {
         configProperties[property] = value
     }
@@ -72,22 +56,6 @@ class commonPipelineEnvironment implements Serializable {
             return configProperties[property]
     }
 
-    def setGitCommitId(commitId) {
-        gitCommitId = commitId
-    }
-
-    def getGitCommitId() {
-        return gitCommitId
-    }
-
-    def setGitSshUrl(url) {
-        gitSshUrl = url
-    }
-
-    def getGitSshUrl() {
-        return gitSshUrl
-    }
-
     def getInfluxCustomData() {
         return influxCustomData
     }
@@ -103,15 +71,6 @@ class commonPipelineEnvironment implements Serializable {
         return influxCustomDataMap.step_data[dataKey]
     }
 
-
-    def getMtarFilePath() {
-        return mtarFilePath
-    }
-
-    void setMtarFilePath(mtarFilePath) {
-        this.mtarFilePath = mtarFilePath
-    }
-
     def setPipelineMeasurement (measurementName, value) {
         influxCustomDataMap.pipeline_data[measurementName] = value
     }