From 1e0fa0799e5244766a8f58230a7e853dce43fb17 Mon Sep 17 00:00:00 2001 From: Marcus Holl Date: Thu, 19 Jul 2018 10:06:40 +0200 Subject: [PATCH] [fix] Remove early check for mandatory param 'changeDocumentId' otherwise we will never try to read the change document id from commit history. --- test/groovy/TransportRequestReleaseTest.groovy | 2 +- vars/transportRequestRelease.groovy | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/test/groovy/TransportRequestReleaseTest.groovy b/test/groovy/TransportRequestReleaseTest.groovy index f6fe2e3bb..f498c0479 100644 --- a/test/groovy/TransportRequestReleaseTest.groovy +++ b/test/groovy/TransportRequestReleaseTest.groovy @@ -57,7 +57,7 @@ public class TransportRequestReleaseTest extends BasePiperTest { } thrown.expect(IllegalArgumentException) - thrown.expectMessage("ERROR - NO VALUE AVAILABLE FOR changeDocumentId") + thrown.expectMessage("Change document id not provided (parameter: 'changeDocumentId' or via commit history).") jsr.step.call(script: nullScript, transportRequestId: '001', cmUtils: cm) } diff --git a/vars/transportRequestRelease.groovy b/vars/transportRequestRelease.groovy index defa1e8db..01ce6ab79 100644 --- a/vars/transportRequestRelease.groovy +++ b/vars/transportRequestRelease.groovy @@ -43,7 +43,6 @@ def call(parameters = [:]) { .mixinStageConfig(script.commonPipelineEnvironment, parameters.stageName?:env.STAGE_NAME, stepConfigurationKeys) .mixinStepConfig(script.commonPipelineEnvironment, stepConfigurationKeys) .mixin(parameters, parameterKeys) - .withMandatoryProperty('changeDocumentId') .withMandatoryProperty('endpoint') Map configuration = configHelper.use()