jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-02-21 19:48:53 +02:00
Code Issues Releases Activity

Update spotbugs-maven-plugin to 4.1.4 (#2227)

Browse Source
This commit is contained in:
Florian Wilhelm 2020-10-23 15:43:34 +02:00 committed by GitHub
parent bdfe90ed49
commit 5eca4c307a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/mavenExecuteStaticCodeChecks.go
View File

@ -73,7 +73,7 @@ func getSpotBugsMavenParameters(config *mavenExecuteStaticCodeChecksOptions) *ma
mavenOptions := maven.ExecuteOptions{
// check goal executes spotbugs goal first and fails the build if any bugs were found
Goals: []string{"com.github.spotbugs:spotbugs-maven-plugin:4.0.4:check"},
Goals: []string{"com.github.spotbugs:spotbugs-maven-plugin:4.1.4:check"},
Defines: defines,
}

6
cmd/mavenExecuteStaticCodeChecks_test.go
View File

@ -32,7 +32,7 @@ func TestRunMavenStaticCodeChecks(t *testing.T) {
"-Dpmd.failurePriority=2",
"-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn",
"--batch-mode",
"com.github.spotbugs:spotbugs-maven-plugin:4.0.4:check",
"com.github.spotbugs:spotbugs-maven-plugin:4.1.4:check",
"org.apache.maven.plugins:maven-pmd-plugin:3.13.0:check",
},
}
@ -106,7 +106,7 @@ func TestGetSpotBugsMavenParameters(t *testing.T) {
SpotBugsMaxAllowedViolations: 123,
}
expected := maven.ExecuteOptions{
Goals: []string{"com.github.spotbugs:spotbugs-maven-plugin:4.0.4:check"},
Goals: []string{"com.github.spotbugs:spotbugs-maven-plugin:4.1.4:check"},
Defines: []string{"-Dspotbugs.includeFilterFile=includeFilter.xml", "-Dspotbugs.excludeFilterFile=excludeFilter.xml", "-Dspotbugs.maxAllowedViolations=123"},
}
@ -115,7 +115,7 @@ func TestGetSpotBugsMavenParameters(t *testing.T) {
t.Run("should return maven goal only", func(t *testing.T) {
config := mavenExecuteStaticCodeChecksOptions{}
expected := maven.ExecuteOptions{
Goals: []string{"com.github.spotbugs:spotbugs-maven-plugin:4.0.4:check"}}
Goals: []string{"com.github.spotbugs:spotbugs-maven-plugin:4.1.4:check"}}
assert.Equal(t, &expected, getSpotBugsMavenParameters(&config))
})