chore!: improve performance on Kubernetes (#3932)

* chore: test stashBack excludes

* improve logging

* chore!: improve performance on Kubernetes

* update stash pattern

* update test

Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>

resources/default_pipeline_environment.yml

@@ -236,6 +236,7 @@ steps:
       workspace: '**/*'
     stashExcludes:
       workspace: 'nohup.out'
+      stashBack: '**/node_modules/**,nohup.out'
   dubExecute:
     dockerImage: 'dlang2/dmd-ubuntu:latest'
   githubPublishRelease:

test/groovy/DockerExecuteOnKubernetesTest.groovy

@@ -800,11 +800,11 @@ class DockerExecuteOnKubernetesTest extends BasePiperTest {
             bodyExecuted = true
         }
         assertThat(stashList, hasItem(allOf(
-            not(hasEntry('allowEmpty', true)),
+            hasEntry('allowEmpty', true),
             hasEntry('includes', 'workspace/include.test'),
             hasEntry('excludes', 'workspace/exclude.test'))))
         assertThat(stashList, hasItem(allOf(
-            not(hasEntry('allowEmpty', true)),
+            hasEntry('allowEmpty', true),
             hasEntry('includes', 'container/include.test'),
             hasEntry('excludes', 'container/exclude.test'))))
     }

vars/dockerExecuteOnKubernetes.groovy

@@ -379,6 +379,11 @@ chown -R ${runAsUser}:${fsGroup} ."""
 
         def includes, excludes
 
+        if (config.verbose) {
+            echo "stashIncludes config: ${config.stashIncludes}"
+            echo "stashExcludes config: ${config.stashExcludes}"
+        }
+
         if (stashBack) {
             includes = config.stashIncludes.stashBack ?: config.stashIncludes.workspace
             excludes = config.stashExcludes.stashBack ?: config.stashExcludes.workspace
@@ -387,6 +392,11 @@ chown -R ${runAsUser}:${fsGroup} ."""
             excludes = config.stashExcludes.workspace
         }
 
+        if (config.verbose) {
+            echo "stash effective (includes): ${includes}"
+            echo "stash effective (excludes): ${excludes}"
+        }
+
         stash(
             name: stashName,
             includes: includes,
@@ -394,6 +404,7 @@ chown -R ${runAsUser}:${fsGroup} ."""
             // 'true' by default due to negative side-effects, but can be overwritten via parameters
             // (as done by artifactPrepareVersion to preserve the .git folder)
             useDefaultExcludes: !config.stashNoDefaultExcludes,
+            allowEmpty: true
         )
         return stashName
     } catch (AbortException | IOException e) {