Piper steps: Issue SUCCESS message (#1478)

* Piper steps: Issue SUCCESS message

Log `SUCCESS` message in all steps by default if no error occured

* Update additional generated steps

* Update generated step

cmd/abapEnvironmentPullGitRepo_generated.go

@@ -77,6 +77,7 @@ Please provide either of the following options:
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			abapEnvironmentPullGitRepo(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/abapEnvironmentRunATCCheck_generated.go

@@ -77,6 +77,7 @@ Regardless of the option you chose, please make sure to provide the configuratio
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			abapEnvironmentRunATCCheck(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/artifactPrepareVersion.go

@@ -58,7 +58,6 @@ func artifactPrepareVersion(config artifactPrepareVersionOptions, telemetryData
 	if err != nil {
 		log.Entry().WithError(err).Fatal("artifactPrepareVersion failed")
 	}
-	log.Entry().Info("SUCCESS")
 }
 
 var sshAgentAuth = ssh.NewSSHAgentAuth

cmd/artifactPrepareVersion_generated.go

@@ -179,6 +179,7 @@ Define ` + "`" + `buildTool: custom` + "`" + `, ` + "`" + `filePath: <path to yo
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			artifactPrepareVersion(stepConfig, &telemetryData, &commonPipelineEnvironment)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/checkmarxExecuteScan_generated.go

@@ -216,6 +216,7 @@ thresholds instead of ` + "`" + `percentage` + "`" + ` whereas we strongly recom
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			checkmarxExecuteScan(stepConfig, &telemetryData, &influx)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/cloudFoundryCreateServiceKey_generated.go

@@ -71,6 +71,7 @@ func CloudFoundryCreateServiceKeyCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			cloudFoundryCreateServiceKey(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/cloudFoundryDeleteService_generated.go

@@ -70,6 +70,7 @@ func CloudFoundryDeleteServiceCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			cloudFoundryDeleteService(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/containerSaveImage_generated.go

@@ -67,6 +67,7 @@ It can be used no matter if a Docker daemon is available or not. It will also wo
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			containerSaveImage(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/detectExecuteScan_generated.go

@@ -70,6 +70,7 @@ func DetectExecuteScanCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			detectExecuteScan(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/gctsCreateRepository_generated.go

@@ -72,6 +72,7 @@ func GctsCreateRepositoryCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			gctsCreateRepository(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/gctsDeploy_generated.go

@@ -69,6 +69,7 @@ func GctsDeployCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			gctsDeploy(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/githubCreatePullRequest_generated.go

@@ -75,6 +75,7 @@ It can for example be used for GitOps scenarios or for scenarios where you want
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			githubCreatePullRequest(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/githubPublishRelease_generated.go

@@ -85,6 +85,7 @@ The result looks like
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			githubPublishRelease(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/karmaExecuteTests_generated.go

@@ -74,6 +74,7 @@ In the Docker network, the containers can be referenced by the values provided i
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			karmaExecuteTests(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/kubernetesDeploy_generated.go

@@ -101,6 +101,7 @@ helm upgrade <deploymentName> <chartPath> --install --force --namespace <namespa
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			kubernetesDeploy(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/malwareExecuteScan_generated.go

@@ -67,6 +67,7 @@ func MalwareExecuteScanCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			malwareExecuteScan(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/mavenBuild_generated.go

@@ -70,6 +70,7 @@ supports ci friendly versioning by flattening the pom before installing.`,
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			mavenBuild(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/mavenExecuteStaticCodeChecks_generated.go

@@ -80,6 +80,7 @@ For PMD the failure priority and the max allowed violations are configurable via
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			mavenExecuteStaticCodeChecks(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/mavenExecute_generated.go

@@ -70,6 +70,7 @@ func MavenExecuteCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			mavenExecute(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/mtaBuild_generated.go

@@ -102,6 +102,7 @@ func MtaBuildCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			mtaBuild(stepConfig, &telemetryData, &commonPipelineEnvironment)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/nexusUpload_generated.go

@@ -90,6 +90,7 @@ If an image for mavenExecute is configured, and npm packages are to be published
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			nexusUpload(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/npmExecuteScripts_generated.go

@@ -65,6 +65,7 @@ func NpmExecuteScriptsCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			npmExecuteScripts(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/protecodeExecuteScan_generated.go

@@ -131,6 +131,7 @@ func ProtecodeExecuteScanCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			protecodeExecuteScan(stepConfig, &telemetryData, &influx)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/sonarExecuteScan_generated.go

@@ -119,6 +119,7 @@ func SonarExecuteScanCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			sonarExecuteScan(stepConfig, &telemetryData, &influx)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/version_generated.go

@@ -61,6 +61,7 @@ func VersionCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			version(stepConfig, &telemetryData)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

cmd/xsDeploy_generated.go

@@ -106,6 +106,7 @@ func XsDeployCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			xsDeploy(stepConfig, &telemetryData, &commonPipelineEnvironment)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

pkg/generator/helper/helper.go

@@ -115,6 +115,7 @@ func {{.CobraCmdFuncName}}() *cobra.Command {
 			telemetry.Initialize({{if .ExportPrefix}}{{ .ExportPrefix }}.{{end}}GeneralConfig.NoTelemetry, STEP_NAME)
 			{{.StepName}}(stepConfig, &telemetryData{{ range $notused, $oRes := .OutputResources}}, &{{ index $oRes "name" }}{{ end }})
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

pkg/generator/helper/testdata/TestProcessMetaFiles/custom_step_code_generated.golden

@@ -140,6 +140,7 @@ func TestStepCommand() *cobra.Command {
 			telemetry.Initialize(piperOsCmd.GeneralConfig.NoTelemetry, STEP_NAME)
 			testStep(stepConfig, &telemetryData, &commonPipelineEnvironment, &influxTest)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}
 

pkg/generator/helper/testdata/TestProcessMetaFiles/step_code_generated.golden

@@ -139,6 +139,7 @@ func TestStepCommand() *cobra.Command {
 			telemetry.Initialize(GeneralConfig.NoTelemetry, STEP_NAME)
 			testStep(stepConfig, &telemetryData, &commonPipelineEnvironment, &influxTest)
 			telemetryData.ErrorCode = "0"
+			log.Entry().Info("SUCCESS")
 		},
 	}