jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-01-22 05:33:10 +02:00
Code Issues Releases Activity

Merge pull request #222 from marcusholl/pr/fixRemoveEarlyCheckForChangeDocumentId

Browse Source 
[fix] Remove early check for mandatory param 'changeDocumentId'
This commit is contained in:
Marcus Holl 2018-07-20 09:25:38 +02:00 committed by GitHub
commit 8563df62dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/groovy/TransportRequestReleaseTest.groovy
View File

@ -57,7 +57,7 @@ public class TransportRequestReleaseTest extends BasePiperTest {
} }
thrown.expect(IllegalArgumentException) thrown.expect(IllegalArgumentException)
thrown.expectMessage("ERROR - NO VALUE AVAILABLE FOR changeDocumentId") thrown.expectMessage("Change document id not provided (parameter: 'changeDocumentId' or via commit history).")
jsr.step.call(script: nullScript, transportRequestId: '001', cmUtils: cm) jsr.step.call(script: nullScript, transportRequestId: '001', cmUtils: cm)
} }

1
vars/transportRequestRelease.groovy
View File

@ -43,7 +43,6 @@ def call(parameters = [:]) {
.mixinStageConfig(script.commonPipelineEnvironment, parameters.stageName?:env.STAGE_NAME, stepConfigurationKeys) .mixinStageConfig(script.commonPipelineEnvironment, parameters.stageName?:env.STAGE_NAME, stepConfigurationKeys)
.mixinStepConfig(script.commonPipelineEnvironment, stepConfigurationKeys) .mixinStepConfig(script.commonPipelineEnvironment, stepConfigurationKeys)
.mixin(parameters, parameterKeys) .mixin(parameters, parameterKeys)
.withMandatoryProperty('changeDocumentId')
.withMandatoryProperty('endpoint') .withMandatoryProperty('endpoint')
Map configuration = configHelper.use() Map configuration = configHelper.use()