jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-02-21 19:48:53 +02:00
Code Issues Releases Activity

chore(tests): correct test assertions (#4276)

Browse Source
This commit is contained in:
Christopher Fenner 2023-04-11 23:15:00 +02:00 committed by GitHub
parent fd61f34ec2
commit 99603cdee9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/config/vault_test.go
View File

@ -132,7 +132,7 @@ func TestVaultConfigLoad(t *testing.T) {
stepConfig := StepConfig{Config: map[string]interface{}{}}
stepParams := []StepParameters{stepParam(secretName, "vaultSecret", secretNameOverrideKey, secretName)}
resolveAllVaultReferences(&stepConfig, vaultMock, stepParams)
assert.Equal(t, nil, stepConfig.Config[secretName])
assert.Nil(t, stepConfig.Config[secretName])
vaultMock.AssertNotCalled(t, "GetKvSecret", mock.AnythingOfType("string"))
})
}
@ -154,7 +154,7 @@ func TestVaultSecretFiles(t *testing.T) {
contentByte, err := ioutil.ReadFile(path)
assert.NoError(t, err)
content := string(contentByte)
assert.Equal(t, content, "value1")
assert.Equal(t, "value1", content)
})
os.RemoveAll(VaultSecretFileDirectory)
@ -248,10 +248,10 @@ func TestResolveVaultTestCredentials(t *testing.T) {
resolveVaultTestCredentials(&stepConfig, vaultMock)
// assert
for k, v := range vaultData {
for k, expectedValue := range vaultData {
env := envPrefix + strings.ToUpper(k)
assert.NotEmpty(t, os.Getenv(env))
assert.Equal(t, os.Getenv(env), v)
assert.Equal(t, expectedValue, os.Getenv(env))
}
})
@ -283,13 +283,13 @@ func TestResolveVaultTestCredentials(t *testing.T) {
resolveVaultCredentials(&stepConfig, vaultMock)
// assert
for k, v := range vaultData {
for k, expectedValue := range vaultData {
env := envPrefix + strings.ToUpper(k)
assert.NotEmpty(t, os.Getenv(env))
assert.Equal(t, os.Getenv(env), v)
assert.Equal(t, expectedValue, os.Getenv(env))
standardEnv := standardEnvPrefix + strings.ToUpper(k)
assert.NotEmpty(t, os.Getenv(standardEnv))
assert.Equal(t, os.Getenv(standardEnv), v)
assert.Equal(t, expectedValue, os.Getenv(standardEnv))
}
})
}
@ -317,10 +317,10 @@ func TestResolveVaultTestCredentials(t *testing.T) {
resolveVaultTestCredentials(&stepConfig, vaultMock)
// assert
for k, v := range vaultData {
for k, expectedValue := range vaultData {
env := envPrefix + strings.ToUpper(k)
assert.NotEmpty(t, os.Getenv(env))
assert.Equal(t, os.Getenv(env), v)
assert.Equal(t, expectedValue, os.Getenv(env))
}
})
}