jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-07-17 01:42:43 +02:00
Code Issues Releases Activity

feat (buildSettingsInfo) new common cpe which holds build settings json value (#3272)

Browse Source 
* create build settings for maven

* cases for when mavenBuild may be present

* fixing unit test for mavenBuild to include cpe

* changing position of buildSettngsJson to be called atfter build runs

* package

* extending the struct for other build types

* adding values for mta build settings

* changing config data type

* adding npm build settings

* unit tests

* fix trailing space

* typo correction in yaml

* Vitalii/build settings info (#3277)

* Add buildsettings package

* Improve buildSetting package for mta, npm

* Add unit-test

* Fix

* Fix

Co-authored-by: Vitalii Sidorov <vitalii.sidorov@sap.com>

* review changes

* removing buildTool param

* changing npm script name

* fix npmExecute tests

* including build settings info in npm struct

Co-authored-by: Your Name <you@example.com>
Co-authored-by: kingvvgo <56587879+kingvvgo@users.noreply.github.com>
Co-authored-by: Vitalii Sidorov <vitalii.sidorov@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
This commit is contained in:
Anil Keshav
2021-11-16 15:02:57 +01:00
committed by GitHub
parent 9c700c6f0a
commit a92dd234b1
13 changed files with 404 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
cmd/npmExecuteScripts_test.go
View File

@ -26,6 +26,8 @@ func newNpmMockUtilsBundle() NpmMockUtilsBundle {
}
func TestNpmExecuteScripts(t *testing.T) {
cpe := npmExecuteScriptsCommonPipelineEnvironment{}
t.Run("Call with packagesList", func(t *testing.T) {
config := npmExecuteScriptsOptions{Install: true, RunScripts: []string{"ci-build", "ci-test"}, BuildDescriptorList: []string{"src/package.json"}}
utils := npm.NewNpmMockUtilsBundle()
@ -33,7 +35,7 @@ func TestNpmExecuteScripts(t *testing.T) {
utils.AddFile("src/package.json", []byte("{\"name\": \"Test\" }"))
npmExecutor := npm.NpmExecutorMock{Utils: utils, Config: npm.NpmConfig{Install: config.Install, RunScripts: config.RunScripts, PackagesList: config.BuildDescriptorList}}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
assert.NoError(t, err)
})
@ -45,7 +47,7 @@ func TestNpmExecuteScripts(t *testing.T) {
utils.AddFile("src/package.json", []byte("{\"name\": \"Test\" }"))
npmExecutor := npm.NpmExecutorMock{Utils: utils, Config: npm.NpmConfig{Install: config.Install, RunScripts: config.RunScripts, ExcludeList: config.BuildDescriptorExcludeList}}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
assert.NoError(t, err)
})
@ -57,7 +59,7 @@ func TestNpmExecuteScripts(t *testing.T) {
utils.AddFile("src/package.json", []byte("{\"name\": \"Test\" }"))
npmExecutor := npm.NpmExecutorMock{Utils: utils, Config: npm.NpmConfig{Install: config.Install, RunScripts: config.RunScripts, ScriptOptions: config.ScriptOptions}}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
assert.NoError(t, err)
})
@ -69,7 +71,7 @@ func TestNpmExecuteScripts(t *testing.T) {
utils.AddFile("src/package.json", []byte("{\"name\": \"Test\" }"))
npmExecutor := npm.NpmExecutorMock{Utils: utils, Config: npm.NpmConfig{Install: config.Install, RunScripts: config.RunScripts}}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
assert.NoError(t, err)
})
@ -81,7 +83,7 @@ func TestNpmExecuteScripts(t *testing.T) {
utils.AddFile("src/package.json", []byte("{\"name\": \"Test\" }"))
npmExecutor := npm.NpmExecutorMock{Utils: utils, Config: npm.NpmConfig{Install: config.Install, RunScripts: config.RunScripts}}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
assert.NoError(t, err)
})
@ -93,7 +95,7 @@ func TestNpmExecuteScripts(t *testing.T) {
utils.AddFile("src/package.json", []byte("{\"name\": \"Test\" }"))
npmExecutor := npm.NpmExecutorMock{Utils: utils, Config: npm.NpmConfig{Install: config.Install, RunScripts: config.RunScripts, VirtualFrameBuffer: config.VirtualFrameBuffer}}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
assert.NoError(t, err)
})
@ -109,7 +111,7 @@ func TestNpmExecuteScripts(t *testing.T) {
npmExecutor := npm.Execute{Utils: &utils, Options: options}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
if assert.NoError(t, err) {
if assert.Equal(t, 4, len(utils.execRunner.Calls)) {
@ -130,7 +132,7 @@ func TestNpmExecuteScripts(t *testing.T) {
utils.AddFile("src/package.json", []byte("{\"name\": \"Test\" }"))
npmExecutor := npm.Execute{Utils: &utils, Options: options}
err := runNpmExecuteScripts(&npmExecutor, &config)
err := runNpmExecuteScripts(&npmExecutor, &config, &cpe)
assert.NoError(t, err)
})