jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-02-05 13:25:19 +02:00
Code Issues Releases Activity

Step name is not a string literal anymore

Browse Source 
Having the step name always the same like the file name, which is in turn the class name is
redundant.
This commit is contained in:
Marcus Holl 2018-11-29 09:54:05 +01:00
parent 90765697aa
commit b7468a7ae4
33 changed files with 33 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vars/artifactSetVersion.groovy
View File

@ -8,7 +8,7 @@ import com.sap.piper.versioning.ArtifactVersioning
import groovy.transform.Field
import groovy.text.SimpleTemplateEngine
@Field String STEP_NAME = 'artifactSetVersion'
@Field String STEP_NAME = getClass().getName()
@Field Map CONFIG_KEY_COMPATIBILITY = [gitSshKeyCredentialsId: 'gitCredentialsId']
@Field Set GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/batsExecuteTests.groovy
View File

@ -6,7 +6,7 @@ import com.sap.piper.Utils
import groovy.text.SimpleTemplateEngine
import groovy.transform.Field
@Field String STEP_NAME = 'batsExecuteTests'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/checkChangeInDevelopment.groovy
View File

@ -14,7 +14,7 @@ import com.sap.piper.cm.ChangeManagementException
import static com.sap.piper.cm.StepHelpers.getChangeDocumentId
import static com.sap.piper.cm.StepHelpers.getBackendTypeAndLogInfoIfCMIntegrationDisabled
@Field def STEP_NAME = 'checkChangeInDevelopment'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/checksPublishResults.groovy
View File

@ -8,7 +8,7 @@ import com.sap.piper.Utils
import groovy.transform.Field
@Field def STEP_NAME = 'checksPublishResults'
@Field def STEP_NAME = getClass().getName()
@Field Set TOOLS = [
'aggregation', 'tasks', 'pmd', 'cpd', 'findbugs', 'checkstyle', 'eslint', 'pylint'

2
vars/cloudFoundryDeploy.groovy
View File

@ -6,7 +6,7 @@ import com.sap.piper.CfManifestUtils
import groovy.transform.Field
@Field String STEP_NAME = 'cloudFoundryDeploy'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/dockerExecute.groovy
View File

@ -9,7 +9,7 @@ import com.sap.piper.k8s.ContainerMap
import groovy.transform.Field
@Field def STEP_NAME = 'dockerExecute'
@Field def STEP_NAME = getClass().getName()
@Field def PLUGIN_ID_DOCKER_WORKFLOW = 'docker-workflow'
@Field Set GENERAL_CONFIG_KEYS = ['jenkinsKubernetes']

2
vars/dockerExecuteOnKubernetes.groovy
View File

@ -7,7 +7,7 @@ import com.sap.piper.k8s.SystemEnv
import groovy.transform.Field
import hudson.AbortException
@Field def STEP_NAME = 'dockerExecuteOnKubernetes'
@Field def STEP_NAME = getClass().getName()
@Field def PLUGIN_ID_KUBERNETES = 'kubernetes'
@Field Set GENERAL_CONFIG_KEYS = ['jenkinsKubernetes']
@Field Set PARAMETER_KEYS = [

2
vars/durationMeasure.groovy
View File

@ -1,7 +1,7 @@
import static com.sap.piper.Prerequisites.checkScript
import groovy.transform.Field
@Field STEP_NAME = 'durationMeasure'
@Field STEP_NAME = getClass().getName()
def call(Map parameters = [:], body) {

2
vars/gaugeExecuteTests.groovy
View File

@ -6,7 +6,7 @@ import com.sap.piper.GitUtils
import groovy.text.SimpleTemplateEngine
import groovy.transform.Field
@Field String STEP_NAME = 'gaugeExecuteTests'
@Field String STEP_NAME = getClass().getName()
@Field Set STEP_CONFIG_KEYS = [
'buildTool',
'dockerEnvVars',

2
vars/githubPublishRelease.groovy
View File

@ -5,7 +5,7 @@ import com.sap.piper.ConfigurationHelper
import groovy.transform.Field
@Field String STEP_NAME = 'githubPublishRelease'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = ['githubApiUrl', 'githubTokenCredentialsId', 'githubServerUrl']
@Field Set STEP_CONFIG_KEYS = [
'addClosedIssues',

2
vars/handlePipelineStepErrors.groovy
View File

@ -1,7 +1,7 @@
import groovy.text.SimpleTemplateEngine
import groovy.transform.Field
@Field STEP_NAME = 'handlePipelineStepErrors'
@Field STEP_NAME = getClass().getName()
void call(Map parameters = [:], body) {
def stepParameters = parameters.stepParameters //mandatory

2
vars/healthExecuteCheck.groovy
View File

@ -4,7 +4,7 @@ import com.sap.piper.ConfigurationHelper
import com.sap.piper.Utils
import groovy.transform.Field
@Field String STEP_NAME = 'healthExecuteCheck'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/influxWriteData.groovy
View File

@ -8,7 +8,7 @@ import com.sap.piper.Utils
import groovy.transform.Field
@Field def STEP_NAME = 'influxWriteData'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = []
@Field Set STEP_CONFIG_KEYS = [

2
vars/karmaExecuteTests.groovy
View File

@ -7,7 +7,7 @@ import com.sap.piper.Utils
import groovy.text.SimpleTemplateEngine
import groovy.transform.Field
@Field String STEP_NAME = 'karmaExecuteTests'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = [
/** port mappings required for containers. This will only take effect inside a Kubernetes pod, format [[containerPort: 1111, hostPort: 1111]] */
'containerPortMappings',

2
vars/mailSendNotification.groovy
View File

@ -5,7 +5,7 @@ import com.sap.piper.Utils
import groovy.text.SimpleTemplateEngine
import groovy.transform.Field
@Field String STEP_NAME = 'mailSendNotification'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = ['gitSshKeyCredentialsId']
@Field Set STEP_CONFIG_KEYS = [
'projectName',

2
vars/mavenExecute.groovy
View File

@ -5,7 +5,7 @@ import com.sap.piper.Utils
import groovy.transform.Field
@Field def STEP_NAME = 'mavenExecute'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = []
@Field Set STEP_CONFIG_KEYS = [

2
vars/mtaBuild.groovy
View File

@ -8,7 +8,7 @@ import com.sap.piper.tools.ToolDescriptor
import groovy.transform.Field
@Field def STEP_NAME = 'mtaBuild'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = []
@Field Set STEP_CONFIG_KEYS = [

2
vars/neoDeploy.groovy
View File

@ -7,7 +7,7 @@ import com.sap.piper.tools.ToolDescriptor
import groovy.transform.Field
@Field String STEP_NAME = 'neoDeploy'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = []
@Field Set STEP_CONFIG_KEYS = [
'account',

2
vars/newmanExecute.groovy
View File

@ -6,7 +6,7 @@ import com.sap.piper.Utils
import groovy.text.SimpleTemplateEngine
import groovy.transform.Field
@Field String STEP_NAME = 'newmanExecute'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/pipelineExecute.groovy
View File

@ -3,7 +3,7 @@ import com.sap.piper.Utils
import groovy.transform.Field
@Field STEP_NAME = 'pipelineExecute'
@Field STEP_NAME = getClass().getName()
/**

2
vars/pipelineRestartSteps.groovy
View File

@ -4,7 +4,7 @@ import com.sap.piper.JenkinsUtils
import com.sap.piper.ConfigurationHelper
import groovy.transform.Field
@Field String STEP_NAME = 'pipelineRestartSteps'
@Field String STEP_NAME = getClass().getName()
@Field Set STEP_CONFIG_KEYS = [
'sendMail',
'timeoutInSeconds'

2
vars/pipelineStashFiles.groovy
View File

@ -1,6 +1,6 @@
import groovy.transform.Field
@Field STEP_NAME = 'pipelineStashFiles'
@Field STEP_NAME = getClass().getName()
void call(Map parameters = [:], body) {
handlePipelineStepErrors (stepName: 'pipelineStashFiles', stepParameters: parameters) {

2
vars/pipelineStashFilesAfterBuild.groovy
View File

@ -4,7 +4,7 @@ import com.sap.piper.Utils
import com.sap.piper.ConfigurationHelper
import groovy.transform.Field
@Field String STEP_NAME = 'pipelineStashFilesAfterBuild'
@Field String STEP_NAME = getClass().getName()
@Field Set STEP_CONFIG_KEYS = ['runCheckmarx', 'stashIncludes', 'stashExcludes']
@Field Set PARAMETER_KEYS = STEP_CONFIG_KEYS

2
vars/pipelineStashFilesBeforeBuild.groovy
View File

@ -4,7 +4,7 @@ import com.sap.piper.Utils
import com.sap.piper.ConfigurationHelper
import groovy.transform.Field
@Field String STEP_NAME = 'pipelineStashFilesBeforeBuild'
@Field String STEP_NAME = getClass().getName()
@Field Set STEP_CONFIG_KEYS = ['runOpaTests', 'stashIncludes', 'stashExcludes']
@Field Set PARAMETER_KEYS = STEP_CONFIG_KEYS

2
vars/prepareDefaultValues.groovy
View File

@ -3,7 +3,7 @@ import com.sap.piper.MapUtils
import groovy.transform.Field
@Field STEP_NAME = 'prepareDefaultValues'
@Field STEP_NAME = getClass().getName()
void call(Map parameters = [:]) {
handlePipelineStepErrors (stepName: 'prepareDefaultValues', stepParameters: parameters) {

2
vars/seleniumExecuteTests.groovy
View File

@ -7,7 +7,7 @@ import com.sap.piper.k8s.ContainerMap
import groovy.transform.Field
import groovy.text.SimpleTemplateEngine
@Field String STEP_NAME = 'seleniumExecuteTests'
@Field String STEP_NAME = getClass().getName()
@Field GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/setupCommonPipelineEnvironment.groovy
View File

@ -4,7 +4,7 @@ import com.sap.piper.ConfigurationHelper
import com.sap.piper.Utils
import groovy.transform.Field
@Field String STEP_NAME = 'setupCommonPipelineEnvironment'
@Field String STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = ['collectTelemetryData']
void call(Map parameters = [:]) {

2
vars/snykExecute.groovy
View File

@ -6,7 +6,7 @@ import com.sap.piper.mta.MtaMultiplexer
import groovy.transform.Field
@Field def STEP_NAME = 'snykExecute'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = ['snykCredentialsId']
@Field Set STEP_CONFIG_KEYS = GENERAL_CONFIG_KEYS.plus([

2
vars/testsPublishResults.groovy
View File

@ -11,7 +11,7 @@ import groovy.transform.Field
'junit','jacoco','cobertura','jmeter'
]
@Field def STEP_NAME = 'testsPublishResults'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = TOOLS
@Field Set STEP_CONFIG_KEYS = TOOLS
@Field Set PARAMETER_KEYS = STEP_CONFIG_KEYS

2
vars/toolValidate.groovy
View File

@ -8,7 +8,7 @@ import groovy.transform.Field
import hudson.AbortException
@Field STEP_NAME = 'toolValidate'
@Field STEP_NAME = getClass().getName()
void call(Map parameters = [:]) {

2
vars/transportRequestCreate.groovy
View File

@ -13,7 +13,7 @@ import static com.sap.piper.cm.StepHelpers.getBackendTypeAndLogInfoIfCMIntegrati
import static com.sap.piper.cm.StepHelpers.getChangeDocumentId
import hudson.AbortException
@Field def STEP_NAME = 'transportRequestCreate'
@Field def STEP_NAME = getClass().getName()
@Field GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/transportRequestRelease.groovy
View File

@ -14,7 +14,7 @@ import static com.sap.piper.cm.StepHelpers.getTransportRequestId
import static com.sap.piper.cm.StepHelpers.getChangeDocumentId
import static com.sap.piper.cm.StepHelpers.getBackendTypeAndLogInfoIfCMIntegrationDisabled
@Field def STEP_NAME = 'transportRequestRelease'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = STEP_CONFIG_KEYS

2
vars/transportRequestUploadFile.groovy
View File

@ -14,7 +14,7 @@ import static com.sap.piper.cm.StepHelpers.getTransportRequestId
import static com.sap.piper.cm.StepHelpers.getChangeDocumentId
import static com.sap.piper.cm.StepHelpers.getBackendTypeAndLogInfoIfCMIntegrationDisabled
@Field def STEP_NAME = 'transportRequestUploadFile'
@Field def STEP_NAME = getClass().getName()
@Field Set GENERAL_CONFIG_KEYS = [
'changeManagement'