diff --git a/cmd/sonarExecuteScan.go b/cmd/sonarExecuteScan.go index 90dca24c0..e5d1ea224 100644 --- a/cmd/sonarExecuteScan.go +++ b/cmd/sonarExecuteScan.go @@ -367,15 +367,15 @@ func handlePullRequest(config sonarExecuteScanOptions) error { provider := strings.ToLower(config.PullRequestProvider) if provider == "github" { if len(config.Owner) > 0 && len(config.Repository) > 0 { - sonar.addOption("sonar.pullrequest.github.repository=" + config.Owner + "/" + config.Repository) + //sonar.addOption("sonar.pullrequest.github.repository=" + config.Owner + "/" + config.Repository) } } else { return errors.New("Pull-Request provider '" + provider + "' is not supported!") } - sonar.addOption("sonar.pullrequest.key=" + config.ChangeID) - sonar.addOption("sonar.pullrequest.base=" + config.ChangeTarget) - sonar.addOption("sonar.pullrequest.branch=" + config.ChangeBranch) - sonar.addOption("sonar.pullrequest.provider=" + provider) + //sonar.addOption("sonar.pullrequest.key=" + config.ChangeID) + //sonar.addOption("sonar.pullrequest.base=" + config.ChangeTarget) + //sonar.addOption("sonar.pullrequest.branch=" + config.ChangeBranch) + //sonar.addOption("sonar.pullrequest.provider=" + provider) } } else if len(config.BranchName) > 0 { sonar.addOption("sonar.branch.name=" + config.BranchName) diff --git a/cmd/sonarExecuteScan_test.go b/cmd/sonarExecuteScan_test.go index fe747ce49..982c187a5 100644 --- a/cmd/sonarExecuteScan_test.go +++ b/cmd/sonarExecuteScan_test.go @@ -349,11 +349,11 @@ func TestSonarHandlePullRequest(t *testing.T) { err := handlePullRequest(options) // assert assert.NoError(t, err) - assert.Contains(t, sonar.options, "sonar.pullrequest.key=123") - assert.Contains(t, sonar.options, "sonar.pullrequest.provider=github") - assert.Contains(t, sonar.options, "sonar.pullrequest.base=master") - assert.Contains(t, sonar.options, "sonar.pullrequest.branch=feat/bogus") - assert.Contains(t, sonar.options, "sonar.pullrequest.github.repository=SAP/jenkins-library") + //assert.Contains(t, sonar.options, "sonar.pullrequest.key=123") + //assert.Contains(t, sonar.options, "sonar.pullrequest.provider=github") + //assert.Contains(t, sonar.options, "sonar.pullrequest.base=master") + //assert.Contains(t, sonar.options, "sonar.pullrequest.branch=feat/bogus") + //assert.Contains(t, sonar.options, "sonar.pullrequest.github.repository=SAP/jenkins-library") }) t.Run("unsupported scm provider", func(t *testing.T) { // init