chore(ci): add yamllint action (#2774)

* chore(ci): add yamllint action

* Create .yamllint.yml

* Update verify-yaml.yml

* Update verify-yaml.yml

* Update verify-yaml.yml

* Update verify-yaml.yml

* Update verify-yaml.yml

* correct yaml format

* correct yamllint findings

* disable truthy rule

* add pattern for workflows yamls

* fix c&p issue

.codeclimate.yml

@@ -14,15 +14,15 @@ plugins:
       editorconfig: .editorconfig
     # https://docs.codeclimate.com/docs/advanced-configuration#section-exclude-patterns
     exclude_patterns:
-    - "documentation/**/images/"
-    - "cfg/id_rsa.enc"
-    - "**/testdata/**"
+      - "documentation/**/images/"
+      - "cfg/id_rsa.enc"
+      - "**/testdata/**"
   fixme:
     enabled: true
     config:
       strings:
-      - TODO
-      - FIXME
+        - TODO
+        - FIXME
   gofmt:
     enabled: true
   golint:

.github/workflows/documentation.yaml

@@ -3,76 +3,76 @@ name: Documentation
 on:
   push:
     branches:
-    - master
+      - master
   pull_request:
     branches:
-    - master
+      - master
 
 jobs:
   Build:
     runs-on: ubuntu-latest
     steps:
 
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - uses: actions/setup-java@v1
-      with:
-        java-version: '1.8'
+      - uses: actions/setup-java@v1
+        with:
+          java-version: '1.8'
 
-    - uses: actions/setup-go@v1
-      with:
-        go-version: '1.15.x'
+      - uses: actions/setup-go@v1
+        with:
+          go-version: '1.15.x'
 
-    - name: Install Groovy
-      run: sudo apt-get update && sudo apt-get install groovy -y
+      - name: Install Groovy
+        run: sudo apt-get update && sudo apt-get install groovy -y
 
-    - name: Cache Maven Packages
-      uses: actions/cache@v1
-      with:
-        path: ~/.m2/repository
-        key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
-        restore-keys: |
-          ${{ runner.os }}-maven-
+      - name: Cache Maven Packages
+        uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
 
-    - name: Cache Go Packages
-      uses: actions/cache@v1
-      with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
+      - name: Cache Go Packages
+        uses: actions/cache@v1
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-
 
-    - run: docker pull ppiper/jenkinsfile-runner:latest
+      - run: docker pull ppiper/jenkinsfile-runner:latest
 
-    - name: Generate Groovy Docs
-      env:
-        MAVEN_OPTS: -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
-      run: documentation/bin/createDocu.sh
+      - name: Generate Groovy Docs
+        env:
+          MAVEN_OPTS: -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
+        run: documentation/bin/createDocu.sh
 
-    - name: Generate Golang Docs
-      run: go run pkg/documentation/generator.go --docuDir=documentation/docs/steps/ --customDefaultFile resources/default_pipeline_environment.yml
+      - name: Generate Golang Docs
+        run: go run pkg/documentation/generator.go --docuDir=documentation/docs/steps/ --customDefaultFile resources/default_pipeline_environment.yml
 
-    - run: docker pull squidfunk/mkdocs-material:3.0.4
+      - run: docker pull squidfunk/mkdocs-material:3.0.4
 
-    - name: Build
-      run: |
-        docker run \
-          -u $(id -u):$(id -g) \
-          -v ${GITHUB_WORKSPACE}/documentation:/docs \
-          squidfunk/mkdocs-material:3.0.4 build --clean --strict
+      - name: Build
+        run: |
+          docker run \
+            -u $(id -u):$(id -g) \
+            -v ${GITHUB_WORKSPACE}/documentation:/docs \
+            squidfunk/mkdocs-material:3.0.4 build --clean --strict
 
-    - name: Provide Docs Metadata
-      run: |
-        mkdir -p documentation/docs-gen/misc
-        cp target/docuMetaData.json documentation/docs-gen/misc
+      - name: Provide Docs Metadata
+        run: |
+          mkdir -p documentation/docs-gen/misc
+          cp target/docuMetaData.json documentation/docs-gen/misc
 
-    - name: Deploy
-      if: github.ref == 'refs/heads/master'
-      uses: peaceiris/actions-gh-pages@v3
-      with:
-        github_token: ${{ secrets.GITHUB_TOKEN }}
-        publish_dir: ./documentation/docs-gen
-        user_name: 'github-actions[bot]'
-        user_email: '41898282+github-actions[bot]@users.noreply.github.com'
-        keep_files: true
-        force_orphan: true
+      - name: Deploy
+        if: github.ref == 'refs/heads/master'
+        uses: peaceiris/actions-gh-pages@v3
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          publish_dir: ./documentation/docs-gen
+          user_name: 'github-actions[bot]'
+          user_email: '41898282+github-actions[bot]@users.noreply.github.com'
+          keep_files: true
+          force_orphan: true

.github/workflows/integration-tests-pr.yaml

@@ -80,7 +80,7 @@ jobs:
       - name: build
         env:
           CGO_ENABLED: 0
-      # with `-tags release` we ensure that shared test utilities won't end up in the binary
+        # with `-tags release` we ensure that shared test utilities won't end up in the binary
         run: go build -o piper -tags release
       - name: test
         env:

.github/workflows/integration-tests.yaml

@@ -59,7 +59,7 @@ jobs:
       - name: build
         env:
           CGO_ENABLED: 0
-      # with `-tags release` we ensure that shared test utilities won't end up in the binary
+        # with `-tags release` we ensure that shared test utilities won't end up in the binary
         run: go build -o piper -tags release
       - name: test
         env:

.github/workflows/markdown.yml

@@ -3,10 +3,10 @@ name: "Documentation"
 on:
   push:
     branches:
-    - master
+      - master
   pull_request:
     branches:
-    - master
+      - master
     paths:
       - '**/*.md'
 
@@ -15,8 +15,8 @@ jobs:
     runs-on: ubuntu-latest
     name: 'Format'
     steps:
-    - uses: actions/checkout@v2
-    - name: Markdown Linting
-      uses: nosborn/github-action-markdown-cli@v1.1.1
-      with:
-        files: .
+      - uses: actions/checkout@v2
+      - name: Markdown Linting
+        uses: nosborn/github-action-markdown-cli@v1.1.1
+        with:
+          files: .

.github/workflows/release-go.yml

@@ -4,7 +4,7 @@ on:
   repository_dispatch:
     types: perform-release
   schedule:
-    - cron:  '0 9 * * 1'
+    - cron: '0 9 * * 1'
 
 jobs:
   build:

.github/workflows/verify-go.yml

@@ -3,93 +3,93 @@ name: Go
 on:
   push:
     branches:
-    - master
+      - master
   pull_request:
     branches:
-    - master
+      - master
 
 jobs:
   unit:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-go@v1
-      with:
-        go-version: '1.15.x'
-    - name: Cache Golang Packages
-      uses: actions/cache@v1
-      with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-golang-${{ hashFiles('go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-golang-
-    - name: checkout
-      uses: actions/checkout@v2
-    - name: unit-test
-      uses: paambaati/codeclimate-action@v2.6.0
-      env:
-        CC_TEST_REPORTER_ID: ${{ secrets.CODE_CLIMATE_REPORTER_ID }}
-      with:
-        coverageCommand: go test ./... -coverprofile cover.out
-        coverageLocations: cover.out:gocov
-        # truncate package name from file paths in report
-        prefix: github.com/SAP/jenkins-library/
+      - uses: actions/setup-go@v1
+        with:
+          go-version: '1.15.x'
+      - name: Cache Golang Packages
+        uses: actions/cache@v1
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-golang-${{ hashFiles('go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-golang-
+      - name: checkout
+        uses: actions/checkout@v2
+      - name: unit-test
+        uses: paambaati/codeclimate-action@v2.6.0
+        env:
+          CC_TEST_REPORTER_ID: ${{ secrets.CODE_CLIMATE_REPORTER_ID }}
+        with:
+          coverageCommand: go test ./... -coverprofile cover.out
+          coverageLocations: cover.out:gocov
+          # truncate package name from file paths in report
+          prefix: github.com/SAP/jenkins-library/
   format:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-go@v1
-      with:
-        go-version: '1.15.x'
-    - name: Cache Golang Packages
-      uses: actions/cache@v1
-      with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-golang-format${{ hashFiles('go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-golang-format
-          ${{ runner.os }}-golang-
-    - name: checkout
-      uses: actions/checkout@v2
-    - name: format
-      run: go fmt ./...
-    - name: verify
-      run: git diff --exit-code
+      - uses: actions/setup-go@v1
+        with:
+          go-version: '1.15.x'
+      - name: Cache Golang Packages
+        uses: actions/cache@v1
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-golang-format${{ hashFiles('go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-golang-format
+            ${{ runner.os }}-golang-
+      - name: checkout
+        uses: actions/checkout@v2
+      - name: format
+        run: go fmt ./...
+      - name: verify
+        run: git diff --exit-code
   generate:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-go@v1
-      with:
-        go-version: '1.15.x'
-    - name: Cache Golang Packages
-      uses: actions/cache@v1
-      with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-golang-generate${{ hashFiles('go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-golang-generate
-          ${{ runner.os }}-golang-
-    - name: checkout
-      uses: actions/checkout@v2
-    - name: generate
-      run: go run pkg/generator/step-metadata.go
-    - name: verify
-      run: git diff --exit-code
+      - uses: actions/setup-go@v1
+        with:
+          go-version: '1.15.x'
+      - name: Cache Golang Packages
+        uses: actions/cache@v1
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-golang-generate${{ hashFiles('go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-golang-generate
+            ${{ runner.os }}-golang-
+      - name: checkout
+        uses: actions/checkout@v2
+      - name: generate
+        run: go run pkg/generator/step-metadata.go
+      - name: verify
+        run: git diff --exit-code
   dependencies:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-go@v1
-      with:
-        go-version: '1.15.x'
-    - name: Cache Golang Packages
-      uses: actions/cache@v1
-      with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-golang-dependencies${{ hashFiles('go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-golang-dependencies
-          ${{ runner.os }}-golang-
-    - name: checkout
-      uses: actions/checkout@v2
-    - name: cleanup dependencies
-      run: go mod tidy
-    - name: verify
-      run: git diff --name-only --exit-code
+      - uses: actions/setup-go@v1
+        with:
+          go-version: '1.15.x'
+      - name: Cache Golang Packages
+        uses: actions/cache@v1
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-golang-dependencies${{ hashFiles('go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-golang-dependencies
+            ${{ runner.os }}-golang-
+      - name: checkout
+        uses: actions/checkout@v2
+      - name: cleanup dependencies
+        run: go mod tidy
+      - name: verify
+        run: git diff --name-only --exit-code

.github/workflows/verify-groovy.yml

@@ -1,31 +1,31 @@
 name: Groovy
 
 on:
-   push:
-     branches:
-     - master
-   pull_request:
-     branches:
-     - master
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
 
 jobs:
   unit:
     runs-on: ubuntu-latest
     steps:
 
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - uses: actions/setup-java@v1
-      with:
-        java-version: 1.8
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 1.8
 
-    - name: Cache Maven Packages
-      uses: actions/cache@v1
-      with:
-        path: ~/.m2/repository
-        key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
-        restore-keys: |
-          ${{ runner.os }}-maven-
+      - name: Cache Maven Packages
+        uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
 
-    - name: unit-test
-      run: mvn --batch-mode clean verify -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
+      - name: unit-test
+        run: mvn --batch-mode clean verify -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn

.github/workflows/verify-yaml.yml

@@ -0,0 +1,25 @@
+name: YAML
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@master
+
+      - uses: actions/setup-python@v2
+        with:
+          python-version: 3.8
+
+      - name: Install yamllint
+        run: pip install yamllint
+
+      - name: Lint YAML files
+        run: yamllint -c .yamllint.yml resources/metadata/*.y*ml .pipeline/config.yml .codeclimate.yml .markdownlint.yml .yamllint.yml .github/workflows/*.y*ml

.markdownlint.yml

@@ -1,13 +1,13 @@
 default: true
 
 # ignore
-MD013: false #line-length
-MD024: false #no-duplicate-heading/no-duplicate-header
-MD033: false #no-inline-html
-MD036: false #no-emphasis-as-heading/no-emphasis-as-header
-MD041: false #first-line-heading/first-line-h1
+MD013: false  # line-length
+MD024: false  # no-duplicate-heading/no-duplicate-header
+MD033: false  # no-inline-html
+MD036: false  # no-emphasis-as-heading/no-emphasis-as-header
+MD041: false  # first-line-heading/first-line-h1
 
 # TODO: fix in separate PR
-MD004: false #ul-style
-MD040: false #fenced-code-language
-MD046: false #code-block-style
+MD004: false  # ul-style
+MD040: false  # fenced-code-language
+MD046: false  # code-block-style

.yamllint.yml

@@ -0,0 +1,6 @@
+extends: default
+
+rules:
+  document-start: disable
+  line-length: disable
+  truthy: disable

resources/metadata/abapAddonAssemblyKitCheckCVs.yaml

@@ -1,9 +1,9 @@
 metadata:
-    name: abapAddonAssemblyKitCheckCVs
-    description: This step checks the validity of Software Component Versions.
-    longDescription: |
-      This steps takes a list of Software Component Versions from the addonDescriptorFileName and checks whether they exist or are a valid successor of an existing Software Component Version.
-      It resolves the dotted version string into version, support package level and patch level and writes it to the commonPipelineEnvironment.
+  name: abapAddonAssemblyKitCheckCVs
+  description: This step checks the validity of Software Component Versions.
+  longDescription: |
+    This steps takes a list of Software Component Versions from the addonDescriptorFileName and checks whether they exist or are a valid successor of an existing Software Component Version.
+    It resolves the dotted version string into version, support package level and patch level and writes it to the commonPipelineEnvironment.
 
 spec:
   inputs:

resources/metadata/abapAddonAssemblyKitCheckPV.yaml

@@ -1,9 +1,9 @@
 metadata:
-    name: abapAddonAssemblyKitCheckPV
-    description: This step checks the validity of a Addon Product Version.
-    longDescription: |
-      This step checks whether the Addon Product Version in the addonDescriptorFileName does exist or is a valid successor of an existing Product Version.
-      It resolves the dotted version string into version, support package stack level and patch level and writes it to the commonPipelineEnvironment.
+  name: abapAddonAssemblyKitCheckPV
+  description: This step checks the validity of a Addon Product Version.
+  longDescription: |
+    This step checks whether the Addon Product Version in the addonDescriptorFileName does exist or is a valid successor of an existing Product Version.
+    It resolves the dotted version string into version, support package stack level and patch level and writes it to the commonPipelineEnvironment.
 spec:
   inputs:
     secrets:

resources/metadata/abapAddonAssemblyKitCreateTargetVector.yaml

@@ -1,10 +1,10 @@
 metadata:
-    name: abapAddonAssemblyKitCreateTargetVector
-    description: This step creates a Target Vector for software lifecycle operations
-    longDescription: |
-      This step takes the Product Version and the corresponding list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment.
-      With these it creates a Target Vector, which is necessary for executing software lifecylce operations in ABAP Cloud Platform systems.
-      The Target Vector describes the software state, which shall be reached in the managed ABAP Cloud Platform system.
+  name: abapAddonAssemblyKitCreateTargetVector
+  description: This step creates a Target Vector for software lifecycle operations
+  longDescription: |
+    This step takes the Product Version and the corresponding list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment.
+    With these it creates a Target Vector, which is necessary for executing software lifecylce operations in ABAP Cloud Platform systems.
+    The Target Vector describes the software state, which shall be reached in the managed ABAP Cloud Platform system.
 spec:
   inputs:
     secrets:

resources/metadata/abapAddonAssemblyKitPublishTargetVector.yaml

@@ -1,9 +1,9 @@
 metadata:
-    name: abapAddonAssemblyKitPublishTargetVector
-    description: This step triggers the publication of the Target Vector according to the specified scope.
-    longDescription: |
-      This step reads the Target Vector ID from the addonDescriptor in the commonPipelineEnvironment and triggers the publication of the Target Vector.
-      With targetVectorScope "T" the Target Vector will be published to the test environment and with targetVectorScope "P" it will be published to the productive environment.
+  name: abapAddonAssemblyKitPublishTargetVector
+  description: This step triggers the publication of the Target Vector according to the specified scope.
+  longDescription: |
+    This step reads the Target Vector ID from the addonDescriptor in the commonPipelineEnvironment and triggers the publication of the Target Vector.
+    With targetVectorScope "T" the Target Vector will be published to the test environment and with targetVectorScope "P" it will be published to the productive environment.
 spec:
   inputs:
     secrets:

resources/metadata/abapAddonAssemblyKitRegisterPackages.yaml

@@ -1,11 +1,11 @@
 metadata:
-    name: abapAddonAssemblyKitRegisterPackages
-    description: This step uploads the SAR archives and creates physical Delivery Packages in in the File Content Management System of SAP.
-    longDescription: |
-      This step takes the list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment.
-      For Packages in status "P"lanned it uploads the SAR archive with the data file and metadata XML of the Delivery Packages composed and exported in the Final Assembly system.
-      and creates physical Delivery Packages. The Packages ares saved in the File Content Management System of SAP.
-      The new status "L"ocked is written back to the addonDescriptor in the commonPipelineEnvironment.
+  name: abapAddonAssemblyKitRegisterPackages
+  description: This step uploads the SAR archives and creates physical Delivery Packages in in the File Content Management System of SAP.
+  longDescription: |
+    This step takes the list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment.
+    For Packages in status "P"lanned it uploads the SAR archive with the data file and metadata XML of the Delivery Packages composed and exported in the Final Assembly system.
+    and creates physical Delivery Packages. The Packages ares saved in the File Content Management System of SAP.
+    The new status "L"ocked is written back to the addonDescriptor in the commonPipelineEnvironment.
 
 spec:
   inputs:

resources/metadata/abapAddonAssemblyKitReleasePackages.yaml

@@ -1,10 +1,10 @@
 metadata:
-    name: abapAddonAssemblyKitReleasePackages
-    description: This step releases the physical Delivery Packages
-    longDescription: |
-      This step takes the list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment.
-      The physical Delivery Packages in status “L” are released and uploaded to the "ABAP CP" section in the SAP artifactory object
-      store. The new status "R"eleased is written back to the addonDescriptor in the commonPipelineEnvironment.
+  name: abapAddonAssemblyKitReleasePackages
+  description: This step releases the physical Delivery Packages
+  longDescription: |
+    This step takes the list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment.
+    The physical Delivery Packages in status “L” are released and uploaded to the "ABAP CP" section in the SAP artifactory object
+    store. The new status "R"eleased is written back to the addonDescriptor in the commonPipelineEnvironment.
 spec:
   inputs:
     secrets:

resources/metadata/abapAddonAssemblyKitReserveNextPackages.yaml

@@ -1,13 +1,13 @@
 metadata:
-    name: abapAddonAssemblyKitReserveNextPackages
-    description: This step determines the ABAP delivery packages (name and type), which are needed to deliver Software Component Versions.
-    longDescription: |
-      This step takes the list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment and determines the ABAP delivery packages.
-      If a package does not exist yet in the package registry, it is created there. The response contains detail information for this package and a package status, which determines the next actions:
-      "P": Package was created in the registry; production can be started / continued
-      "R": Package exists and is already released; production is not needed and must be skipped
-      The steps waits until the status "P" or "R" is achieved.
-      The name, type and namespace of each package is written back to the addonDescriptor in the commonPipelineEnvironment.
+  name: abapAddonAssemblyKitReserveNextPackages
+  description: This step determines the ABAP delivery packages (name and type), which are needed to deliver Software Component Versions.
+  longDescription: |
+    This step takes the list of Software Component Versions from the addonDescriptor in the commonPipelineEnvironment and determines the ABAP delivery packages.
+    If a package does not exist yet in the package registry, it is created there. The response contains detail information for this package and a package status, which determines the next actions:
+    "P": Package was created in the registry; production can be started / continued
+    "R": Package exists and is already released; production is not needed and must be skipped
+    The steps waits until the status "P" or "R" is achieved.
+    The name, type and namespace of each package is written back to the addonDescriptor in the commonPipelineEnvironment.
 spec:
   inputs:
     secrets:

resources/metadata/fortify.yaml

@@ -82,9 +82,9 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github
       - name: autoCreate
         type: bool
         description:

resources/metadata/githubbranchprotection.yaml

@@ -98,6 +98,6 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github

resources/metadata/githubcommentissue.yaml

@@ -85,6 +85,6 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github

resources/metadata/githubcreateissue.yaml

@@ -90,6 +90,6 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github

resources/metadata/githubcreatepr.yaml

@@ -119,9 +119,9 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github
       - name: labels
         description: Labels to be added to the pull request.
         scope:

resources/metadata/githubrelease.yaml

@@ -147,9 +147,9 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github
       - name: uploadUrl
         aliases:
           - name: githubUploadUrl

resources/metadata/githubstatus.yaml

@@ -120,6 +120,6 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github

resources/metadata/karma.yaml

@@ -54,7 +54,6 @@ spec:
           - STAGES
           - STEPS
         mandatory: true
-  #outputs:
   containers:
     - name: karma
       image: node:lts-stretch

resources/metadata/kubernetesdeploy.yaml

@@ -243,9 +243,9 @@ spec:
             type: secret
           - type: vaultSecretFile
             paths:
-            - $(vaultPath)/kube-config
-            - $(vaultBasePath)/$(vaultPipelineName)/kube-config
-            - $(vaultBasePath)/GROUP-SECRETS/kube-config
+              - $(vaultPath)/kube-config
+              - $(vaultBasePath)/$(vaultPipelineName)/kube-config
+              - $(vaultBasePath)/GROUP-SECRETS/kube-config
       - name: kubeContext
         type: string
         description: Defines the context to use from the \"kubeconfig\" file.

resources/metadata/sonar.yaml

@@ -43,9 +43,9 @@ spec:
         resourceRef:
           - type: vaultSecret
             paths:
-            - $(vaultPath)/sonar
-            - $(vaultBasePath)/$(vaultPipelineName)/sonar
-            - $(vaultBasePath)/GROUP-SECRETS/sonar
+              - $(vaultPath)/sonar
+              - $(vaultBasePath)/$(vaultPipelineName)/sonar
+              - $(vaultBasePath)/GROUP-SECRETS/sonar
           - name: sonarTokenCredentialsId
             type: secret
         aliases:
@@ -206,9 +206,9 @@ spec:
             type: secret
           - type: vaultSecret
             paths:
-            - $(vaultPath)/github
-            - $(vaultBasePath)/$(vaultPipelineName)/github
-            - $(vaultBasePath)/GROUP-SECRETS/github
+              - $(vaultPath)/github
+              - $(vaultBasePath)/$(vaultPipelineName)/github
+              - $(vaultBasePath)/GROUP-SECRETS/github
       - name: disableInlineComments
         type: bool
         description: "Pull-Request only: Disables the pull-request decoration with inline comments.

resources/metadata/whitesource.yaml

@@ -79,7 +79,7 @@ spec:
           - PARAMETERS
           - STAGES
           - STEPS
-        default: ["unit-tests/pom.xml","integration-tests/pom.xml"]
+        default: ["unit-tests/pom.xml", "integration-tests/pom.xml"]
       - name: buildDescriptorFile
         type: string
         description: "Explicit path to the build descriptor file."
@@ -476,7 +476,7 @@ spec:
               value: docker
     - image: devxci/mbtci:1.1.1
       workingDir: /home/mta
-      env: [ ]
+      env: []
       conditions:
         - conditionRef: strings-equal
           params: