jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-03-03 15:02:35 +02:00
Code Issues Releases Activity

Remove node from test pipeline

Browse Source 
node() is not necessary in the LesFurets unit tests. This is especially
misleading for the pipelineExecute step, as the step itself opens a node
closure when loading a pipeline. If used like this in Jenkins
unnecessary executors will be used.
This commit is contained in:
Oliver Feldmann 2017-12-05 13:33:03 +01:00
parent 4a9ec0b20c
commit f72d93ae2c
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/groovy/PipelineExecuteTest.groovy
View File

@ -76,9 +76,7 @@ class PipelineExecuteTest extends PiperTestBase {
execute() {
node() {
pipelineExecute repoUrl: "https://test.com/myRepo.git"
}
}
@ -92,9 +90,7 @@ class PipelineExecuteTest extends PiperTestBase {
execute() {
node() {
pipelineExecute repoUrl: "https://test.com/anotherRepo.git", branch: 'feature', path: 'path/to/Jenkinsfile', credentialsId: 'abcd1234'
}
}
@ -108,9 +104,7 @@ class PipelineExecuteTest extends PiperTestBase {
execute() {
node() {
pipelineExecute()
}
}