jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-03-05 15:15:44 +02:00
Code Issues Releases Activity

http client: tell us which resource was not found (#2410)

Browse Source 
Up to now we get a message 'Requested resource could not be found' which is not very
helpul during troubleshooting based on the log. With this change we tell the reader
which resource could not be resolved.
This commit is contained in:
Marcus Holl 2020-12-16 08:55:22 +01:00 committed by GitHub
parent d9a1355220
commit f9fc642c0e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/http/http.go
View File

@ -169,7 +169,7 @@ func (c *Client) Upload(data UploadRequestData) (*http.Response, error) {
return response, errors.Wrapf(err, "HTTP %v request to %v failed with error", data.Method, data.URL)
}
return c.handleResponse(response)
return c.handleResponse(response, data.URL)
}
// SendRequest sends an http request with a defined method
@ -186,7 +186,7 @@ func (c *Client) SendRequest(method, url string, body io.Reader, header http.Hea
return response, errors.Wrapf(err, "error calling %v", url)
}
return c.handleResponse(response)
return c.handleResponse(response, url)
}
// SetOptions sets options used for the http client
@ -349,7 +349,7 @@ func (c *Client) createRequest(method, url string, body io.Reader, header *http.
return request, nil
}
func (c *Client) handleResponse(response *http.Response) (*http.Response, error) {
func (c *Client) handleResponse(response *http.Response, url string) (*http.Response, error) {
// 2xx codes do not create an error
if response.StatusCode >= 200 && response.StatusCode < 300 {
return response, nil
@ -361,7 +361,7 @@ func (c *Client) handleResponse(response *http.Response) (*http.Response, error)
case http.StatusForbidden:
c.logger.WithField("HTTP Error", "403 (Forbidden)").Error("Permission issue, please check your user permissions!")
case http.StatusNotFound:
c.logger.WithField("HTTP Error", "404 (Not Found)").Error("Requested resource could not be found")
c.logger.WithField("HTTP Error", "404 (Not Found)").Errorf("Requested resource ('%s') could not be found", url)
case http.StatusInternalServerError:
c.logger.WithField("HTTP Error", "500 (Internal Server Error)").Error("Unknown error occurred.")
}