fix(cfDeploy): correct stashing (#2448)

* remove stash from step yaml

* add stash to groovy code

resources/metadata/cloudFoundryDeploy.yaml

@@ -14,9 +14,6 @@ spec:
       - name: dockerCredentialsId
         description: Jenkins 'Username with password' credentials ID containing user and password to authenticate to the Docker registry.
         type: jenkins
-    resources:
-      - name: deployDescriptor
-        type: stash
     params:
       - name: apiEndpoint
         type: string

vars/cloudFoundryDeploy.groovy

@@ -232,6 +232,7 @@ void call(Map parameters = [:]) {
             .use()
 
         if (config.useGoStep == true) {
+            utils.unstashAll("deployDescriptor")
             List credentials = [
                 [type: 'usernamePassword', id: 'cfCredentialsId', env: ['PIPER_username', 'PIPER_password']],
                 [type: 'usernamePassword', id: 'dockerCredentialsId', env: ['PIPER_dockerUsername', 'PIPER_dockerPassword']]