* added check if git branch name starts with refs/
* added check if branch name from jenkins starts with refs/
* added tests
* hardcoded refs/tags to test
* removed hardcode
---------
Co-authored-by: sumeet patil <sumeet.patil@sap.com>
* Increate command line limits
* Increase new limits only to cf-cli image
* Increase execution environment limits with static values
* Remove unsupported operation
* Increase docker container limits
* Show current environment limits on container start
* Clean up
* Display environment limits only in verbose mode
---------
Co-authored-by: Ivan Nikiforov <ivan.nikiforov@sap.com>
* fix: make quoting null safe
* fix: apply quoting in artifact set version
* fix: add quoting to more shell step
* refactor: use import alias
* fix: further quoting
---------
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
due to missing quoting, command injection was possible via
pipeline configuration.
This is now fixed using a quoting and escaping utility.
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
* chore: switch to new parameter name
Since warnings-ng plugin version 11 the blameDisabled parameter
has been replaced by skipBlames.
To be compatible with Jenkinsfile Runner we put the recordIssues step
into a try/catch, so no exception is thrown and the build fails.
* docs: improve wording
Co-authored-by: Srinikitha Kondreddy <srinikitha.kondreddy@sap.com>
---------
Co-authored-by: Srinikitha Kondreddy <srinikitha.kondreddy@sap.com>
* originHash
* analysis output
* first shot
* add cert logon to piper http client
* allow initial user/pw for certificate logon
* credentials -> parameters
* encode user cert in pem
* key as well
* fix unit tests after merge
* other aakaas steps
* 2nd conn in register packages
* new Piper step abapEnvironmentUpdateAddOnProduct
* modified entity json format and some minor function changes
* modified groovy file for pipelineStageIntTests and addonDescriptor to be mandatory in yaml file
* sync with fork branch ranliii/abap-environment-update-addon-product
* added generated file
* fail the step as long as addon update not successful and unit tests
* added docu for the new step
* tried to fix groovy unit test
* tried to fix groovy unit test 2
* for test
* fixed error
* fixed error 2
* tried to fix groovy unit test error
* added groovy unit test for new Piper step
* tried to fix groovy unit test error
* tried to fix groovy unit test error 2
* changes after first review
* remove .DS_Store
* for test
* revert test relevant changes
* try to fix groovy test error
* try to fix groovy error
* 3rd try to fix groovy test error
* rewrite the failed groovy test
* small changes and try with timeout as well as poll interval
* changes for test
* revert test-related changes
* try to fix errors
* Revert "Merge branch 'master' into abap-environment-update-addon-product"
This reverts commit 1ee0bcd80d, reversing
changes made to 3c4a99dfb0.
* try to fix error
* try to fix error 2
* try to fix error 3
* align go.mod with master branch
* revert go.mod to commit 3c4a99d
* for test
* revert test changes
* new unit test
* Revert "Revert "Merge branch 'master' into abap-environment-update-addon-product""
This reverts commit 363c038001.
* go generate after merging master
---------
Co-authored-by: Jk1484 <35270240+Jk1484@users.noreply.github.com>
Co-authored-by: Ran Li <ran.li01@sap.com>
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
* Add support for volume mounts
* Adatpt unit test to include VolumeMounts
Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>
* Only accept volumeMounts with the name volume
---------
Co-authored-by: Johannes Dillmann <j.dillmann@sap.com>
Co-authored-by: Philipp Stehle <philipp.stehle@sap.com>
Co-authored-by: Anil Keshav <anil.keshav@sap.com>
* Allow cALM service keys
* Fix typo
Co-authored-by: Srinikitha Kondreddy <srinikitha.kondreddy@sap.com>
* fix typo
Co-authored-by: Srinikitha Kondreddy <srinikitha.kondreddy@sap.com>
* Hardcode tms endpoint in calm test case
* Add new serviceKey parameter
* Use new serviceKey parameter
With deprecation warning if old tmsServiceKey parameter is used
* Add unit tests and optimise
* Remove tms from service key log message
* Apply suggestions from code review
Co-authored-by: Artem Bannikov <62880541+artembannikov@users.noreply.github.com>
* Remove unused json fields mapping
* Apply review suggestion
* Apply further review suggestions
* Use new parameter name in groovy
* Generate again
* Fix groovy test
---------
Co-authored-by: Srinikitha Kondreddy <srinikitha.kondreddy@sap.com>
Co-authored-by: Artem Bannikov <62880541+artembannikov@users.noreply.github.com>
* Update default_pipeline_environment.yml
Add filterRegex parameter to jmeter configuration. Set it to an empty string as generated from pipelinesyntax reference in jenkins
* Update testsPublishResults.groovy
Add the filterRegex param to the publishJmeterReport plugin in testPublishResults
* Update documentation to include filterRegex
---------
Co-authored-by: Anil Keshav <anil.keshav@sap.com>
* added logic of fetching golang private packages for whitesource step and detectExecuteScan step
* changed logic of checking by config.PrivateModulesGitToken
* moved func prepareGolangPrivatePackages to golangBuild.go
* fix (gitOpsUpdateDeployment) add CA bundle options to plain clone and commit to trust enterprise github instances (#4602)
* downloading ca cert bundle when added as config
* adding logging statements
* allowing bats test to handle ca cert
* adding info message
* hard coding file names
* including correct http client util bundle
* removing logging message not needed
* adding cert bundle to commit and push
* improving the condition to add ca cert in commit and push
* fixing unit test
* fixing unit test
* fixing unit test
* fixing unit test
* fixing unit test
* feat(kanikoExecute): add dockerfilePath param to multipleImages (#4569)
* add containerDockerfilePath param to multipleImages
* rename ContainerDockerfilePath param to DockerfilePath
* Fix trailing spaces
---------
Co-authored-by: Egor Balakin <egor.balakin@sap.com>
Co-authored-by: Vyacheslav Starostin <32613074+vstarostin@users.noreply.github.com>
* fix(helm): forward sourceRepositoryCredentialsId from groovy to go layer (#4604)
forward sourceRepositoryCredentialsId from groovy to go layer in the same way how this is done for the targetRepositoryCredentialsId
* feat(config): exporting generateConfig function and applying minor changes (#4605)
* exporting generateConfig function and applying minor changes
* Added setConfigOptions to set configOptions variable.
Added possibility to set format output, json or yaml for now.
* Correcting mistake on cmd/getDefaults.go
Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com>
---------
Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com>
* moved func prepareGolangPrivatePackages to pkg/golang
---------
Co-authored-by: Akramdzhon Azamov <MY_NAME@example.com>
Co-authored-by: Andrei Kireev <andrei.kireev@sap.com>
Co-authored-by: Anil Keshav <anil.keshav@sap.com>
Co-authored-by: Egor Balakin <14162703+m1ron0xFF@users.noreply.github.com>
Co-authored-by: Egor Balakin <egor.balakin@sap.com>
Co-authored-by: Vyacheslav Starostin <32613074+vstarostin@users.noreply.github.com>
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
Co-authored-by: Jk1484 <35270240+Jk1484@users.noreply.github.com>
Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com>
* Enable wdi5 autologin
By also providing the basic auth credential on the env vars wdi5_username and wdi5_password we enable the wdi5 autologin feature, where the user does not have to remap the credentials in their wdi5 configuration. See https://ui5-community.github.io/wdi5/#/authentication?id=credentials
* Add documentation
* Add wdi5 parameter
* Add tests
We should use Utils.stash instead of native steps.stash calls (Jenkins)
since important logging is missing.
The default Jenkins stash step does not log any metadata like
stash name, patterns, etc.
* Initial in progress
* compiling but not yet functional
* Missed file
* updated checkmarxone step
* Working up to fetching a project then breaks
* Missed file
* Breaks when retrieving projects+proxy set
* Create project & run scan working, now polling
* Fixed polling
* added back the zipfile remove command
* Fixed polling again
* Generates and downloads PDF report
* Updated and working, prep for refactor
* Added compliance steps
* Cleanup, reporting, added groovy connector
* fixed groovy file
* checkmarxone to checkmarxOne
* checkmarxone to checkmarxOne
* split credentials (id+secret, apikey), renamed pullrequestname to branch, groovy fix
* Fixed filenames & yaml
* missed the metadata_generated.go
* added json to sarif conversion
* fix:type in new checkmarxone package
* fix:type in new checkmarxone package
* removed test logs, added temp error log for creds
* extra debugging to fix crash
* improved auth logging, fixed query parse issue
* fixed bug with group fetch when using oauth user
* CWE can be -1 if not defined, can't be uint
* Query also had CweID
* Disabled predicates-fetch in sarif generation
* Removing leftover info log message
* Better error handling
* fixed default preset configuration
* removing .bat files - sorry
* Cleanup per initial review
* refactoring per Gist, fixed project find, add apps
* small fix - sorry for commit noise while testing
* Fixing issues with incremental scans.
* removing maxretries
* Updated per PR feedback, further changes todo toda
* JSON Report changes and reporting cleanup
* removing .bat (again?)
* adding docs, groovy unit test, linter fixes
* Started adding tests maybe 15% covered
* fix(checkmarxOne): test cases for pkg and reporting
* fix(checkmarxOne):fix formatting
* feat(checkmarxone): update interface with missing method
* feat(checkmarxone):change runStep signature to be able to inject dependency
* feat(checkmarxone): add tests for step (wip)
* Adding a bit more coverage
* feat(checkmarxOne): fix code review
* feat(checkmarxOne): fix code review
* feat(checkmarxOne): fix code review
* feat(checkmarxOne): fix integration test PR
---------
Co-authored-by: thtri <trinhthanhhai@gmail.com>
Co-authored-by: Thanh-Hai Trinh <thanh.hai.trinh@sap.com>