Siarhei Pazdniakou
46bafc40a3
Improve validation of configuration ( #3125 )
...
* Implemented validation for the option possibleValues
* Has been added the option mandatoryIf to config with validation
* Fixed issues found during code review
* improved golang template
* Fixed tests. Added validation for mandatoryIf option
* Fix typo
* Fixed tests
* Validation was refactored. Added options
* Added default value for parameters with possibleValues option
* Validation was moved after the configuration resolution
* Canceled some default values
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-10-01 12:49:05 +02:00
Oliver Nocon
805a8fd88f
feat(config): read config/defaults with authentication ( #2975 )
...
* feat(config):read config/defaults with authentication
This change allows to use defaults and config files from a protected GitHub repository.
The options `--customConfig` and `--defaultConfig` already allowed to provide a link to an uprotected file.
Now, by passing a value in the form `<hostname>:<token>` to parameter `gitHubTokens` (this parameter can be passed multiple times) a token can be provided for dedicated hosts.
This makes it possible to use a link like
`https://api.github.com/repos/SAP/jenkins-library/contents/resources/my-defaults.yml?ref=master `
as reference to a default file or similarly as reference to a configuration file.
* update generation to allow protected config/defaults
* fix CodeClimate issues
* update missing generations
2021-07-08 15:26:07 +02:00
Oliver Nocon
0b48bfcc73
feat: retrieve metadata by stepName - corrected ( #2892 )
...
* refactored getConfig to allow stepName param for metadata fetching
* extended step generator
* go generate
* Update cmd/getConfig.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update cmd/getConfig.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update cmd/getConfig.go
* update generated files
* update golden files to care for generator update
* update and add tests
* update generated files
* Update cmd/getConfig.go
* Update cmd/getConfig.go
* update/fix formatting
* feat: retrieve metadata by stepName - corrected
* update generation
* update condition logic for defaults
* update generation & tests
* support multiple conditions
* update generation
* Add generated
Co-authored-by: Leander Schulz <leander.schulz01@sap.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
Co-authored-by: Sven Merk <s.merk@sap.com>
2021-06-16 08:43:30 +02:00
Oliver Nocon
4250ca8bed
Revert "feat(getConfig): retrieve metadata by stepName ( #2736 )" ( #2891 )
...
This reverts commit ae4a24c594
2021-06-14 10:57:44 +02:00
lndrschlz
ae4a24c594
feat(getConfig): retrieve metadata by stepName ( #2736 )
...
* refactored getConfig to allow stepName param for metadata fetching
* extended step generator
* go generate
* Update cmd/getConfig.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update cmd/getConfig.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update cmd/getConfig.go
* update generated files
* update golden files to care for generator update
* update and add tests
* update generated files
* Update cmd/getConfig.go
* Update cmd/getConfig.go
* update/fix formatting
Co-authored-by: Leander Schulz <leander.schulz01@sap.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: OliverNocon <oliver.nocon@sap.com>
2021-06-14 08:58:41 +02:00
ffeldmann
b88ebdad6c
feat(splunk) Sending telemetry and logging information to Splunk ( #2796 )
...
* Adds inital splunk hook and logCollector
* Adds documentation of the Splunk hook
* Fixes markdown lint issues and removes comment from telemetry.go file
* Fixes markdown lint issues and adds missing generated file
* Markdown linting
* Changes documentation according to review, adds Splunk token automatically during init
* Adds error handling for marshalling hook config
* Markdown lint und correct Splunk token in httpclient
* Registeres Splunk token as secret and adjusts test cases
* Adds missing error handling and removes unnecessary comments
* Creates new function readPipelineEnvironment, adds tests
* Moves MonitoringData struct, edits defaults for json fields
* Adds gitRepository and gitOwner to telemetry information
* Simplifies readCommonPipelineEnvironment function, adds more descriptive errors, adds automated adding of Splunk prefix token
* Adjusts error handling
* Cleaner error logging
2021-05-17 12:14:04 +02:00
Dominik Lendle
b37f356eac
Docu changes for ATC step ( #2792 )
...
* Docu changes
* Linting changes
* Formatting changes
* Remove trailing spaces
* Add extensibility page to index
2021-04-29 15:47:11 +02:00
Dominik Lendle
9168757810
Add Html output to ATC step ( #2761 )
...
* Adding HTML Output
* testing
* testing
* change logging
* change logging
* change logging
* Refactoring
* Add metadata to HTML file
* Change parameter name from sendEmail to generateHTML
* Add sorting and test
* Increasing sorting performance
2021-04-21 20:13:02 +02:00
Daniel Mieg
484d9c2ec1
Increase cf-cli version for abap steps ( #2613 )
2021-02-16 18:03:29 +01:00
Marcus Holl
c53d5241cb
use v6 version of ppiper/cf-cli consistently for all go steps ( #2569 )
2021-02-11 09:31:25 +01:00
lndrschlz
b9bab27833
feat: expose complete step metadata through generated function ( #2329 )
...
* exposing step metadata through generator
* add metadata_generated.go
* fix step go test generation
* metadata fields added to generated files
* added generated files
* removed image placeholder from fortify step
* refactored step meta generation
* go generate
* fixed metadata generator and tests
* added output resource fields/tags to metadata generator
* fix string in metadata_generated
* go generate
* fixed generator
* go generate
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-20 08:13:59 +01:00
Kevin Stiehl
24aafb0b69
add vaultSecretFileReferences ( #2203 )
...
* add vaultSecretFileReferences
* fix test
* fix test
* go generate
* remove code duplication
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-10-26 14:20:04 +01:00
Daniel Mieg
23569b3a5c
ABAP steps docu improvements ( #2182 )
...
* Docu Feedback
* Regenerate
2020-10-15 14:57:33 +02:00
Oliver Nocon
19c1732826
Telemetry: report error category ( #2085 )
2020-09-29 13:49:40 +02:00
Kevin Stiehl
d589038206
Vault AppRole login ( #1971 )
...
* added interpolation package in config
* vault allow paths to hold config references
* allow referencing properties in vaultPaths
* fix small typo
* add approleAuth
* register resolved secrets to logger
* generate steps
* clean up
* add integration test
* add vault to context filter
* reduce Cognitive Complexity & added tests
* Update pkg/config/stepmeta_test.go
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
* go generate
* go generate after merge
* rename VaultAppRole* to VaultRole*
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-09-16 14:50:09 +02:00
Christopher Fenner
8007e4af51
docs: link credentialIDs to parameter ( #1961 )
2020-08-28 15:38:15 +02:00
Dominik Lendle
c2b4ed819b
Atc check extension and more user-friendly displays of results ( #1951 )
2020-08-26 14:09:00 +02:00
Dominik Lendle
509607f69f
Host parameter fix ( #1752 )
2020-07-07 16:19:57 +02:00
MuellerHenrik
de3afe9476
Change parameters/alias for CfServiceKeyName ( #1726 )
...
* Fix alias cfServiceKeyName
* Adapt documentation
* Fix alias use in go files
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-06-30 15:46:07 +02:00
Oliver Nocon
eafe383d54
Add error category parsing to cmd execution ( #1703 )
...
* Add error category parsing to cmd execution
It is now possible to define `ErrorCategoryMapping` as a `map[string][]string` on a `Command`.
The format contains the category as key which has a list of error patterns assigned.
Example:
```
cmd := Command{
ErrorCategoryMapping: map[string][]string
"build": {"build failed"},
"compliance": {"vulnerabilities found", "outdated components found"},
"test": {"some tests failed"},
},
}
```
Setting this map triggers console log parsing when executing a command.
If a match is found the error category is stored and
it will automatically be added to the `errorDetails.json`.
* clean up go.mod
* fix test
* fix test
* Update DEVELOPMENT.md
* fix tests
* address long console content without line breaks
* scan condition update
* fix test
* add missing comment for exported function
* Update pkg/command/command.go
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-06-24 10:04:05 +02:00
Christopher Fenner
c42553593e
fix: remove unused variables from generated step coding ( #1698 )
...
* remove unused parameters from generated code
* update steps
* update steps
* correct golden files
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-06-23 18:05:21 +02:00
Oliver Nocon
7f7d0bce89
Piper steps: Issue SUCCESS message ( #1478 )
...
* Piper steps: Issue SUCCESS message
Log `SUCCESS` message in all steps by default if no error occured
* Update additional generated steps
* Update generated step
2020-05-18 21:52:54 +02:00
Dominik Lendle
4a82eb5aaa
Docu changes to abapEnvironmentRunATCCheck step ( #1557 )
...
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* Changed yaml aliases
* Adapted naming conventions
* Removed error code at the end
* Adapted configuration
* Minor changes
* Minor changes
* Minor changes
* Removed spaces
* Removed docker-related config from groovy file
* Minor changes
* Minor changes
* Removed container config
* Corrected testing function name
* Deleted unnecessary parts
* Changed service deletion message
* Changed service deletion message
* Logging out before throwing error service deletion step fails
* Minor changes
* Minor changes
* Minor changes
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Minor changes
* Minor changes
* Minor changes
* Added newline at end of file
* Added newline at end of file
* Changes for Pull request optimization
* added documentaion
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Added CFDeleteServiceKeys
* Added ServiceKey deletion tests
* added cfServiceKeys flag explanation to documentation
* removed trailing spaces from documentation
* resolving conflicts
* Changed deletion message an variable naming
* Changed tests
* Changed tests
* Changed tests
* Changed tests
* Changed CloudFoundryDeleteServiceOptions to options
* Changed CloudFoundryDeleteServiceOptions to options
* Minor changes
* Minor changes
* Changed variable naming
* Changed error handling
* Changed error handling and logging
* Changed documentation
* Simplified code
* Fixed CodeClimate issues
* Changed from returning err to nil where no errur returned needed
* Add cloudFoundryCreateServiceKey Go Step
* Changed Groovy File
* Changed aliases
* Removed unneccessary parts
* Minor changes
* Minor changes
* Adapted documentation
* Adapted tests
* Adapted Groovy File
* Changed Groovy file
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed Groovy Tests for cfCreateServiceKey
* Minor changes
* Added ATC Check YAML
* Added ATC Check generated files
* Added test class
* Added abapEnvironmentRunATCCheck
* Minor changes
* Minor changes
* Changed groovy
* Minor changes
* Changed groovy
* Changed groovy
* Minor changes
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy
* Getting ATC results
* Changed error message
* changed groovy
* removed trailing spaces
* Added login check
* Minor changes
* Added step to whitelistScriptReference
* Added ATC error message handling
* Added groovy file
* Added step to groovy tests
* corrected metadata file
* Debugging
* Debugging
* Added yaml config parameter for ATC run
* Adapted file location of ATC run config to jenkins specific location
* Implementing universal pipeline logic for finding yaml config regardless of pipeline
* Changed error handling for reading config yaml file
* Changed atcrunconfig alias
* minor changes
* Minor changes
* Minor changes
* Changed back to dynamic file reading
* Minor changes
* filepath changes
* Removing CF Login
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed whitespaces
* Added CF functions unit tests
* Added invalid parameter handling
* Removed package and SC flag
* Minor changes
* Changed tests
* Changed tests
* Changed tests
* Minor changes
* Changed tests
* removed unnecessary logout
* Added documentation
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaces
* Added newline at end of file
* code climate fixes
* code climate fixes
* code climate fixes
* Minor changes
* Minor changes
* Minor changes
* Changed tests
* Test changes
* Splitted Cloud Foundry functions into two classes
* Removed two steps from whtielistScriptReference
* removed atcrunConfig alias
* issue fixes
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaced from docu
* Changed docu
* Go generator run
* Issue fixes
* Remove unnecessary imports
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update whitelistScript
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Adding piperutils for writing xml file
* Persisting ATC Results with piperutils
* Set failonMissingReports to true
* Refactoring for CodeClimate
* Changed result file name
* Changed credentials aliases
* changing secret name
* Removing trailing spaces
* Added secret name and alias to docu
* Docu changes
* CodeClimate fixes
* Minor docu changes
* Correct syntax highlighting
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Daniel Mieg <daniel.mieg@sap.com>
2020-05-18 12:49:52 +02:00
dominiklendle
ac732b3065
Add abapEnvironmentRunATCCheck step ( #1454 )
...
* Minor changes
* Changed groovy file
* Changed generated file
* Changed yaml with container config
* Changed groovy config
* minor changes
* minor changes
* Changed yaml with aliases
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* Changed yaml aliases
* Adapted naming conventions
* Removed error code at the end
* Adapted configuration
* Minor changes
* Minor changes
* Minor changes
* Removed spaces
* Removed docker-related config from groovy file
* Minor changes
* Minor changes
* Removed container config
* Corrected testing function name
* Deleted unnecessary parts
* Changed service deletion message
* Changed service deletion message
* Logging out before throwing error service deletion step fails
* Minor changes
* Minor changes
* Minor changes
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Minor changes
* Minor changes
* Minor changes
* Added newline at end of file
* Added newline at end of file
* Changes for Pull request optimization
* added documentaion
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Added CFDeleteServiceKeys
* Added ServiceKey deletion tests
* added cfServiceKeys flag explanation to documentation
* removed trailing spaces from documentation
* resolving conflicts
* Changed deletion message an variable naming
* Changed tests
* Changed tests
* Changed tests
* Changed tests
* Changed CloudFoundryDeleteServiceOptions to options
* Changed CloudFoundryDeleteServiceOptions to options
* Minor changes
* Minor changes
* Changed variable naming
* Changed error handling
* Changed error handling and logging
* Changed documentation
* Simplified code
* Fixed CodeClimate issues
* Changed from returning err to nil where no errur returned needed
* Add cloudFoundryCreateServiceKey Go Step
* Changed Groovy File
* Changed aliases
* Removed unneccessary parts
* Minor changes
* Minor changes
* Adapted documentation
* Adapted tests
* Adapted Groovy File
* Changed Groovy file
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed Groovy Tests for cfCreateServiceKey
* Minor changes
* Added ATC Check YAML
* Added ATC Check generated files
* Added test class
* Added abapEnvironmentRunATCCheck
* Minor changes
* Minor changes
* Changed groovy
* Minor changes
* Changed groovy
* Changed groovy
* Minor changes
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy
* Getting ATC results
* Changed error message
* changed groovy
* removed trailing spaces
* Added login check
* Minor changes
* Added step to whitelistScriptReference
* Added ATC error message handling
* Added groovy file
* Added step to groovy tests
* corrected metadata file
* Debugging
* Debugging
* Added yaml config parameter for ATC run
* Adapted file location of ATC run config to jenkins specific location
* Implementing universal pipeline logic for finding yaml config regardless of pipeline
* Changed error handling for reading config yaml file
* Changed atcrunconfig alias
* minor changes
* Minor changes
* Minor changes
* Changed back to dynamic file reading
* Minor changes
* filepath changes
* Removing CF Login
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed whitespaces
* Added CF functions unit tests
* Added invalid parameter handling
* Removed package and SC flag
* Minor changes
* Changed tests
* Changed tests
* Changed tests
* Minor changes
* Changed tests
* removed unnecessary logout
* Added documentation
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaces
* Added newline at end of file
* code climate fixes
* code climate fixes
* code climate fixes
* Minor changes
* Minor changes
* Minor changes
* Changed tests
* Test changes
* Splitted Cloud Foundry functions into two classes
* Removed two steps from whtielistScriptReference
* removed atcrunConfig alias
* issue fixes
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaced from docu
* Changed docu
* Go generator run
* Issue fixes
* Remove unnecessary imports
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update whitelistScript
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Adding piperutils for writing xml file
* Persisting ATC Results with piperutils
* Set failonMissingReports to true
* Refactoring for CodeClimate
* Changed result file name
* Changed credentials aliases
* changing secret name
* Removing trailing spaces
* Added secret name and alias to docu
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-05-13 14:51:48 +02:00
