Marcus Holl
b7468a7ae4
Step name is not a string literal anymore
...
Having the step name always the same like the file name, which is in turn the class name is
redundant.
2018-11-29 09:54:05 +01:00
Marcus Holl
0bbbb56002
Do not hand over reference to step itself
...
needs to be the reference as it is available by script
2018-11-09 15:45:23 +01:00
Marcus Holl
420746463e
Remove return value from transportRequestCreate
...
it is contained in the common pipeline environment.
2018-11-06 15:37:11 +01:00
Marcus Holl
b8c0c8e6b3
Cache transport request Id in common pipeline environment
2018-11-06 15:36:39 +01:00
Marcus Holl
88c4b3e967
Merge remote-tracking branch 'github/master' into HEAD
2018-11-05 13:54:10 +01:00
Marcus Holl
3cb958b740
Merge remote-tracking branch 'github/master' into HEAD
2018-11-05 13:30:43 +01:00
Marcus Holl
66332b67af
fix codeclimate issues
2018-11-05 12:51:33 +01:00
Marcus Holl
2e8a9db02c
script = this as fallback instead of map with cpe of current step
...
o The map does not provide access to e.g. sh, echo.
o this has the same cpe as property as it is constructed with the
current map approach.
2018-10-31 12:52:45 +01:00
Marcus Holl
ea23d65594
Merge remote-tracking branch 'github/master' into HEAD
2018-10-30 17:01:19 +01:00
Marcus Holl
11d34c2157
Step called without script: webanalytics
2018-10-30 16:24:48 +01:00
Marcus Holl
c03a75da9f
Ensure script is mandatory parameter
...
... only in case a step uses the script at all.
2018-10-30 16:24:47 +01:00
Marcus Holl
5a75a4cc0c
Adjust naming for config key sets in transportRequestCreate
2018-10-26 10:09:12 +02:00
Marcus Holl
0c3203bb44
Merge remote-tracking branch 'mholl/pr/cts' into HEAD
2018-10-23 15:46:11 +02:00
Marcus Holl
a2393c3f92
merge remote-tracking branch 'github/master' into HEAD
2018-10-23 09:08:59 +02:00
Marcus Holl
b2988c904c
Condence common code wrt backend type in cm steps
2018-10-23 09:02:20 +02:00
Marcus Holl
6653b68c0f
Merge remote-tracking branch 'github/master' into HEAD
2018-10-18 12:54:32 +02:00
Marcus Holl
d4f9171247
erge remote-tracking branch 'github/master' into HEAD
2018-10-18 11:02:09 +02:00
Marcus Holl
f47d540aa3
Introduce dedicated factory method for configuration helper
2018-10-17 11:15:37 +02:00
Marcus Holl
378f34da76
Fix return value for transport request create
...
since now handlePipelineStepError does not return anything anymore we need to put the
corresponding return statement inside createTransportRequest outside the handlinePipelineStepError
closure.
2018-10-11 10:18:39 +02:00
Christopher Fenner
475b977f17
remove unnecessary import
2018-10-09 15:25:46 +02:00
Marcus Holl
54ecc7d755
condence common code for getting change document id
2018-09-28 15:54:20 +02:00
Marcus Holl
2d779233cc
Swich for switching off cm integration
2018-09-28 14:16:19 +02:00
Marcus Holl
ddbb09fa66
transport request create CTS
2018-09-25 09:27:11 +02:00
Marcus Holl
8db2aaf5f0
don't use load step defaults as implicit factory method.
2018-09-07 10:08:16 +02:00
Christopher Fenner
12637119b9
swtich stage/step config loading to correct order ( #250 )
2018-08-15 10:37:34 +02:00
Oliver Nocon
71f7f05427
add telemetry reporting to steps ( #243 )
...
add telemetry to all steps using ConfigurationHelper.
Other steps need to be switched to ConfigurationHelper first.
update docs
2018-08-09 11:35:33 +02:00
Thorsten Willenbacher
9dfc7fcd01
refactor withCredentials to ChangeManagement util class
...
fix tests to match refactoring
2018-08-09 11:03:30 +02:00
Marcus Holl
9b4d55d0d9
switch to nested configuration for change management related steps
2018-07-17 16:41:42 +02:00
Marcus Holl
63b0fd6f67
Merge remote-tracking branch 'github/master' into HEAD
2018-07-13 10:30:29 +02:00
Marcus Holl
3e01caf909
Merge remote-tracking branch 'github/master' into HEAD
2018-07-12 16:26:52 +02:00
Marcus Holl
52052cc99d
Merge pull request #196 from marcusholl/transportRequestCreateChangeDocumentIdFromCommitHistory
...
transportRequestCreate: retrieve changeDocumentId from commit history
2018-07-12 13:14:34 +02:00
Marcus Holl
2310bb4bd5
Do not repeat the same parameter names for different configuration layers
...
changeId is removed from the step parameters since the changeId
is specific to the build. Hence there is no reason for providing
it from the deeper configuration layers.
2018-07-12 12:13:36 +02:00
Marcus Holl
52bb1e842d
Validate required parameters via config helper
...
- In case a parameter is missing we do not thrown and AbortException
anmore, but an IllegalArgumentExcpetion, since that exception is
thrown by the configuration helper. The difference is: AbortExceptions
are contained in the log without stacktrace, other exceptions are
printed with stack trace.
- Exception messages are changed to the standard error message triggered
inside the configuration helper. In case the changeDocumentId is
retrieved also from the commit history we keep an exception message
pointing to that.
- Having references to the parameters is droped. Instead the parameters
are directly used from the configuration map.
- in case of long signatures line breaks are inserted in order to
simplify reading the code.
2018-07-12 09:34:06 +02:00
Marcus Holl
c978d02532
Make use of decent helper function of configuration helper
2018-07-11 11:55:19 +02:00
Marcus Holl
cada0e7882
transportRequestCreate: retrieve changeDocumentId from commit history
2018-07-10 16:41:43 +02:00
Marcus Holl
74b6ac0c8e
Support cmclient_opts in transportRequestCreate
2018-07-09 15:41:13 +02:00
Marcus Holl
44cee0475d
Merge pull request #176 from marcusholl/pr/decoupleTests
...
Pr/decouple tests
2018-07-06 13:09:44 +02:00
Marcus Holl
5a73af4c02
Decouple tests: transport request create
2018-06-29 10:15:20 +02:00
Alejandra Ferreiro Vidal
ab8a1bb837
change credentialsId and endpoint
2018-06-28 16:24:14 +02:00
Marcus Holl
d8dca885bb
Change parameter name 'changeId' to 'changeDocumentId'
...
the official term in SAP-SolutionManager is 'change document'.
The term 'change' as reflected in 'changeId' is ambigous and could also be understand in the
sense of a change in a revision control system.
Choosing appropriate terms for parameters here deceases the amount of documentation
required for explaining what is really denoted by the parameter.
2018-06-28 13:46:00 +02:00
Alejandra Ferreiro Vidal
e34f99deac
add step transportRequestCreate
2018-06-26 10:40:06 +02:00