Eng Zer Jun
0f4e30e9db
test: use T.TempDir to create temporary test directory ( #3721 )
...
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2022-07-12 15:19:12 +02:00
Daniel Mieg
6ff4143b08
Execute checkout & pull when already cloned ( #3850 )
...
* Execute checkout & pull when already cloned
* Revert
* Disallow config overload
* Add custom error handler for clone
* Implement new pull parameters
* Add tests
* Formatting
* Rename Param
* Add comment
* Add docu
* Adapt testst to merge
* Fix Unit Test
2022-06-30 10:43:33 +02:00
Daniel Mieg
8923d1e583
Add Execution Log ( #3863 )
...
* Add Execution Log
* Adapt Tests
* Remove log
2022-06-29 15:50:33 +02:00
Daniel Mieg
3184785c5e
Add parameter to pull step ( #3851 )
...
* Add parameter to pull step
* Add test for config
* Adapt docu
* Update resources/metadata/abapEnvironmentPullGitRepo.yaml
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
* Regenerate
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2022-06-28 11:02:15 +02:00
Daniel Mieg
8ce7577a34
Handle empty http response correctly ( #3805 )
2022-05-25 13:57:13 +02:00
Daniel Mieg
cda6e71ab9
Add ABAP step: createTag ( #3633 )
...
* Cloud Platform -> BTP
* Initial generation of new step
* add flag
* wip
* Fix warnings
* Add command
* Added Tag Decription
* Add status check
* Improve handling
* Improve handling
* Add test for happy path
* Add test reports to gitignore
* Add second test
* Improve createTag
* Add testcase
* Adaptions
* Add test
* Update cmd/abapEnvironmentCreateTag.go
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
* Update cmd/abapEnvironmentCreateTag.go
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
* Adapt error handling
* Improve coding
* Add info
* Disallow repositories and repositoryName at the
same time
* Regenerate
* Adapt to feedback
* Update cmd/abapEnvironmentCreateTag.go
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
* Update cmd/abapEnvironmentCreateTag.go
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2022-05-23 15:15:22 +02:00
Daniel Mieg
a5fcc7517b
Improve logging ( #3788 )
2022-05-19 16:59:37 +02:00
Daniel Bernd
c65e569cdf
add OSL Package Tree on ObjectSet level ( #3762 )
...
Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com>
2022-04-29 16:50:57 +02:00
Daniel Bernd
a3f1234a60
Feature: ATC & AUNIT - ObjectSetLibrary(OSL) usage ( #3755 )
...
* own OSL go File & first changes ATC step
* OSL Integration in AUnit & ATC steps 1
* OSL & Unit Tests
* Unit Tests 1
* OSL - AUnit & ATC usage
* Unittest ATC: packagetree --> package incl. subpackages
* correct spelling
* yaml & generated update
* generated Metadata
Co-authored-by: Daniel Bernd <93763187+danManSAP@users.noreply.github.com>
2022-04-27 13:30:43 +02:00
rosemarieB
9fdaf86856
Enable additional piecelist for assembly ( #3730 )
...
* add useClassicCTS
* add option additionalPiecelist
* Update abapEnvironmentAssemblePackages.go
2022-04-12 16:00:17 +02:00
rosemarieB
1ffe22903e
Enable classic cts ( #3728 )
...
* add useClassicCTS
* debug output and unit test
* unsaved fix
* error logging
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* add general scope and remove logging
* Update bfw.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update package.go
* Update abapEnvironmentAssemblePackages.go
* change scope and add certificates
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2022-04-12 14:39:42 +02:00
Daniel Mieg
f08ff92171
New log entities for Pull & Clone ( #3517 )
...
* WIP
* New Logs
* Improving
* Determine log output based on available entities
* Increase width
* Add line
* Adapt TestPollEntity
* Format
* Fix query
* Adapt tests
* Fix test
* Improve formatting
* Retern early in case of no logs
* Remove duplicate log
2022-02-11 10:16:40 +01:00
Daniel Mieg
8634d8bb12
Add easy mode for AUnit & ATC ( #3389 )
...
* remove mandatory flag from config files
* Enable repo.yml as config
* Adapt to merge
* Refactoring
* Refactoring
* avoid panic
* Add comments
* Add easy mode for atc
* Add tests
* Add test
* Refactor
* Add test for MPS
* Updates
* Rename functions
* Add files to gitignore
* Rename
* Renaming
* Renaming
* Renaming
* Improve error messages
* Update documentation
* Add logging
* Rename
* Extend gitignore
2022-01-12 12:02:27 +01:00
Daniel Mieg
2bb6c21337
ABAP environment: add tag support ( #3376 )
2021-12-20 17:58:58 +01:00
tiloKo
9464b345d0
abapEnvironmentAssemblePackages store file in workspace instead of cpe ( #3232 )
...
* initial refac
* fix unit test, no publish
* fix typo
2021-11-02 11:00:01 +01:00
tiloKo
a0ad624b9a
RobustConfirm ( #3179 )
...
confirm no longer done based on package status but now based on boolean indicator which is set during assembly step.
Thus confirm can now be placed after release packages.
2021-10-28 11:01:16 +02:00
Daniel Mieg
9c76b89fb8
Add telemetry for abapEnvironment steps ( #3016 )
...
* Remove explicit telemetry from signature
* Set log level
* ATC set error category
2021-08-04 17:31:16 +02:00
tiloKo
b04e3140de
SAP BTP ABAP Environment: addon build with supported Languages ( #2689 )
...
* first try
* fix unit test
* remove obsolete attributes
2021-03-15 20:24:43 +01:00
Daniel Mieg
d23e26f87f
Revert "Parallel test processing for abaputils ( #2570 )" ( #2578 )
...
This reverts commit e6086ad4a7
2021-02-04 15:19:42 +01:00
Daniel Mieg
e6086ad4a7
Parallel test processing for abaputils ( #2570 )
...
* add parallel test processing
* Add more t.Parallel
* add parallel to run
* Remove obsolete parallel statements
2021-02-03 17:31:49 +01:00
Dominik Lendle
52722c298a
Bug Fixes for abaputils class + unit tests ( #2525 )
...
* Bug Fixes
* remove command.Command
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2021-01-26 20:23:59 +01:00
Daniel Mieg
a3ff90f632
Fix: Change URL creation for abapEnvironmentCloneGitRepo ( #2452 )
...
* Fix url creation
* Adapt url creation
2020-12-08 09:31:08 +01:00
Marcus Holl
56586cae1b
Remove assert.Error right before assert.EqualError ( #2344 )
...
Is there any benefit from having
```
assert.Error(./.)
assert.EqualError(./.)
```
?
assert.Error ensures that we have an error.
assert.EqualError ensures that we have an error and
moreover it checks for a specific error. Hence
assert.EqualError does all and more what assert.Error
does.
In case there is a benefit from that pattern this PR should not be merged.
In case there is not benefit from that pattern we should abandong that pattern.
2020-11-11 14:14:55 +01:00
Daniel Mieg
7639175def
Add commit to clone and pull ( #2258 )
...
* commit ID for clone
* commit ID for clone
* Remove old default values
* Add commitID to Pull
* Print http response on debug level
* Fix tests
* Adapt tests
* Shorten sleep
* Fix clone tests
* Add ignore commit option
* Adapt tests
* Adapt docu
* Implement feedback
* fix codeclimate issue
2020-11-02 14:17:13 +01:00
MuellerHenrik
a70c0dfaed
Fix for EOF issue ( #2143 )
...
* Fix GetHTTPResponse fuc
* Add time.sleep statement
2020-10-08 11:08:58 +02:00
Daniel Mieg
fe1fc7bd69
Fix EOF http issue ( #2134 )
2020-10-07 08:46:12 +02:00
Dominik Lendle
703f8e921e
Mass enabling for pullGitRepo & checkoutBranch steps ( #2005 )
2020-10-05 14:38:35 +02:00
tiloKo
61dfa9d3d9
AAKaaS check steps to run without prior PV input ( #2091 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
* AAKaaS Checks as First Step
* remove old coding
Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Chris <42861202+bluesbrother84@users.noreply.github.com>
2020-09-30 10:30:53 +02:00
Christopher Fenner
b219fb6514
fix(typo): found by misspell ( #2064 )
...
* fix typos in step yamls
* fix typos in go files
* regenerate step code
* fix typos in md files
* fix typos in groovy files
* fix further typos
2020-09-24 07:41:06 +02:00
tiloKo
2a776ba7eb
AAKaaS:1 check Component Versions ( #2023 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
* AAKaaS CheckCV step
* AAKaaS CheckCV step #2
* AAKaaS CheckCV step #3
* AAKaaS CheckCV step #4
* AAKaaS CheckCV step #5
* AAKaaS CheckCV step #6
* AAKaaS CheckCV step #7
* AAKaaS CheckCV step #8
* AAKaaS CheckCV step #9
* AAKaaS CheckCV step #10
* AAKaaS CheckCV step #11
* AAKaaS CheckCV step #12
* AAKaaS CheckCV step #13
Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-09-17 11:01:19 +02:00
rosemarieB
c6e409dfd9
New step: abapEnvironmentAssemblePackages ( #1884 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-08-27 07:54:03 +02:00
Daniel Mieg
cf4c7fd893
Correction in abaputils ( #1958 )
...
* Fix
* Adapt errors
* Consider unexpected JSON
* defer closing the response body
* Add comments to explain function
* Improve assert statements semantically
* Change comment format due to CodeClimate
* Extract sub function
2020-08-26 16:45:09 +02:00
rosemarieB
67feb87b80
Update abaputils.go ( #1949 )
...
* Update abaputils.go
* changed to versionYAML
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-08-21 16:02:46 +02:00
Daniel Mieg
04b8a5cbd7
Add golang step for abapEnvironmentCloneGitRepo ( #1921 )
...
* Add yaml
* Initial files
* Add inital functions
* Create Test file
* Initial trigger clone function
* Add command
* Adapt manageGitRepositoryUtils
* Enable Repositories yaml
* Add handleHttpError Tests
* Adapt CodeClimate Feedback
* Add tests for error messages
* Adapt error messages and handling
* Adapt gitignore
2020-08-21 14:49:48 +02:00
rosemarieB
0b805bac24
Addon descriptor ( #1925 )
...
* adding ReadAddonDescriptor
* Update abaputils_test.go
* Update abaputils.go
* Update abaputils.go
2020-08-14 10:04:06 +02:00
rosemarieB
0b47748386
Add utils function for addon descriptor ( #1919 )
...
* adding ReadAddonDescriptor
* Update abaputils_test.go
2020-08-13 09:48:40 +02:00
Daniel Mieg
766a233c01
Improve testability of abap steps ( #1876 )
...
* Change to make pollIntervall configurable
* Adapt checkout
2020-08-07 11:09:58 +02:00
MuellerHenrik
164327667c
Add step abapEnvironmentCheckoutBranch ( #1832 )
...
* Add abaputils pkg and go files
* Add ReadServiceKeyAbapEnvironment function
* Fixes
* Add structs for SC, Pull and Branch
* Minor Improvements
* Adapt unit tests to new abaputils pkg
* Fixes
* Add adapted tests
* Fixes
* Fix cloudfoundry test
* Add check for host prefix (HTTPS)
* Fix tests + cleanup
* Fixes
* Fixes
* Fix
* Add mock for abaputils pkg unit tests
* Adapt abaputils comments
* Add abapEnvironmentCheckoutBranch step setup
* Change description of abapEnvCheckoutBranch step
* Add http client code
* Disable code due to missing interace
* Add coding for use of abaputils
* Adapt checkout branch step
* Adapt URL for checkout_branch function import
* Fixes
* Add unit test for missing params case
* Fix for missing mapping of CfSpace
* Fix for missing mapping of CfSpace
* Add working code for a Branch Checkout
* Fix host schema
* Remove LogoutOption param of unit tests and steps
* Fix unit test
* Fix unit test CF ReadServiceKey
* Add abapEnvironmentCheckoutBranch step setup
* Change description of abapEnvCheckoutBranch step
* Add http client code
* Disable code due to missing interace
* Add coding for use of abaputils
* Adapt checkout branch step
* Adapt URL for checkout_branch function import
* Fixes
* Fix for missing mapping of CfSpace
* Add working code for a Branch Checkout
* Adapt changes of abautils pkg
* Add test for polling
* Minor fix
* Fix yaml spacing
* Add longdescription to yaml
* Refactor abaputil methods
* Refactoring
* Refactoring
* Minor fix
* Minor fixeds
* Adapt to new abaputils.AUtilsMock
* Delete obsolete initial checks for params
* Fix manageGitRepoUtils_test.go
* Adjust pollEntity tests
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-08-04 17:52:28 +02:00
Daniel Mieg
bfa601cd47
Improve testability of abap steps ( #1840 )
...
* Test
* Test
* Test abapEnvironmentPullGitRepo step
* Move mock functions
* Add package for mock
* Move mock
2020-07-31 14:43:23 +02:00
MuellerHenrik
e3f914e09d
Add abap utils pkg - ABAP Environment Steps ( #1757 )
...
* Add abaputils pkg and go files
* Add ReadServiceKeyAbapEnvironment function
* Fixes
* Add structs for SC, Pull and Branch
* Minor Improvements
* Adapt unit tests to new abaputils pkg
* Fixes
* Add adapted tests
* Fixes
* Fix cloudfoundry test
* Add check for host prefix (HTTPS)
* Fix tests + cleanup
* Fixes
* Fixes
* Fix
* Add mock for abaputils pkg unit tests
* Adapt abaputils comments
* Add unit test for missing params case
* Fix for missing mapping of CfSpace
* Fix host schema
* Remove LogoutOption param of unit tests and steps
* Fix unit test
* Fix unit test CF ReadServiceKey
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-07-23 10:26:50 +02:00
