tiloKo
218a743fb1
abapEnvironmentAssemblePackages Unit Tests & Error Handling ( #2654 )
...
* Unit Test Assemble Package
* Remove obsolete lines
dust wiping
* climate change
* climate change #2
* climate change #3
* climate change #4
* climate change #5
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2021-03-01 13:51:44 +01:00
lndrschlz
4ca9186f39
fix(uiveri5ExecuteTests): add 'tests' stash to step yaml ( #2641 )
...
* add tests stash to uiveri5 step
* add stash to uiveri5
* extend step generator with input resources
* add step generator test
2021-03-01 13:03:42 +01:00
Sven Merk
d2eb2877e0
fortifyExecuteScan: Functional enhancements ( #2647 )
...
* Improvements
* Formatting
* Fix test
* Update resources/metadata/fortify.yaml
Enhance description
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
* Unify version handling with ws step
* Part 2
* go fmt
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-02-26 13:43:03 +01:00
Roland Stengel
af65dc9076
transport request: consider old label default ( #2655 )
2021-02-25 17:17:41 +01:00
Oliver Nocon
1581f941b1
fix(whitesource): remove parameters from scan call ( #2651 )
...
* fix(whitesource): remove parameters from scan call
parameters are forced into the config thus they don't need to be passed again.
* add proper project to config
2021-02-25 13:16:48 +01:00
Christopher Fenner
80515f3cfb
fix(sonar): remove warnings handling ( #2650 )
2021-02-24 19:21:40 +01:00
Christopher Fenner
cb3fa7c293
feat(sonar): add output of measurements ( #2218 )
...
* add sonarqube measurements
* fetch measurements from API
* add api for fetching issue counts
* add debug outputs
* add further severities
* log number of issues
* report failure
* expose method to send request
* Fixed what was broken.
* add debug output
* wip
* correct opaque property
* push client handling to apiClient.go
* use correct API URL
* correct log outputs
* remove logging
* remove option validation
* extend search options
* restructure
* rename api client file
* simplify client usage
* simplify issue client
* write sonar values to influx
* extract issue service
* reorder imports
* add sonar integration test
* allow unknown fields
* add test case
* add test case
* remove
* fix
* Update http.go
* Apply suggestions from code review
* Update cmd/sonarExecuteScan.go
* rework test cases
* use explicit returns
* add task service
* add waitfortask
* fix typo
* remove fixme
* expose poll interval
* rename test cases
* add test cases
* use newAPIClient method
* use waitForTask
* rename services
* finalize code
* handle error
* move defer
* move types
* add test case
* use http.status...
* add test case
* expose api endpoint names
* extract api client
* adjust test cases
* Update integration-tests-pr.yaml
* Update integration-tests.yaml
* improve require message
* Update integration-tests-pr.yaml
* Update integration-tests-pr.yaml
2021-02-24 15:44:23 +01:00
Marcus Holl
60feb3409f
solman upload go the step ( #2522 )
...
Upload content into a transport request via SOLMAN
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-02-19 13:07:18 +01:00
Mayur Belur Mohan
06afce3005
IntegrationArtifactUpload Command ( #2610 )
...
* IntegrationArtifactUpload Command
2021-02-17 09:59:56 +01:00
Roland Stengel
7cb4e30497
introduce plainOpen in pkg/git ( #2602 )
...
* move transportrequest plainOpen into pkg/git
* artifactPrepareVersion: use plainOpen from git utils
2021-02-15 12:34:19 +01:00
Kevin Stiehl
ffffe8295e
(Vault) Improvements ( #2439 )
...
* vault improvements
* Update cloudFoundryDeploy.yaml
remove double PARAMETERS
* go generate
* fix type & resturcutre paragraph to a list
* remove non-existent secrets
* build trigger
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-02-15 09:48:51 +01:00
Oliver Nocon
2df2771734
fix(whitesourceExecuteScan) correctly handle structured projects ( #2597 )
...
* fix(whitesourceExecuteScan) correctly handle structured projects
report file names of projects which had a structure in the name
like `@test/myProject ` were incorrectly handled
This now prevents that reports are targeted to a sub directory.
Structure is now part of the filename.
* fix CodeClimate finding
2021-02-11 19:39:59 +01:00
Mayur Belur Mohan
f030bc9861
IntegrationArtifactDownload Command ( #2587 )
...
* IntegrationArtifactDownload Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-10 17:08:23 +01:00
Oliver Nocon
d47a17c8fc
feat(whitesource): consolidated reporting and versioning alignment ( #2571 )
...
* update reporting and add todo comments
* enhance reporting, allow directory creation for reports
* properly pass reports
* update templating and increase verbosity of errors
* add todo
* add detail table
* update sorting
* add test and improve error message
* fix error message in test
* extend tests
* enhance tests
* enhance versioning behavior accoring to #1846
* create markdown overview report
* small fix
* fix small issue
* make sure that report directory exists
* align reporting directory with default directory from UA
* add missing comments
* add policy check incl. tests
* enhance logging and tests
* update versioning to allow custom version usage properly
* fix report paths and golang image
* update styling of md
* update test
2021-02-10 16:18:00 +01:00
Christopher Fenner
5184a76453
chore(http): allow to send prepared requests ( #2580 )
...
* Update http.go
* fix c&p issue
* convert URL to string
* Apply suggestions from code review
fix code climate findings
* add test case
2021-02-08 14:26:15 +01:00
Oliver Nocon
f2f5dbecb8
feat(versioning): add re-use function for proper Scan versioning ( #2544 )
...
* feat(versioning): add re-use function for proper Scan versioning
addresses #1846
* add missing comment
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2021-02-08 12:18:36 +01:00
Marcus Holl
0b9dd80008
Provide getters for stdout, stderr on ShellRunner, ExecRunner ( #1787 )
...
* Provide getters for stdout, stderr on ShellRunner, ExecRunner
we need that in order to set the streams back in case we have to scan the command
output ourselvs during some function calls.
2021-02-05 10:54:38 +01:00
Mayur Belur Mohan
538256774a
IntegrationArtifactGetServiceEndpoint Command ( #2582 )
...
* GetIntegrationArtifactServiceEndpoint Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-05 10:35:55 +01:00
Daniel Mieg
d23e26f87f
Revert "Parallel test processing for abaputils ( #2570 )" ( #2578 )
...
This reverts commit e6086ad4a7
2021-02-04 15:19:42 +01:00
Christopher Fenner
9ec282fd0c
test: allow usage of httpmock in tests ( #2576 )
...
* add test case
* add flag for default transport
* Update go.mod
* Update go.sum
* fix spaces
* fix format
* Update http_test.go
* Update http_test.go
* Update http_test.go
* Update http_test.go
* Update http_test.go
2021-02-04 14:58:35 +01:00
Mayur Belur Mohan
426c106765
IntegrationArtifactGetMplStatus Command ( #2558 )
...
* IntegrationArtifactGetMplStatus Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-04 10:50:15 +01:00
Stephan Aßmus
d41d7bfbac
Force WS Project update for mvn plugin ( #2575 )
...
In case of policy violations, the scan is failed and default behavior is to not update the project in the WS system.
See docs at https://whitesource.atlassian.net/wiki/spaces/WD/pages/33914890/Maven+Plugin .
Since this is inconvenient and we also changed the behavior already for NPM, we force the update.
2021-02-04 09:17:48 +01:00
Daniel Mieg
e6086ad4a7
Parallel test processing for abaputils ( #2570 )
...
* add parallel test processing
* Add more t.Parallel
* add parallel to run
* Remove obsolete parallel statements
2021-02-03 17:31:49 +01:00
Oliver Nocon
a104b2a06d
feat(whitesourceExecuteScan): UA for all build tools, e.g. maven & npm ( #2501 )
...
* feat(whitesource): add config helper
this helps to ease & enforce config settings
* fix accidential change of class
* add todos wrt java download
* use existing scanOptions, add option to download jre
* update generation
* fix generation
* allow running UA via go library
* correct image, improve logging
* add removal of downloaded JVM
* update java creation and deletion
* refactor and add log output
* remove obsolete ToDo
* increase test coverage
* increase test coverage
* adding aliases and tests
* make go modules as default
* maven: update behavior of projectNaming
* add Docker capabilities
* correct parameter name
* retrieve Docker coordinates
* docker coordinates only to provide artifact
* add ToDos
* add mta capability
* add aliases, mvn arguments for settings
* clean up groovy part
* update defaults
* add container for pip
* add defaults, add maven specifics, ...
* properly download settings
* maven: check existence of excluded files
* fix reporting
* Update CommonStepsTest.groovy
* update comment
* fix CodeClimate finding
* add tests for pip & fix minor issues
* fix order of pip build descriptors
* update pip container options
* fix pip virtualEnv parameter
* update report permissions
* fix test
* update container options
* add use fileUtils to load properties file
* update parameter description
* adding Docker scanning defaults
* clean up configHelper
* consider also npm tool cache
* add todos
2021-02-03 14:52:48 +01:00
Oliver Nocon
b7754437b3
new step to create a scan summary report ( #2559 )
...
* new step to create a scan summary report
* add flag to collect only failed reports
* add stepName to report
2021-02-02 14:36:40 +01:00
Marcus Holl
f0828ad5e5
Find label in log range ( #2461 )
...
* LogRange provide git log ref1..ref2
This we need for checking inside the commit range
for transportRequestIds and changeDocumentIDs in the
body of the commit message.
2021-02-01 11:54:30 +01:00
Marcus Holl
1f34b135da
LogRange provide git log ref1..ref2 ( #2440 )
...
* LogRange provide git log ref1..ref2
This we need for checking inside the commit range
for transportRequestIds and changeDocumentIDs in the
body of the commit message.
2021-01-29 12:36:15 +01:00
Marcus Holl
c74b99d2c7
Helper for removing duplicates from a string slice ( #2455 )
2021-01-29 10:52:58 +01:00
Mayur Belur Mohan
0ed5cce53a
IntegrationArtifactUpdateConfiguration Command ( #2542 )
...
* IntegrationArtifactUpdateConfiguration Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-29 09:46:47 +01:00
lndrschlz
e60bdb94a6
feat(uiVeri5): golang implmementation for uiVeri5ExecuteTests ( #2394 )
...
* added uiVeri5ExecuteTests step files
* added confPath an regenerated step
* added test for uiVeri5ExecuteTests
* config modified
* added groovy wrapper
* ambiguous method fixed
* uiveri5 wrapper
* removed install command
* fixed defaults
* added testOptions as confPath arg
* test set env
* test npm install local
* changed env settings
* tests regenerated
* go generate
* fix code climate
* overwrite groovy step
* remove groovy wrapper go
* unstash piper bin
* test older node version
* test piperExecuteBin
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* refactored params
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* set testServerUrl as os env for uiveri5
* Update config.yml
* fix naming of testServerUrl param
* wip
* refactored setEnv and fixed tests
* wip
* step param for NPM_CONFIG_PREFIX
* fix runCommand
* refactored step param, regenerate, docu, fix tests
* fix groovy wrapper test
* cleanup
* add to CommonStepsTest field whitelist
* fixed default pipeline environment vars
* fix []string default
* fix metadata.go bug
* added test for docu metadata gen
* fix metadata_test.go in doc gen
* Update metadata_generated.go
* Update metadata_generated.go
* remove npm config prefix param; doc fix
* remove tab
* changed npm config prefix
* removed groovy wrapper test
* removed groovy step defaults
* modify path variable
* modified npm config prefix
* fix error wrapper and tests
* doc update
* add testRepository support
* wip
* fix testRepository param
* wip
* add utils
* init stash content
* wip
* wip
* wip
* add comment for deprecated parameters
* fixed commonStepTest
* fixed commonStepTest
* added error category for testOptions failure
* Update vars/uiVeri5ExecuteTests.groovy
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update vars/uiVeri5ExecuteTests.groovy
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* fix condition
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-28 11:31:24 +01:00
Oliver Nocon
44788f1d3a
fix(config): properly read non-string parameters from environment ( #2549 )
2021-01-28 11:09:43 +01:00
Dominik Lendle
52722c298a
Bug Fixes for abaputils class + unit tests ( #2525 )
...
* Bug Fixes
* remove command.Command
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2021-01-26 20:23:59 +01:00
Marcus Holl
ee7279c8fc
Add helper for finding uninitialized config ( #2534 )
...
Add helper for finding uninitialized config
2021-01-25 12:58:43 +01:00
Oliver Nocon
7bdbed3d65
feat: provide reporting re-use package ( #2536 )
...
* initial version of reporting
* added tests
* Update reporting.go
2021-01-25 11:09:03 +01:00
Mayur Belur Mohan
fe72b295d6
IntegrationArtifactDeploy Command ( #2526 )
...
* UpdateIntegrationArtifactConfiguration Command
* Fixes for codeclimate Check
* CommonStepsTest changes
* CodeReview Changes
* Git Patch
* Git Patch undo
* Code Review Comments
* code review fixes
* improve the error handling
* codeclimate fixes
* remove json parsing
* Error handling changes
* TestCase coverage fixes
* Refactoring Commands
* IntegrationArtifactDeploy Command
* Regenerate metadata_generated
* codereview fixes
* Code Review Fixes
* Code Review Fixes
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-01-22 15:55:50 +01:00
Sven Merk
3e0a2835fd
Improve HTTP test to cover more retry capabilities ( #2528 )
...
* FF disable fulltextsearch
# Conflicts:
# pkg/fortify/fortify.go
# pkg/fortify/fortify_test.go
* Improve test on HTTP retry capabilities
* Improve HTTP retry test
2021-01-22 09:56:56 +01:00
Sven Merk
f149292374
[fix]fortifyExecuteScan: disable fulltextsearch ( #2527 )
...
* FF disable fulltextsearch
# Conflicts:
# pkg/fortify/fortify.go
# pkg/fortify/fortify_test.go
* Completely avoid interacting with fulltextsearch
* Remove also from version lookup
2021-01-21 16:20:46 +01:00
Kevin Stiehl
4a92d1a96a
[Vault] Mixin Vault Parameters for default config ( #2523 )
...
* load vault filters for custom defaults
* add tests
2021-01-20 14:59:47 +01:00
Marcus Holl
9e8e5da394
[refactoring] Make room for other upload action: move package ( #2518 )
...
* [refactoring] Make room for other upload action: move package
In the near future we will have more upload actions, like
SOLMAN, RFC. Here we prepare the package structure for that.
* don't use aliasing
* rename entities (no leading CTS)
2021-01-18 13:20:30 +01:00
Sven Merk
205d59c1ed
Remove obsolete parameter ( #2515 )
...
* Remove obsolete parameter
* Update pkg/fortify/fortify_test.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update fortify_test.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-15 13:55:13 +01:00
Oliver Feldmann
ce9b958410
Document SendRequest error case ( #2507 )
...
* Document error case
* Improve docu text
2021-01-12 15:26:45 +01:00
mayurmohan
f4469c3427
DeployIntegrationArtifact Command ( #2474 )
...
DeployIntegrationArtifact Command
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-12 12:17:42 +01:00
Marcus Holl
6d5a30683b
[refactor] Relocate npmExecutorMock so that it can be used from pkg ( #2472 )
...
From the current location inside "cmd" the npmExecutorMock cannot
be used from any coding inside "pkg".
When we would like to re-use the npm functionality we have also to
provide tests and this requires having a mock.
In order to be able to use the mock from pkg we move the mock from
"cmd" to "pkg" into package "npm".
With the shift from package "cmd" to "npm" a lot of fields in the mock
has been made public.
2021-01-04 12:46:14 +01:00
Marcus Holl
9172fcae04
Don't expose auth header to log ( #2334 )
...
Do not expose auth header to log
2021-01-04 10:06:28 +01:00
lndrschlz
b101106a05
chore: hide warn level if verbose not configured ( #2466 )
2020-12-22 14:33:11 +01:00
Fabian Reh
d8d4f83fb4
Unit test enhancement ( #2471 )
...
* Fixes parallelization in generated code
* Fixes test_code_generated.golden
* generate go code
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-22 09:30:54 +01:00
Marcus Holl
cdb784aaf4
fiori cts upload ( #2390 )
...
fiori cts upload
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2020-12-21 09:05:49 +01:00
Marcus Holl
a84692ea97
Remove strange 'Hello', most likly troubleshoot leftover ( #2475 )
...
in case this is really important it should be logged and not
emitted to stdout.
2020-12-18 11:15:15 +01:00
Marcus Holl
f9fc642c0e
http client: tell us which resource was not found ( #2410 )
...
Up to now we get a message 'Requested resource could not be found' which is not very
helpul during troubleshooting based on the log. With this change we tell the reader
which resource could not be resolved.
2020-12-16 08:55:22 +01:00
Oliver Feldmann
4f6b99cead
Don't allow empty strings as default container parameters ( #2406 )
...
First a bug fix is addressed in which the pull policy could not be configured to false by configuring the general configuration. It could neither be configured via dockerExecute or dockerExecuteOnKubernetes, even though this parameter is docker specific. Only by configuring the specific step where one wants to set the pull policy to false can it be configured.
As the bug stems from zero values being in the context config map, which is also addressed with this PR. That is the second part: Context config parameters are only set if they have a value.
* Don't set pull image if not configured
Otherwise, if the pull policy is not set explicitly for a step, dockerPullImage is set to true. Thus, before this change, it cannot be set in the general, or in dockerExecute or in dockerExecuteOnKubernetes configuration.
* Fix unit tests
* Add pullImage parameter test
* Do not place empty default values in context config
* Use putIfNotEmpty for sidecar container options
* Export common configuration
Keys that are set by both main and sidecar container can be exported
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-12-10 11:28:39 +01:00
