Marcus Holl
2bd15543d0
Introduce interface for manifest ( #1676 )
...
We need the interface in order to inject mocks for tests.
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-06-17 15:19:40 +02:00
Marcus Holl
39d256d33c
Introduce manifest utils for cf ( #1608 )
...
Provide a manifest util for transforming legacy manifests for cf deployments.
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-06-16 17:50:26 +02:00
Marcus Holl
dcd9972516
No parallel test exec for file tests ( #1675 )
2020-06-16 14:50:11 +02:00
Daniel Kurzynski
0222bf83d1
Run npm scripts in virtual frame buffer and extend command.go to run executable asynchronously ( #1669 )
...
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Florian Wilhelm <florian.wilhelm02@sap.com>
2020-06-16 11:42:51 +02:00
Florian Wilhelm
b0329cd2c0
Use absolute path for m2path in mta install ( #1671 )
2020-06-16 09:48:47 +02:00
Daniel Kurzynski
9a30758115
Consider stage config from custom defaults ( #1670 )
2020-06-16 09:06:37 +02:00
Oliver Nocon
6116fe5528
Decouple config reading and retrieval ( #1668 )
...
There are use cases where we need to run `GetStepConfig()` multiple times.
In such cases it is more efficient to load the files once and then resolve the
respective step configuration.
2020-06-15 14:17:59 +02:00
Florian Wilhelm
0fcf1654fe
Install maven artifacts after mta build ( #1641 )
...
Extend mta build step to install maven artefacts after build to allow re-using them in later stages (additional unit or integration tests which might not be running as part of the "build" life-cycle).
2020-06-15 12:46:54 +02:00
Stephan Aßmus
f855658e06
Enhance piperutils.Files and mock.FilesMock ( #1664 )
...
* Flesh out piperutils.Files and mock.FilesMock functionality
* Avoid a lot of code-duplication via embedding
2020-06-15 09:47:33 +02:00
Oliver Nocon
50b2a2d6fc
Update deprecation message ( #1656 )
2020-06-12 15:19:13 +02:00
Stephan Aßmus
d558db9106
Refactor maven.Evaluate() to take options ( #1659 )
...
Co-authored-by: Florian Wilhelm <florian.wilhelm02@sap.com>
2020-06-11 14:02:54 +02:00
Stephan Aßmus
c693c4c7dc
Increase default transport timeout to 3 mins ( #1648 )
2020-06-10 11:14:55 +02:00
Stephan Aßmus
f90a4f9eae
Provide an ExecRunner implementation for running commands in docker ( #1606 )
...
* ExecRunner implementation for executing commands within docker
* Add whole-file example as documentation
2020-06-02 14:24:06 +02:00
Stephan Aßmus
a24a7aad23
Fortify: Using mvn to auto-resolve classpath needs additional params ( #1607 )
...
* also reduce code duplication in token fetching
* concatenate classpaths from multi-maven projects
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-05-29 15:42:35 +02:00
Maximilian Lenkeit
10e5bf98f8
artifactPrepareVersion: remember original artifact version ( #1600 )
...
* Update resources.go
* expose originalArtifactVersion parameter
* re-generate steps
* adjust golden files for generator changes
2020-05-28 10:05:22 +02:00
Stephan Aßmus
e6f5544601
Implement YAMLfile.GetCooridnates() ( #1604 )
2020-05-27 17:20:34 +02:00
Florian Wilhelm
6cbc407af1
Use short warn log level ( #1599 )
...
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-05-27 14:06:09 +02:00
Marcus Holl
d1b717d7a4
suppress error in log message on case there is no error available ( #1594 )
2020-05-27 09:31:41 +02:00
Oliver Nocon
243d196283
Add package for whitesource ( #1577 )
2020-05-26 17:30:45 +02:00
Marcus Holl
2879d98502
Include error in log message ( #1535 )
...
* Include error in the log.
In case the default text formatter is used, the error
will be contained in the log, too.
* Avoid stupid nil token printed in error message
2020-05-26 11:06:52 +02:00
Sven Merk
af2a01c064
Fortify implementation in golang ( #1428 )
2020-05-25 19:48:59 +02:00
Oliver Nocon
7e2ab744a5
mtaBuild - change default for docker image ( #1574 )
...
* mtaBuild - change default for docker image
* fix resolution of container default from step definition
* Properly fix default for container conditions
2020-05-22 09:48:11 +02:00
Florian Wilhelm
bd1e0a1071
Fix npm registry config ( #1564 )
2020-05-20 13:41:23 +02:00
Oliver Nocon
a0ded365c5
Fix container condition handling ( #1562 )
...
* Add additional tests
* Update handling of containers
* Properly consider existing config at root level
* Fix parameter filtering
* Fix tests for adapted filter handling
2020-05-20 10:50:35 +02:00
Oliver Nocon
7f7d0bce89
Piper steps: Issue SUCCESS message ( #1478 )
...
* Piper steps: Issue SUCCESS message
Log `SUCCESS` message in all steps by default if no error occured
* Update additional generated steps
* Update generated step
2020-05-18 21:52:54 +02:00
Stephan Aßmus
5ab4dedcb2
Optionally ignore custom defaults ( #1538 )
...
* Add parameter "--ignoreCustomDefaults"
* Pass to piper customDefaults from config also via --defaultConfig
... and add "--ignoreCustomDefaults".
* Log output when ignoring customDefaults
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-05-14 10:50:58 +02:00
dominiklendle
ac732b3065
Add abapEnvironmentRunATCCheck step ( #1454 )
...
* Minor changes
* Changed groovy file
* Changed generated file
* Changed yaml with container config
* Changed groovy config
* minor changes
* minor changes
* Changed yaml with aliases
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* Changed yaml aliases
* Adapted naming conventions
* Removed error code at the end
* Adapted configuration
* Minor changes
* Minor changes
* Minor changes
* Removed spaces
* Removed docker-related config from groovy file
* Minor changes
* Minor changes
* Removed container config
* Corrected testing function name
* Deleted unnecessary parts
* Changed service deletion message
* Changed service deletion message
* Logging out before throwing error service deletion step fails
* Minor changes
* Minor changes
* Minor changes
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Minor changes
* Minor changes
* Minor changes
* Added newline at end of file
* Added newline at end of file
* Changes for Pull request optimization
* added documentaion
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Added CFDeleteServiceKeys
* Added ServiceKey deletion tests
* added cfServiceKeys flag explanation to documentation
* removed trailing spaces from documentation
* resolving conflicts
* Changed deletion message an variable naming
* Changed tests
* Changed tests
* Changed tests
* Changed tests
* Changed CloudFoundryDeleteServiceOptions to options
* Changed CloudFoundryDeleteServiceOptions to options
* Minor changes
* Minor changes
* Changed variable naming
* Changed error handling
* Changed error handling and logging
* Changed documentation
* Simplified code
* Fixed CodeClimate issues
* Changed from returning err to nil where no errur returned needed
* Add cloudFoundryCreateServiceKey Go Step
* Changed Groovy File
* Changed aliases
* Removed unneccessary parts
* Minor changes
* Minor changes
* Adapted documentation
* Adapted tests
* Adapted Groovy File
* Changed Groovy file
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed Groovy Tests for cfCreateServiceKey
* Minor changes
* Added ATC Check YAML
* Added ATC Check generated files
* Added test class
* Added abapEnvironmentRunATCCheck
* Minor changes
* Minor changes
* Changed groovy
* Minor changes
* Changed groovy
* Changed groovy
* Minor changes
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy
* Getting ATC results
* Changed error message
* changed groovy
* removed trailing spaces
* Added login check
* Minor changes
* Added step to whitelistScriptReference
* Added ATC error message handling
* Added groovy file
* Added step to groovy tests
* corrected metadata file
* Debugging
* Debugging
* Added yaml config parameter for ATC run
* Adapted file location of ATC run config to jenkins specific location
* Implementing universal pipeline logic for finding yaml config regardless of pipeline
* Changed error handling for reading config yaml file
* Changed atcrunconfig alias
* minor changes
* Minor changes
* Minor changes
* Changed back to dynamic file reading
* Minor changes
* filepath changes
* Removing CF Login
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed whitespaces
* Added CF functions unit tests
* Added invalid parameter handling
* Removed package and SC flag
* Minor changes
* Changed tests
* Changed tests
* Changed tests
* Minor changes
* Changed tests
* removed unnecessary logout
* Added documentation
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaces
* Added newline at end of file
* code climate fixes
* code climate fixes
* code climate fixes
* Minor changes
* Minor changes
* Minor changes
* Changed tests
* Test changes
* Splitted Cloud Foundry functions into two classes
* Removed two steps from whtielistScriptReference
* removed atcrunConfig alias
* issue fixes
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaced from docu
* Changed docu
* Go generator run
* Issue fixes
* Remove unnecessary imports
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update whitelistScript
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Adding piperutils for writing xml file
* Persisting ATC Results with piperutils
* Set failonMissingReports to true
* Refactoring for CodeClimate
* Changed result file name
* Changed credentials aliases
* changing secret name
* Removing trailing spaces
* Added secret name and alias to docu
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-05-13 14:51:48 +02:00
lndrschlz
4105f81f71
removed error level from sentry hook ( #1528 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-05-12 22:11:52 +02:00
Stephan Aßmus
80d53dae79
Reading defaults in go: Make sure all io.ReadClosers are closed ( #1529 )
2020-05-12 15:46:47 +02:00
Oliver Nocon
37a6d456fe
Fix generator for custom steps ( #1522 )
2020-05-08 10:41:01 +02:00
Oliver Nocon
f7fdd79fa7
artifactPrepareVersion: additional options ( #1512 )
...
* artifactPrepareVersion: additional options
it is now possible to use
* a Unix timestamp number
* a short commit hash
* Add dedicated Docker versioning scheme
2020-05-06 22:07:27 +02:00
lndrschlz
f5e277de3b
chore(sentry): fix issue of unlabeled events ( #1510 )
2020-05-06 18:22:02 +02:00
Florian Wilhelm
eaf5479e9c
Fix maven parameter handling ( #1493 )
...
Avoid maven error `Unknown lifecycle phase \"-\"` when the value of a define contains `-`.
Don't split and trim maven arguments. Expect they come in as a list, keep them as list.
This is a breaking change compared to the old Groovy implementation which relied on using a shell for calling maven.
As an example, consider this diff:
```diff
- goals: 'org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate',
- defines: "-Dexpression=$pomPathExpression -DforceStdout -q",
+ goals: ['org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate'],
+ defines: ["-Dexpression=$pomPathExpression", "-DforceStdout", "-q"],
```
2020-05-06 17:43:32 +02:00
Florian Wilhelm
190ff83caa
Handle case when stepname is not set for logging ( #1517 )
2020-05-06 16:27:34 +02:00
Stephan Aßmus
082b249cc0
Fix logrus buffer issue ( #1511 )
2020-05-06 13:35:40 +02:00
Florian Wilhelm
0a196af04c
Allow configuration of log format, change default to fixed-width ( #1432 )
2020-05-06 12:17:56 +02:00
Christopher Fenner
8874ace564
fix(protecode): handle api request issues ( #1508 )
...
* fix(protecode): handle api request issues
* Update pkg/protecode/protecode.go
2020-05-05 16:26:41 +02:00
lndrschlz
39e30ff1b4
Added hook configuration; added sentry hook and tests ( #1497 )
...
* Added hook configuration; added sentry hook and tests
* steps generated by step framework
* added comments and renamed correlationID
* formatted comment on NewSentryHook method
* fix generator step tests
2020-05-05 08:36:24 +02:00
Christopher Fenner
6eb8dc8191
docs: add possible value for bool parameters ( #1486 )
2020-04-30 06:39:48 +02:00
Christopher Fenner
3a4d4b2de7
docs: add general config parameters to GO docs ( #1471 )
...
* extract StepConfiguration generation to separate file
* add general options to parameter and config table
* fix test case
* remove telemetry flag from docs
* Revert "extract StepConfiguration generation to separate file"
This reverts commit df80dab8cd
2020-04-29 14:40:11 +02:00
Oliver Nocon
a395cd75be
Docker versioning: fall back to custom ( #1484 )
...
* Docker versioning: fall back to custom
* Update test and fix issue
* pass proper error message
* Fix test
2020-04-29 13:42:14 +02:00
Stephan Aßmus
dd94ba7213
TransportTimeout now refers to any state ( #1467 )
...
The TransportTimeout value is now applied to the "response header
timeout" and "expect continue timeout" as is. Previously there
was a hard limit of 10 seconds and 1 second respectively (originating
from the article I based the previous PR on). While this doesn't
allow for fine-grained control, it is reasonable to apply the meaning
of "transport timeout" to any state or phase of a HTTP connection.
This change should solve the needs of some Piper clients to configure
very long response header timeouts of 5 minutes and above.
2020-04-28 21:48:00 +02:00
Florian Wilhelm
7bbdaf783c
Dont dedup mvn flags ( #1479 )
2020-04-28 20:38:36 +02:00
Oliver Nocon
43947e6ef5
Pass golang error details to Jenkins pipeline ( #1443 )
...
Do not exit with os.Exit(1) but using log.Entry().Fatal() instead
* Golang: forward error details
* extend groovy wrapper to provide proper error message
* create closure for error handling
2020-04-28 07:42:02 +02:00
Christopher Fenner
8455306a5e
docs: add code blocks to parameters table ( #1460 )
...
* add code blocks
* set parameters name in code block
* change test cases
* set parameters name in code block
* add step configuratio caption
* remove details caption
* add code block for docker settings
* add code block for stash content
* add code block for defaults
* add code block for sidecar image & name
* correct test cases
* add code block for docker
* correct test cases
2020-04-27 12:16:41 +02:00
Christopher Fenner
1660f4df48
docs: remove dangling whitespaces ( #1459 )
...
* omit <nil> in parameter table
* remove additional whitespaces
* add newline
* remove whitespaces
* adjust test cases
* fix whitespaces
2020-04-24 21:48:28 +02:00
Oliver Nocon
a728416e12
artifactPrepareVersion: define versioning scheme ( #1457 )
2020-04-24 20:52:16 +02:00
Christopher Fenner
96439972e2
docs: show possible values in step documentation ( #1453 )
...
* add possibleValues to model
* include possible values into docs
2020-04-24 14:13:02 +02:00
Christopher Fenner
2100632b54
docs: omit <nil> in parameter table ( #1450 )
...
* omit <nil> in parameter table
* adjust test case
2020-04-24 11:21:33 +02:00
Daniel Kurzynski
974327d16e
Use mavenExecute from go ( #1388 )
...
Also establish mavenExecute() via new JenkinsMavenExecuteRule in Groovy Unit Tests.
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-04-24 10:41:49 +02:00
