Christopher Fenner
2d93e5d4df
fix(cpe) readToDisk failes with content from writeToDisk ( #2629 )
...
* branch for debugging
* Add json fix for booleans
* remove debug output
* handle boolean in cpe
* handle various types in json
* fix variable
Co-authored-by: OliverNocon <oliver.nocon@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-02-19 11:34:30 +01:00
Marcus Holl
3df4542271
move additional hints into markdown file ( #2599 )
...
These hints are up to now provided as javadoc like comments
at the call method for cloudFoundryDeploy step. At that level
they are not taken into account by the go generator.
Is is not a suitable approach to include this kind of markdown
docu into the long description of the metadata file since this
long description is (also) used by the piper help command when
invoking piper cloudFoundyDeploy --help. At that point in time
markdown like text does not make sense.
2021-02-19 08:44:51 +01:00
Mayur Belur Mohan
06afce3005
IntegrationArtifactUpload Command ( #2610 )
...
* IntegrationArtifactUpload Command
2021-02-17 09:59:56 +01:00
Kevin Stiehl
ffffe8295e
(Vault) Improvements ( #2439 )
...
* vault improvements
* Update cloudFoundryDeploy.yaml
remove double PARAMETERS
* go generate
* fix type & resturcutre paragraph to a list
* remove non-existent secrets
* build trigger
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-02-15 09:48:51 +01:00
Oliver Feldmann
1b032b5c82
Skip checkout flag ( #2594 )
...
* Skip checkout flag
Defaults to null==false
We need the option to provide an scmInfo object by the user
* Check skipCheckout is Boolean
* Require scmInfo map in case checkout is skipped
2021-02-11 16:21:57 +01:00
Marcus Holl
c53d5241cb
use v6 version of ppiper/cf-cli consistently for all go steps ( #2569 )
2021-02-11 09:31:25 +01:00
Mayur Belur Mohan
f030bc9861
IntegrationArtifactDownload Command ( #2587 )
...
* IntegrationArtifactDownload Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-10 17:08:23 +01:00
Christian Luttenberger
e9a93ed384
Adding new step for abap Enviroment Assembly Confirm ( #2586 )
...
* Adding new abap Assembly Confirm
* Update abapEnvironmentAssembleConfirm.go
* Add generated objects
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2021-02-10 11:33:10 +01:00
Mayur Belur Mohan
538256774a
IntegrationArtifactGetServiceEndpoint Command ( #2582 )
...
* GetIntegrationArtifactServiceEndpoint Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-05 10:35:55 +01:00
Mayur Belur Mohan
426c106765
IntegrationArtifactGetMplStatus Command ( #2558 )
...
* IntegrationArtifactGetMplStatus Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-04 10:50:15 +01:00
Srinikitha Kondreddy
1b16de0734
Remove handle pipeline step errors from groovy glue code ( #2573 )
2021-02-04 08:54:00 +01:00
Oliver Nocon
a104b2a06d
feat(whitesourceExecuteScan): UA for all build tools, e.g. maven & npm ( #2501 )
...
* feat(whitesource): add config helper
this helps to ease & enforce config settings
* fix accidential change of class
* add todos wrt java download
* use existing scanOptions, add option to download jre
* update generation
* fix generation
* allow running UA via go library
* correct image, improve logging
* add removal of downloaded JVM
* update java creation and deletion
* refactor and add log output
* remove obsolete ToDo
* increase test coverage
* increase test coverage
* adding aliases and tests
* make go modules as default
* maven: update behavior of projectNaming
* add Docker capabilities
* correct parameter name
* retrieve Docker coordinates
* docker coordinates only to provide artifact
* add ToDos
* add mta capability
* add aliases, mvn arguments for settings
* clean up groovy part
* update defaults
* add container for pip
* add defaults, add maven specifics, ...
* properly download settings
* maven: check existence of excluded files
* fix reporting
* Update CommonStepsTest.groovy
* update comment
* fix CodeClimate finding
* add tests for pip & fix minor issues
* fix order of pip build descriptors
* update pip container options
* fix pip virtualEnv parameter
* update report permissions
* fix test
* update container options
* add use fileUtils to load properties file
* update parameter description
* adding Docker scanning defaults
* clean up configHelper
* consider also npm tool cache
* add todos
2021-02-03 14:52:48 +01:00
Mayur Belur Mohan
0ed5cce53a
IntegrationArtifactUpdateConfiguration Command ( #2542 )
...
* IntegrationArtifactUpdateConfiguration Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-29 09:46:47 +01:00
lndrschlz
e60bdb94a6
feat(uiVeri5): golang implmementation for uiVeri5ExecuteTests ( #2394 )
...
* added uiVeri5ExecuteTests step files
* added confPath an regenerated step
* added test for uiVeri5ExecuteTests
* config modified
* added groovy wrapper
* ambiguous method fixed
* uiveri5 wrapper
* removed install command
* fixed defaults
* added testOptions as confPath arg
* test set env
* test npm install local
* changed env settings
* tests regenerated
* go generate
* fix code climate
* overwrite groovy step
* remove groovy wrapper go
* unstash piper bin
* test older node version
* test piperExecuteBin
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* refactored params
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* set testServerUrl as os env for uiveri5
* Update config.yml
* fix naming of testServerUrl param
* wip
* refactored setEnv and fixed tests
* wip
* step param for NPM_CONFIG_PREFIX
* fix runCommand
* refactored step param, regenerate, docu, fix tests
* fix groovy wrapper test
* cleanup
* add to CommonStepsTest field whitelist
* fixed default pipeline environment vars
* fix []string default
* fix metadata.go bug
* added test for docu metadata gen
* fix metadata_test.go in doc gen
* Update metadata_generated.go
* Update metadata_generated.go
* remove npm config prefix param; doc fix
* remove tab
* changed npm config prefix
* removed groovy wrapper test
* removed groovy step defaults
* modify path variable
* modified npm config prefix
* fix error wrapper and tests
* doc update
* add testRepository support
* wip
* fix testRepository param
* wip
* add utils
* init stash content
* wip
* wip
* wip
* add comment for deprecated parameters
* fixed commonStepTest
* fixed commonStepTest
* added error category for testOptions failure
* Update vars/uiVeri5ExecuteTests.groovy
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update vars/uiVeri5ExecuteTests.groovy
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* fix condition
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-28 11:31:24 +01:00
Srinikitha Kondreddy
efe3ab36f8
Support for secretfile type neo credential for deployment ( #2537 )
...
* Use Oauth bearer token credentials to deploy to neo
* Add test case
* Add test file
* Fix code climate issues
* Add code review changes
2021-01-26 09:29:44 +01:00
Mayur Belur Mohan
fe72b295d6
IntegrationArtifactDeploy Command ( #2526 )
...
* UpdateIntegrationArtifactConfiguration Command
* Fixes for codeclimate Check
* CommonStepsTest changes
* CodeReview Changes
* Git Patch
* Git Patch undo
* Code Review Comments
* code review fixes
* improve the error handling
* codeclimate fixes
* remove json parsing
* Error handling changes
* TestCase coverage fixes
* Refactoring Commands
* IntegrationArtifactDeploy Command
* Regenerate metadata_generated
* codereview fixes
* Code Review Fixes
* Code Review Fixes
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-01-22 15:55:50 +01:00
Oliver Feldmann
741b49140e
Move pull image parameters to general section ( #2478 )
...
* Move pull image parameters to general section
* Allow no nesting override
* Test dockerPullImage can be set to true
As the default is false, we need to make sure it can still be set to true.
2021-01-13 10:48:48 +01:00
Marcus Holl
84bb028ffd
fix typo for transportRequestUploadFile ( #2499 )
2021-01-12 15:15:30 +01:00
mayurmohan
f4469c3427
DeployIntegrationArtifact Command ( #2474 )
...
DeployIntegrationArtifact Command
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-12 12:17:42 +01:00
Christopher Fenner
6dd006f0a0
fix(cpe): fix issue in custom type determination ( #2505 )
2021-01-12 11:36:25 +01:00
Marcus Holl
93330d5ed2
Prepare credentials for forwarding as environment variables to piper go ( #2432 )
...
Prepare credentials for forwarding as environment variables to piper go
2021-01-12 09:17:34 +01:00
Christopher Fenner
834dd1a1de
fix(CPE): correct handling of complex (json) data in writeToDisk ( #2500 )
...
* correct handling of JSON data
* fix typo
* Update commonPipelineEnvironment.groovy
2021-01-11 12:58:12 +01:00
Oliver Nocon
006aaab50d
fix(handlePipelineStepError): correct handling of failed steps ( #2498 )
...
* WIP: debug incorrect error message
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update commonPipelineEnvironment.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update commonPipelineEnvironment.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update vars/piperExecuteBin.groovy
* Update vars/handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Apply suggestions from code review
* correct test case
* change test case
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Christopher Fenner <Christopher.Fenner@sap.com>
2021-01-11 10:49:33 +01:00
Oliver Nocon
5f5450449e
fix(piperExecuteBin): define variable ( #2497 )
2021-01-07 12:24:48 +01:00
Hans Schulz
e9a7590c5c
Add cfTrace parameter ( #2248 )
...
* add cfTrace parameter
* make cfTrace toggle creation of log file
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-21 17:46:52 +01:00
Oliver Nocon
7de42230e0
add step to create a GitHub issue ( #2481 )
...
* add step to create a GirHub issue
* add groovy library step
* Update githubcreateissue.yaml
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 17:13:16 +01:00
Oliver Nocon
cf7ca8f791
add step to create a GitHub comment ( #2479 )
...
* add step to create a GitHub comment
* add docs
* mandatory parameters
* add command
* Update githubCommentIssue.go
* add groovy library step
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 16:21:07 +01:00
Srinikitha Kondreddy
d9a1355220
Fix typo ( #2436 )
2020-12-14 15:02:49 +01:00
Christopher Fenner
9cd3ee5758
fix(checks+tests): fail pipeline if plugins fail the build ( #2463 )
...
* fix false negative
* add comment
* add default
2020-12-11 14:49:36 +01:00
Oliver Feldmann
96ebaa1a20
chore(docs): Fix switheroo of deployType and deployTool typo ( #2464 )
...
* Fix switcheroo
* Add commas
2020-12-11 13:11:36 +01:00
Daniel Mieg
44e7766e8f
Add stage docu ( #2460 )
...
* Add stage docu
* Add table to configuration.md
* Add comment to clone repo stage
* Fix indentation errors
* Docu: commitID
* fix links
2020-12-10 14:28:03 +01:00
Christopher Fenner
6970b57468
fix(cfDeploy): correct stash for go step ( #2456 )
2020-12-09 14:31:07 +01:00
Marcus Holl
17bdbe2ef4
piperExecuteBin: provide credentials directly without indirection into config ( #2437 )
...
`piperExecuteBin` is called with a credentials list. Each list entry is a map consisting of
* the type of the credential (e.g. usernamePassword, token)
* the identifier which is used for resolving the credential.
* a list of environment variables which holds the resolved credentials.
Inside `piperExecuteBin` the id was resolved against the config and the result was used for resolving the credentials against the jenkins-credentials-plugin.
With this change here we introduce another key for the map mentioned above:
* resolveCredentialsId
When this key is provided with value `false` we do not resolve the credentials-id from the config. In that case the id is directly used for resolving the credential again the jenkins-credentials-plugin.
2020-12-07 08:54:49 +01:00
Christopher Fenner
fac4af231f
fix(cfDeploy): correct stashing ( #2448 )
...
* remove stash from step yaml
* add stash to groovy code
2020-12-05 13:35:16 +01:00
Daniel Mieg
b001474edd
Remove input statement ( #2419 )
...
* Remove input statement
* adaptDocu
2020-12-04 10:03:41 +01:00
Christopher Fenner
e1d140e513
fix(checksPublishResults): typo in tool it key ( #2443 )
2020-12-03 14:16:04 +01:00
Stephan Aßmus
e48b5c588e
Include configFile in pipelineConfigAndTests stash ( #2424 )
2020-12-01 12:04:27 +01:00
Thilaknath
104435c8dd
Show user friendly error messages for pipeline restart step. ( #2409 )
...
* Add message parameter to pipelineRestart to make error messages user friendly
* Update the parameter to the correct name
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-26 08:03:22 +01:00
Christopher Fenner
eff1933a61
refactor(checks): use warnings-ng plugin ( #2398 )
...
* use recordIssues
* fix c&p issue
* simplify code
* fix
* add quality gates
* change qgates to TOTAL_HIGH
* remove pattern for tasks
* use TOTAL_ERROR for checkstyle
* fix indent
* use deprecated threshold parameters
* debug messages
* transform legacy qgates
* fix
* adjust test cases
* correct qgates
* correct legacy thresholds
* fix typo
* remove deprecated defaults
* add test case
* log use tool
* add notification
* remove deprecated defaults
* remove deprecated parameter
* adjust legacy threshold message
* add q gates on error and high for all check tools
* Apply suggestions from code review
* adjust test cases
* remove duplicate assert
* Fail if aggregation is still defined
* update docs
* fix indent
* Update documentation/docs/steps/checksPublishResults.md
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-25 15:39:33 +01:00
Florian Wilhelm
9d5bd8b09b
Remove references to cloud sdk ( #2418 )
...
Not required anymore as Cloud SDK was merged into General Purpose Pipeline
2020-11-23 17:48:53 +01:00
Stephan Aßmus
c74500545c
dockerExecute: Add compatibility aliasing for renamed params ( #2391 )
2020-11-17 17:44:19 +01:00
Stephan Aßmus
cbd932a5eb
dockerExecute: Wrap all code in docker.withRegistry() ( #2384 )
...
* wrap all in docker.withRegistry()
* Renamed parameter
No backwards alias, since it never worked before.
* Fix code and tests
* Rename parameter as per review
* Rename parameter as per review
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-11-17 14:53:09 +01:00
Kevin Stiehl
dfab156427
Feature/approle secret id rotation ( #2311 )
...
* add new step vault secret
* add debug log
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-17 13:49:31 +01:00
Stephan Aßmus
0491bf3712
Always use artifactPrepareVersion ( #2360 )
...
artifactSetVersion was documented as being "deprecated" since a while, but was still used.
2020-11-16 16:38:17 +01:00
Christopher Fenner
81c8553d6a
refactor(hadolint): implement step in GO ( #1169 )
...
* initial commit of yaml file
* initial commit for HaDoLint in GO
* add helper function to load file from url
* load config file
* write report information to disk
* comment the code
* refactor groovy code
* remove download function from FileUtils
* use http.Downloader
* rename step files
* update generated files
* update generated files
* remove duplicate commands
* add credentials for config url
* add generated test file
* reuse piperExecuteBin functions
* correct step name
* update go step
* deactivate test
* fix import
* use differing go step name
* rename step
* correct result publishing
* correct command name
* expose tls insecure flag
* hand through error
* disable tls verification
* fix tls disabling
* use credentials
* mow
* reformat
* add qgate only if set
* correct report name
* remove old defaults
* add qgate to defaults
* handle report name
* restore default
* remove unused step config
* use piperExecuteBin
* remove obsolete type
* add test cases
* remove groovy tests
* move client parameter handling to run function
* use custom interfaces and mockery
* remove commented code
* correct struct names
* rename parameter dockerfile
* add further asserts
* cleanup
* change file permission to read/write
* remove tokenize
* add further comments
* init http client only if necessary
* add todo
* Revert "rename parameter dockerfile"
This reverts commit 2a570685b8
.
* add alias for dockerfile parameter
* correct test case
* Apply suggestions from code review
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
* add comment about mock assertions
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-16 15:14:54 +01:00
Florian Wilhelm
647e1ef0bd
Add deployment to performance tests stage and enable stage ( #2370 )
...
Co-authored-by: Kevin Hudemann <kevin.hudemann@sap.com>
2020-11-13 16:31:45 +01:00
Srinikitha Kondreddy
6c26a791a3
Add an option to clone from specific repository ( #2322 )
2020-11-12 20:35:59 +01:00
Kevin Hudemann
8fd6927854
Add mavenExecuteIntegration, mavenExecuteStaticCodeChecks, npmExecuteLint and npmExecuteScripts to piperPipelineStagePRVoting ( #2352 )
...
This change adds the steps mavenExecuteIntegration, mavenExecuteStaticCodeChecks,
npmExecuteLint and npmExecuteScripts to the stage piperPipelineStagePRVoting.
2020-11-12 09:25:44 +01:00
Daniel Mieg
712c568087
Create groovy step for abapEnvironmentCreateSystem ( #2303 )
...
* Create groovy step
* add to pipeline
* add includeAddon
* Adapt docu
* Adapt groovy test
* adapt stage addonBuild
* add comma
* Add to docu
* Upper case spelling
* Update docu
* adapt docu
2020-11-11 17:08:24 +01:00
Stephan Aßmus
115cfb5bae
Run nexusUpload in stage Promote ( #2349 )
2020-11-11 16:32:23 +01:00