1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-02-05 13:25:19 +02:00

1365 Commits

Author SHA1 Message Date
Ivan Nikiforov
36c555ea61
fix: too long string written to cpe git.commitMessage (#5147)
* fix too long CPE string written to git/commitMessage

* Add debug log

* Fix debug log

* Truncate long git commit message title

* Add tests for truncateString

* Fix test

* Fix tests

* Fix tests

---------

Co-authored-by: Ivan Nikiforov <ivan.nikiforov@sap.com>
2024-10-16 13:45:23 +02:00
Anil Keshav
bc8225cffb
feat(build): add buildSettingsInfo for gradleExecuteBuild (#5043)
* creating build settings info from gradle build

* fix linting issue and typo

* fixing step description

* Apply suggestions from code review

Co-authored-by: Tilo Körner <70266685+tiloKo@users.noreply.github.com>

* Address code review comments

* Fix tests

* Fix tests

* Fix tests

* Fix test

---------

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Tilo Körner <70266685+tiloKo@users.noreply.github.com>
Co-authored-by: Vyacheslav Starostin <32613074+vstarostin@users.noreply.github.com>
Co-authored-by: Vyacheslav Starostin <vyacheslav.starostin@sap.com>
2024-10-15 12:14:23 +05:00
Googlom
af05acad58
feat(events): Publish events to GCP PubSub by each step (#5122)
* test

* test

* draft

* generator

* some polishing

* go mod tidy

* fix unit

* fix unit

* fix unit

* fix unit

* fix unit

* resolve review comments

* resolve review comments

* add debug message on successful publish

* refactor to use global vault client

* cleanup

* rename

* clenup

* refactor

* remove token revocation

* handle nil vaultClient and add comments

* feat(events): Publish events (generated part) (#5131)

* add generated

* add generated

* refactor vaultClient usage

* fix unit tests

* fix unit tests

* fix
2024-10-11 14:55:39 +05:00
Manjunath
430bb9b719
Simply mvn build command (#5143) 2024-10-10 14:30:48 +02:00
Simon Dold
3225a7ddc0
Adding log download as zip archive (#5121)
* adding LogOutput to clone step

* delete comments

* adding stepName

* change step name

* adding multiple log archive outputs files

* changing file name

* change filename

* change time format

* adding second file for testing

* adding second file

* change structure for PersistReportsAndLinks

* change to pointer

* change pointer

* cleanup

* changing file name

* adding logArchive for pull action

* adding logArchive for checkoutBranch

* refactor zip archive log

* change structure

* adding PersistArchiveLogsForPiperStep function

* adding persist structure to checkout

* adding FileNameStep

* adding unit tests

* correct name

* change whitespace in yaml

* fixing unit tests

* fixing createTag unit test

* fixing unit test

* fixing unit test

* rename ArchiveOutputLogs to LogOutputManager

* refactor pointer structure

* adopt tests to pointer structure

* fixing / error in repo name

* adding log overview also after archive log

* change log output structure

* adding always execution log

* update unit tests

---------

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2024-10-10 13:42:09 +02:00
Manjunath
b9050b53a5
Handle options properly (#5142) 2024-10-09 12:13:43 +02:00
Manjunath
41536720c1
Flatten the simple bom (#5141) 2024-10-09 10:17:39 +02:00
Manjunath
20b7eff911
Run makeBOM after aggregateBOM (#5140)
* Run makeBOM after aggregateBOM

* Fix tests
2024-10-08 12:58:48 +02:00
Sarat Krishnan
033a429c49
Fix gcts deploy field anonymize (#5129)
* adding anonymisation for object field

* Further fixes to gcts deploy step

* syntax changes
2024-10-08 10:15:58 +02:00
Manjunath
c991c5b16d
Fix maven build failures due to makeBom goal (#5134) 2024-10-08 09:56:32 +02:00
Rinita Asani
f6231de55b
gctsExecuteABAPQualityCheck type mismatch (#5132)
* Adapting unit test to run for packages with namespace

* Correct type mismatch for object count
2024-10-07 16:08:27 +02:00
Vyacheslav Starostin
60cbddbd47
npm config doesn't fail when workspaces enabled (#5120)
* Add -ws=false -iwr to npm config get registry

* Add -ws=false -iwr to npm config set registry

* Fix test

* Fix test

---------

Co-authored-by: Manjunath <manjunath.mandya.surendrakumar@sap.com>
2024-10-07 11:55:20 +05:00
Oliver Nocon
ef25e31acb
fix(vault): properly consider vault parameters & flags (#5118) 2024-10-04 09:33:53 +02:00
Manjunath
5230c3d454
Include purl info in the event (#5092) 2024-10-02 09:34:34 +02:00
Srinikitha Kondreddy
90be7e43ad
feat: fail if script is not found in package.json file (#5029)
* feat: fail if script is not found

* fix tests

* Fix integration tests

---------

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2024-09-16 12:32:15 +02:00
Jordi van Liempt
a2bafe2d7f
feat(sonar): Enable trustengine for token retrieval (#5046)
Co-authored-by: jliempt <>
2024-09-16 10:20:40 +02:00
Daria Kuznetsova
085a8c003b
fix(codeqlExecuteScan): handle spaces in path to maven settings file (#5037)
* added quotes for mvn settings path

* added logs

* removed logs, added excape symbol for spaces

* set quotes

* removed replacing

* changed quotes

* fixed tests

* removed extra log

---------

Co-authored-by: sumeet patil <sumeet.patil@sap.com>
2024-09-12 10:15:11 +03:00
Jordi van Liempt
af5b738982
feat(trustengine): Integrate Trust Engine into step config resolver (#5032)
* trust engine config and handelling for vault

* add function for resolving trust engine reference

* refactor

* add basic test

* adapt to new trust engine response format

* remove accidental cyclic dependency

* move trust engine hook config

* refactor by separating code from vault

* move trust engine files to own pkg

* adapt to changes of previous commit

* log full error response of trust engine API

* enable getting multiple tokens from trustengine

* remove comment

* incorporate review comments

* go generate

* update unit tests

* apply suggested changes from code review

* fix unit tests

* add unit tests for config pkg

* make changes based on review comments

* make trust engine token available in GeneralConfig and minor fixes

* fix error logic when reading trust engine hook

* make getResponse more flexible and update logging

* update resource reference format

* improve URL handling

* improve logging

* use errors.Wrap() instead of errors.Join()

* update log messages based on suggestions

* remove trustengine resource ref from Sonar step

---------

Co-authored-by: Keshav <anil.keshav@sap.com>
Co-authored-by: jliempt <>
2024-09-11 15:20:28 +02:00
Johannes Dillmann
34f1057bfa
Copy full project (#5033) 2024-09-06 14:27:17 +02:00
Akramdzhon Azamov
91ae39c9d4
Added pagination logic for retrieving projects from Black Duck server (#5031)
* Added pagination logic for retrieving projects from Black Duck server

* fixed unit tests for getProject in blackduck

* fixed unit tests for getProject in blackduck

* fixed unit tests for getProject in blackduck
2024-09-05 09:36:14 +02:00
Daniel Mieg
cb45ad1b44
Add possible values and default (#5030) 2024-08-29 10:55:43 +02:00
Anil Keshav
238339c87e
Exposing build artifact metadata from maven and npm (#5008) 2024-08-27 08:24:38 +02:00
Tilo Körner
b5561aa8c1
add OriginHash to aakaas check (#5015) 2024-08-23 17:37:58 +03:00
Vyacheslav Starostin
8637f894f2
Add possibility to fetch jsonCredentialsAzure from Vault (#5011) 2024-08-19 16:21:44 +05:00
Googlom
773332fe1e
fix(artifactPrepareVersion): add missing error handling (#5005)
* add error handling

* add retries
2024-08-19 11:50:40 +05:00
Vyacheslav Starostin
c537a85785
vaultRotateSecretID: Update logging (#5003) 2024-08-15 14:34:19 +05:00
Pavel Busko
98e4e01635
feat(cnbBuild): warn users when dockerConfigJSON is missing necessary credentials (#5007)
* feat(cnbBuild): warn users when dockerConfigJSON is missing necessary credentials

* Update cmd/cnbBuild.go

Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>

* Update pkg/cnbutils/auth.go

Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>

* fix linting

---------

Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>
2024-08-15 10:20:01 +02:00
Jordi van Liempt
36f8d35f1c
feat(mtaBuild): Add enableSetTimestamp parameter (#4996)
* add enableSetTimestamp param to mtaBuild

* make default: true

* go generate

* update unit tests

---------

Co-authored-by: jliempt <>
2024-07-29 09:00:30 +02:00
Anil Keshav
5809632672
(fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (#4991)
* fixing cyclone dx version to version 1.4 for syft

* fixing unit test for kaniko

* fixing integration test for cnb
2024-07-22 15:17:35 +02:00
Tilo Körner
d2285f8929
Update abapAddonAssemblyKitCheck.yaml (#4992)
* Update abapAddonAssemblyKitCheck.yaml

remove bullet points as they are not rendered together with markdown

* Update abapAddonAssemblyKitCheck.yaml

* delete trailing space

* go generate
2024-07-22 14:32:26 +02:00
Tilo Körner
82f6d58735
Update abapAddonAssemblyKitCheck.yaml (#4988)
* Update abapAddonAssemblyKitCheck.yaml

remove bullet points as they are not rendered together with markdown

* go generate
2024-07-22 11:57:08 +02:00
Akramdzhon Azamov
eed058d47d
Mend verbose mode improvements (#4982)
* Excluded directory './pipeline' for detectExecuteScan step

* fixed unit-tests

* changed config path from "pipeline/*" to ".pipeline/*"

* Refactor exclude handling

* Mend verbose mode improvements

* Mend verbose mode improvements

* Mend verbose mode improvements

* Mend verbose mode improvements

* Mend verbose mode improvements

* Mend verbose mode improvements

* Mend verbose mode improvements

---------

Co-authored-by: Vijayan T <vijayanjay@gmail.com>
2024-07-10 16:02:14 +02:00
Dmitrii Pavlukhin
8e962a7729
DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step (#4958)
* Enhanced logging of build params for detectExecuteScan

* amended-parameter-description

* added-parameter-for-npm-dev-deps-inclusion

* amended-tests

* new-generated-file

* added-parameter-explicitly
2024-07-08 15:33:42 +03:00
Vyacheslav Starostin
b6b366066f
Disable telemetry reporting (#4983) 2024-07-05 17:23:57 +05:00
Vijayan T
0f427c324a
Fixed excluded directories with pattern (#4980)
Signed-off-by: Vijayan T <vijayanjay@gmail.com>
2024-07-05 16:36:25 +05:30
Marco Rosa
64aabd8daa
fix(credentialdiggerScan): get_discoveries and docker image (#4613)
* Improve logs of credentialdiggerScan step

* 'Restore step'

* Use dockerhub image for Credential Digger

* Regenerate credentialdiggerScan

* Update docker image tag

* Fix report generation with exportAll

* Update docker image for credentialdiggerScan

* Regenerate credentialdiggerScan step with new docker image

* Dont duplicate step name with log.Entry()

* Refactor RepoURL according to #4639

---------

Co-authored-by: Marcus Holl <marcus.holl@sap.com>
Co-authored-by: Googlom <36107508+Googlom@users.noreply.github.com>
2024-07-04 14:59:53 +05:00
Srinikitha Kondreddy
4a4c13ff03
Cleanup outdated blue green support for cf native build tools (#4965)
* Remove blue green deployment support for cf native build tools

* Empty for testing

* Remove obsolete dependency

* feedback from code review

* Fix IT's run

* Add test
2024-07-04 12:13:36 +03:00
Akramdzhon Azamov
e2f1c13b75
Excluded directory '.pipeline' for detectExecuteScan step (#4955)
* Excluded directory './pipeline' for detectExecuteScan step

* fixed unit-tests

* changed config path from "pipeline/*" to ".pipeline/*"

* Refactor exclude handling

---------

Co-authored-by: Vijayan T <vijayanjay@gmail.com>
2024-07-01 18:48:53 +05:30
Simon Dold
65dbd4526c
Adapt clone step to work with customer-managed Repos (BYOG) (#4966)
* adding byog credentials for clone command

* adding unit tests for clone body

* adding parameters

* adding optional byog parameters

* fixing typo in username

* remove aliases in config yaml

* change yaml config

* logs

* change info log

* change logs

* remove logs

* adding log statements

* remove log statements

* fixing typo in test class

* change repoTest structure

* remove comment

* remove comment

* generate

* adding unit test comments

* adding error handling

* adding isByog check

* fixing unit test

* generate

* Update manageGitRepositoryUtils_test.go

* restructure isByog parameter

* adding empty line for md linter

* adding config.yaml example to docs

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>

* adding release

---------

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2024-06-25 08:09:31 +00:00
Tilo Körner
b9022dc10d
Publish TargetVector enhanced retry (#4971)
* cache Error, increase max polling duration

* Update abapAddonAssemblyKitPublishTargetVector_generated.go
2024-06-24 14:49:40 +02:00
Tilo Körner
bf9c743fb6
errorcause and remove telemetry warnings (#4951) 2024-06-20 10:44:12 +02:00
Dmitrii Pavlukhin
1b728ccd3e
Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (#4956)
* Enabled the possibility to avoid aggregation of NPM projects

* renamed-function

---------

Co-authored-by: Vyacheslav Starostin <32613074+vstarostin@users.noreply.github.com>
2024-06-20 09:08:24 +03:00
KingJul1an
ab88749b2d
fix(docs): dead link in sonarExecuteScan (#4936)
* fix dead link in sonarExecuteScan.yaml

https://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner leads to "Page not found"

* Update sonarExecuteScan.yaml

* Update sonarExecuteScan.yaml

typo

* Update sonarExecuteScan_generated.go

---------

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2024-06-19 14:38:48 +02:00
Daria Kuznetsova
92a6705c2e
fix(codeqlExecuteScan): transforming querySuite to empty string (#4957)
* fixed transforming querySuite to empty string

* fixed error handling

---------

Co-authored-by: Vyacheslav Starostin <32613074+vstarostin@users.noreply.github.com>
Co-authored-by: Mihai Herda <77497647+mihai-herda-SAP@users.noreply.github.com>
2024-06-19 10:15:44 +02:00
Vijayan T
4827785a73
support for sub-module in maven build (#4950)
* support for sub-module in maven build

* fixed test-cases

Signed-off-by: Vijayan T <vijayanjay@gmail.com>

* fixed test-cases

Signed-off-by: Vijayan T <vijayanjay@gmail.com>

* changed the function name

---------

Signed-off-by: Vijayan T <vijayanjay@gmail.com>
Co-authored-by: Vyacheslav Starostin <32613074+vstarostin@users.noreply.github.com>
2024-06-19 12:52:03 +05:30
Daniel Mieg
8eeba2d005
[ABAP] Migrate SAP_COM_0510 to SAP_COM_0948 (#4925)
* Migrate SAP_COM_0510 to SAP_COM_0948

* Update error message

* Update error message

* Fix error message in unit test

* Update unit tests
2024-06-10 10:51:22 +02:00
Daria Kuznetsova
67ed27f07d
added sed cmd to transform querySuite (#4945)
* added sed cmd to transform querySuite

* changed sh to bash

* added checking os

* fixed tests by mocking utils

* fixed tests

* renamed param

---------

Co-authored-by: sumeet patil <sumeet.patil@sap.com>
2024-06-06 15:14:03 +03:00
Andrei Kireev
e2a5b0928a
feat(detectExecuteScan) Added npm install step for detectExectueScan (#4949)
* Added npm install step for detectExectueScan
2024-06-06 09:20:08 +02:00
Christopher Fenner
0ca2f72699
chore(mockery): add mockery configuration (#4941)
* update mockery config

* update mockery config

* rename mockery config

* update existing mocks

* update mockery config

* update mockery config

* move cmd mocks to cmd pkg

* add hadolint mocks to config

* use moved files

* remove comment
2024-06-04 13:40:35 +02:00
thtri
683ca35001
CxOne: Add param to tag scan and project (#4944)
* Initial in progress

* compiling but not yet functional

* Missed file

* updated checkmarxone step

* Working up to fetching a project then breaks

* Missed file

* Breaks when retrieving projects+proxy set

* Create project & run scan working, now polling

* Fixed polling

* added back the zipfile remove command

* Fixed polling again

* Generates and downloads PDF report

* Updated and working, prep for refactor

* Added compliance steps

* Cleanup, reporting, added groovy connector

* fixed groovy file

* checkmarxone to checkmarxOne

* checkmarxone to checkmarxOne

* split credentials (id+secret, apikey), renamed pullrequestname to branch, groovy fix

* Fixed filenames & yaml

* missed the metadata_generated.go

* added json to sarif conversion

* fix:type in new checkmarxone package

* fix:type in new checkmarxone package

* removed test logs, added temp error log for creds

* extra debugging to fix crash

* improved auth logging, fixed query parse issue

* fixed bug with group fetch when using oauth user

* CWE can be -1 if not defined, can't be uint

* Query also had CweID

* Disabled predicates-fetch in sarif generation

* Removing leftover info log message

* Better error handling

* fixed default preset configuration

* removing .bat files - sorry

* Cleanup per initial review

* refactoring per Gist, fixed project find, add apps

* small fix - sorry for commit noise while testing

* Fixing issues with incremental scans.

* removing maxretries

* Updated per PR feedback, further changes todo toda

* JSON Report changes and reporting cleanup

* removing .bat (again?)

* adding docs, groovy unit test, linter fixes

* Started adding tests maybe 15% covered

* fix(checkmarxOne): test cases for pkg and reporting

* fix(checkmarxOne):fix formatting

* feat(checkmarxone): update interface with missing method

* feat(checkmarxone):change runStep signature to be able to inject dependency

* feat(checkmarxone): add tests for step (wip)

* Adding a bit more coverage

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix integration test PR

* adding scan-summary bug workaround, reportgen fail

* enforceThresholds fix when no results passed in

* fixed gap when preset empty in yaml & project conf

* fixed another gap in preset selection

* fix 0-result panic

* fail when no preset is set anywhere

* removed comment

* initial project-under-app support

* fixing sarif reportgen

* some cleanup of error messages

* post-merge test fixes

* revert previous upstream merge

* adding "incremental" to "full" triggers

* wrong boolean

* project-in-application api change prep

* Fixing SARIF report without preset access

* fix sarif deeplink

* removing comments

* fix(cxone):formatting

* fix(cxone):formatting

* small sarif fixes

* fixed merge

* attempt at pulling git source repo branch

* fix(cxone):new endpoint for project creation

* fix(cxOne): taxa is an array

* fix(cxOne): get Git branch from commonPipelineEnvironment

* fix(cxOne): add params to tag a scan and a project

* fix(cxOne): unit test - update project

* fix(cxOne): unit test - update project tags

* fix(cxOne): improve logs

* fix(cxOne): improve logs

---------

Co-authored-by: michael kubiaczyk <michael.kubiaczyk@checkmarx.com>
Co-authored-by: michaelkubiaczyk <48311127+michaelkubiaczyk@users.noreply.github.com>
Co-authored-by: sumeet patil <sumeet.patil@sap.com>
2024-06-03 10:01:50 +02:00