Oliver Nocon
59f32cf042
feature(vault) retrieve github token from Vault ( #2484 )
2020-12-22 17:57:11 +01:00
Oliver Nocon
4bd155d1ed
feature(protecodeExecuteScan) proper Vault support ( #2483 )
2020-12-22 17:43:57 +01:00
lndrschlz
b101106a05
chore: hide warn level if verbose not configured ( #2466 )
2020-12-22 14:33:11 +01:00
Fabian Reh
40a594f5fa
Add section about signing commits in git. ( #2488 )
...
* Add section about signing commits in git.
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Fixes headings
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
2020-12-22 10:09:35 +01:00
Fabian Reh
d8d4f83fb4
Unit test enhancement ( #2471 )
...
* Fixes parallelization in generated code
* Fixes test_code_generated.golden
* generate go code
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-22 09:30:54 +01:00
Hans Schulz
e9a7590c5c
Add cfTrace parameter ( #2248 )
...
* add cfTrace parameter
* make cfTrace toggle creation of log file
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-21 17:46:52 +01:00
Oliver Nocon
7de42230e0
add step to create a GitHub issue ( #2481 )
...
* add step to create a GirHub issue
* add groovy library step
* Update githubcreateissue.yaml
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 17:13:16 +01:00
Oliver Nocon
cf7ca8f791
add step to create a GitHub comment ( #2479 )
...
* add step to create a GitHub comment
* add docs
* mandatory parameters
* add command
* Update githubCommentIssue.go
* add groovy library step
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 16:21:07 +01:00
Stephan Aßmus
cb069148d2
WS: Provide missing aliases ( #2485 )
2020-12-21 13:16:38 +01:00
Marcus Holl
cdb784aaf4
fiori cts upload ( #2390 )
...
fiori cts upload
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2020-12-21 09:05:49 +01:00
Marcus Holl
a84692ea97
Remove strange 'Hello', most likly troubleshoot leftover ( #2475 )
...
in case this is really important it should be logged and not
emitted to stdout.
2020-12-18 11:15:15 +01:00
tiloKo
dbef910e83
Update abapAddonAssemblyKitCheckPV.go ( #2468 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-12-16 11:19:48 +01:00
Peter Persiel
fe6a0b057e
Replace naming of software product with add-on product ( #2450 )
...
Co-authored-by: Dominik Lendle <59923031+dominiklendle@users.noreply.github.com>
2020-12-16 10:11:41 +01:00
Marcus Holl
f9fc642c0e
http client: tell us which resource was not found ( #2410 )
...
Up to now we get a message 'Requested resource could not be found' which is not very
helpul during troubleshooting based on the log. With this change we tell the reader
which resource could not be resolved.
2020-12-16 08:55:22 +01:00
Srinikitha Kondreddy
d9a1355220
Fix typo ( #2436 )
2020-12-14 15:02:49 +01:00
Peter Persiel
e1935fe3dc
link multitenant application in ABAP Environment ( #2451 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-12-14 14:35:51 +01:00
Christopher Fenner
9cd3ee5758
fix(checks+tests): fail pipeline if plugins fail the build ( #2463 )
...
* fix false negative
* add comment
* add default
2020-12-11 14:49:36 +01:00
Oliver Feldmann
96ebaa1a20
chore(docs): Fix switheroo of deployType and deployTool typo ( #2464 )
...
* Fix switcheroo
* Add commas
2020-12-11 13:11:36 +01:00
Daniel Mieg
44e7766e8f
Add stage docu ( #2460 )
...
* Add stage docu
* Add table to configuration.md
* Add comment to clone repo stage
* Fix indentation errors
* Docu: commitID
* fix links
2020-12-10 14:28:03 +01:00
Oliver Feldmann
4f6b99cead
Don't allow empty strings as default container parameters ( #2406 )
...
First a bug fix is addressed in which the pull policy could not be configured to false by configuring the general configuration. It could neither be configured via dockerExecute or dockerExecuteOnKubernetes, even though this parameter is docker specific. Only by configuring the specific step where one wants to set the pull policy to false can it be configured.
As the bug stems from zero values being in the context config map, which is also addressed with this PR. That is the second part: Context config parameters are only set if they have a value.
* Don't set pull image if not configured
Otherwise, if the pull policy is not set explicitly for a step, dockerPullImage is set to true. Thus, before this change, it cannot be set in the general, or in dockerExecute or in dockerExecuteOnKubernetes configuration.
* Fix unit tests
* Add pullImage parameter test
* Do not place empty default values in context config
* Use putIfNotEmpty for sidecar container options
* Export common configuration
Keys that are set by both main and sidecar container can be exported
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-12-10 11:28:39 +01:00
Christopher Fenner
6970b57468
fix(cfDeploy): correct stash for go step ( #2456 )
2020-12-09 14:31:07 +01:00
Peter Persiel
f32420eb92
Change abap-oem service to saas_oem service plan ( #2415 )
2020-12-08 13:26:51 +01:00
Daniel Mieg
a3ff90f632
Fix: Change URL creation for abapEnvironmentCloneGitRepo ( #2452 )
...
* Fix url creation
* Adapt url creation
2020-12-08 09:31:08 +01:00
Florian Wilhelm
2ac5c42d15
Don't update go dependencies on schedule ( #2447 )
2020-12-07 09:20:31 +01:00
Marcus Holl
17bdbe2ef4
piperExecuteBin: provide credentials directly without indirection into config ( #2437 )
...
`piperExecuteBin` is called with a credentials list. Each list entry is a map consisting of
* the type of the credential (e.g. usernamePassword, token)
* the identifier which is used for resolving the credential.
* a list of environment variables which holds the resolved credentials.
Inside `piperExecuteBin` the id was resolved against the config and the result was used for resolving the credentials against the jenkins-credentials-plugin.
With this change here we introduce another key for the map mentioned above:
* resolveCredentialsId
When this key is provided with value `false` we do not resolve the credentials-id from the config. In that case the id is directly used for resolving the credential again the jenkins-credentials-plugin.
2020-12-07 08:54:49 +01:00
Christopher Fenner
fac4af231f
fix(cfDeploy): correct stashing ( #2448 )
...
* remove stash from step yaml
* add stash to groovy code
2020-12-05 13:35:16 +01:00
Florian Wilhelm
7dc2c86758
Revert "Update Go dependencies ( #2441 )" ( #2449 )
...
This reverts commit e03f2ba98c
.
There is a regression in the go lib which was updated in this commit
2020-12-04 16:10:47 +01:00
Florian Wilhelm
e03f2ba98c
Update Go dependencies ( #2441 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-12-04 11:09:11 +01:00
Daniel Mieg
b001474edd
Remove input statement ( #2419 )
...
* Remove input statement
* adaptDocu
2020-12-04 10:03:41 +01:00
Daniel Mieg
4573410379
Update abapEnvironmentAddons.md ( #2446 )
2020-12-04 09:31:53 +01:00
Kevin Stiehl
7d275b3ec3
fix(cloudfoundry): fetch credentials from vault ( #2444 )
2020-12-03 18:30:32 +01:00
Christopher Fenner
e1d140e513
fix(checksPublishResults): typo in tool it key ( #2443 )
2020-12-03 14:16:04 +01:00
Daniel Kurzynski
0afc5dd1bd
Update CAP Scenario ( #2438 )
...
* Update CAP Scenario
* Next step
2020-12-02 16:43:28 +01:00
Stephan Aßmus
e48b5c588e
Include configFile in pipelineConfigAndTests stash ( #2424 )
2020-12-01 12:04:27 +01:00
Daniel Mieg
518d2fe88d
Add parent_saas_appname ( #2434 )
2020-11-30 10:50:43 +01:00
Christopher Fenner
c9e2a09ca1
fix(docs): typo in sample parameter ( #2433 )
...
* fix typo
* add code blocks
2020-11-30 08:57:48 +01:00
Daniel Kurzynski
c09c5e1ef0
Fix workingDir for mta whitesource scan ( #2431 )
...
* Update whitesource.yaml
* Generate and format
2020-11-27 11:39:21 +01:00
tiloKo
080cb025a4
AAKaaS upload in chunks ( #2422 )
...
* Upload in Chunks
* fix unit tests for file upload in chunks
* upload in chunks review round 1
* Upload in Chunks - review round 2 - comments
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-26 13:45:51 +01:00
Stephan Aßmus
2f444be997
WhiteSource: Force update of project when "checkPolicies" failed ( #2401 )
...
* Force update of WS project
* Refactor file filtering to avoid duplicated code
2020-11-26 11:45:53 +01:00
Sven Merk
2511ec9cea
fix backslash mess ( #2428 )
2020-11-26 11:22:54 +01:00
Daniel Kurzynski
d952cb89d6
Add docker image for whitesource and mta ( #2374 )
2020-11-26 10:45:47 +01:00
Christopher Fenner
860b28884c
chore(jenkins): expose artifacts save method ( #2426 )
...
* fix code smell
* expose artifact.Save function
* regenerate mock file
2020-11-26 10:06:14 +01:00
Sven Merk
26af83b1fc
Add slash backslash compatibility ( #2425 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-26 09:18:01 +01:00
Thilaknath
104435c8dd
Show user friendly error messages for pipeline restart step. ( #2409 )
...
* Add message parameter to pipelineRestart to make error messages user friendly
* Update the parameter to the correct name
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-26 08:03:22 +01:00
Kevin Stiehl
e2335b7181
(documentation) fix documentation render bug ( #2423 )
...
* fix documentation render bug
* fix tests
* fix complexity
2020-11-26 07:51:43 +01:00
Saschl
ee27cbba05
Removed hardcoded pom.xml and added test ( #2393 )
...
Test verifies that correct pom.xml is used as provided in the parameters
Also removed the --file pom.xml in the tests as maven should take pom.xml as default
2020-11-25 17:03:11 +01:00
Christopher Fenner
eff1933a61
refactor(checks): use warnings-ng plugin ( #2398 )
...
* use recordIssues
* fix c&p issue
* simplify code
* fix
* add quality gates
* change qgates to TOTAL_HIGH
* remove pattern for tasks
* use TOTAL_ERROR for checkstyle
* fix indent
* use deprecated threshold parameters
* debug messages
* transform legacy qgates
* fix
* adjust test cases
* correct qgates
* correct legacy thresholds
* fix typo
* remove deprecated defaults
* add test case
* log use tool
* add notification
* remove deprecated defaults
* remove deprecated parameter
* adjust legacy threshold message
* add q gates on error and high for all check tools
* Apply suggestions from code review
* adjust test cases
* remove duplicate assert
* Fail if aggregation is still defined
* update docs
* fix indent
* Update documentation/docs/steps/checksPublishResults.md
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-25 15:39:33 +01:00
Sven Merk
5d1782aa01
checkmarxExecuteScan: adapt to 9.2 api ( #2363 )
...
* Update checkmarxExecuteScan.go
* api mods
* Switch default
* Fix decode
* mod marshalling
* Fix unmarshalling
* Code fmt and small fix
* Optimize preset handling
* Integer handling
* Fix test
* cleanup
* go fmt
* Improve test
2020-11-25 13:47:26 +01:00
Michael
fd0e8d4c9f
[typo] relese -> release ( #2420 )
2020-11-25 13:35:37 +01:00
Florian Wilhelm
55f25ace49
npmExecuteScripts: install dependencies by default ( #2376 )
2020-11-24 18:15:30 +01:00