Marcus Holl
80bd4cf11c
Support code page parameter
2019-02-14 09:36:51 +01:00
weloli
523fc067f1
fix general config for param changeManagement ( #513 )
2019-02-14 08:45:20 +01:00
Oliver Nocon
793df723cf
add step slackSendNotification ( #338 )
...
* add step slackSendNotification
This step allows to send Slack notifications in case of pipeline failures.
* add SWA reporting
* remove allowBuildFailure
* add GENERAL_CONFIG_KEYS
* update STEP_NAME
* add missing import
* fix MD findings
* adjust rule name to be aligned with #455
2019-02-13 16:45:35 +01:00
Marcus Holl
af5d67aaf7
docker params as map when releasing tr via rfc
2019-02-13 14:58:46 +01:00
weloli
72adaf3dd5
Merge branch 'master' of https://github.com/weloli/jenkins-library into pr/fixStageDoc
2019-02-13 14:35:56 +01:00
Marcus Holl
5f07490cf2
Unstash in loop only if identifier is available
...
In case unstashAll is called with a Set containing a null value we get
an ugly message in the log:
Unstash failed: null (Could not instantiate {name=null} for UnstashStep(name: String):
This can be avoided by unstashing only in case we have an ID.
2019-02-13 14:31:25 +01:00
weloli
0d0fe3a2a8
fix according to last agreement
2019-02-13 14:29:05 +01:00
weloli
8d48582033
adapt test to changed expectation
2019-02-13 14:01:56 +01:00
Marcus Holl
11812f5c09
Merge remote-tracking branch 'github/master' into HEAD
2019-02-13 09:15:32 +01:00
Marcus Holl
56d3a6ed97
Merge pull request #496 from marcusholl/pr/removePrintlnFromTests
...
Remove println statements from tests
2019-02-13 09:10:11 +01:00
Marcus Holl
2d7079a8c9
Merge remote-tracking branch 'github/master' into HEAD
2019-02-13 09:05:28 +01:00
Marcus Holl
befe786596
Merge pull request #495 from marcusholl/pr/noPrintlnInDefaultSHClosures
...
Remove println statements from default registered sh closure
2019-02-13 09:03:10 +01:00
Marcus Holl
ff88bfa79f
Merge remote-tracking branch 'github/master' into HEAD
2019-02-13 08:51:26 +01:00
weloli
e4c73d0100
add test to prove wrong documentation
2019-02-12 16:56:06 +01:00
Marcus Holl
0ae673c021
docker params as map when creating tr via rfc
2019-02-12 15:35:27 +01:00
Marcus Holl
dc1dfd622c
docker params as map for fileUpload
2019-02-12 15:22:22 +01:00
Marcus Holl
2aa9f5215a
fix code climate issues
2019-02-11 11:53:01 +01:00
SarahNoack
26ba407e9c
Doc: Change size of figure title ( #504 )
2019-02-11 08:57:31 +01:00
weloli
184613a78b
Merge branch 'master' of https://github.com/weloli/jenkins-library into pr/fixStageDoc
2019-02-08 16:09:41 +01:00
SarahNoack
f42b2502da
Add CAP Scenario in Navigation ( #502 )
2019-02-08 15:45:24 +01:00
SarahNoack
ced1cebc4b
Merge pull request #493 from SAP/CAP_Scenario
...
📄 Describe Cloud Application Programming Model Scenario
2019-02-08 14:40:53 +01:00
Christoph Szymanski
0402811f2f
Merge branch 'master' into CAP_Scenario
2019-02-08 14:23:36 +01:00
SarahNoack
04c0316983
Remove ", buildTarget:'CF'"
...
Remove ", buildTarget:'CF'" from Jenkinsfile example
2019-02-08 13:51:41 +01:00
SarahNoack
a5597a447c
Add SAP CP to CF account
2019-02-08 13:48:09 +01:00
SarahNoack
5d0daafe00
Remove note
...
Exchange note that this is a basic scenario with a single sentence in the paragraph before
2019-02-08 13:43:33 +01:00
Christoph Szymanski
40ff8fa2e3
Build Target from Parameter to Configuration
...
as discussed with @marcusholl
2019-02-08 13:09:30 +01:00
Marcus Holl
9305a52d0f
Merge remote-tracking branch 'github/master' into HEAD
2019-02-08 12:38:59 +01:00
Christopher Fenner
d657f0dc28
testsPublishResults: add option to fail the build on test errors ( #472 )
...
* add option to fail the build on test errors
* fix typo
* add test cases
* adjust docs
* set build result
* add hasTestFailure utils method
* use utils method
* use dedicated type
* adapt tests
* handle missing test actions
* Update testsPublishResults.md
* Update JenkinsUtils.groovy
* Update JenkinsUtils.groovy
* Update JenkinsUtils.groovy
* remove comments
* adapt test case
* Update TestsPublishResultsTest.groovy
2019-02-08 12:30:59 +01:00
Christopher Fenner
3f12015364
dockerExecuteOnKubernetes: generate documentation ( #487 )
...
* fix whitespace
* correct key order
* add docs annotation
* add key documentation
* remove generated documentation
* fix code climate finding
2019-02-08 12:20:45 +01:00
Marcus Holl
91785a3c74
Fix log message when an upload has been performed
2019-02-08 12:19:20 +01:00
Marcus Holl
8b13164d74
[fix] remove inapproriate package statement ( #497 )
...
The test class is in the default package and not in a package 'steps'.
2019-02-08 12:03:41 +01:00
Marcus Holl
fe147eff81
Handle parameters as env vars instead of options for RFC upload
...
options are not supported for dockerExecuteOnKubernetes, but
environment variables are. Hence we switch to environment variables
which works on both, plain docker and on kubernetes.
Using env vars is the cleaner approach anyway.
2019-02-08 12:03:05 +01:00
Marcus Holl
3a8bd80f09
fix: table not generated by mkdocs due to wrong syntax ( #498 )
2019-02-08 11:35:58 +01:00
Marcus Holl
df90255739
publish docu for step uiVeri5ExecuteTests ( #499 )
2019-02-08 11:15:32 +01:00
weloli
35e14f9667
fix stage definition
2019-02-08 10:10:02 +01:00
Marcus Holl
d369d3cd4a
Remove println statements from tests
...
Nobody will have a look at println statements emitted by tests. Proper way is to assert.
* log is empty, not sure if it makes sense to assert that the log is empty.
* result is already asserted, so everything is fine there ...
2019-02-07 17:03:32 +01:00
Marcus Holl
6b4d2ba33e
Remove println statements from default registered sh closure
...
We should try to avoid promting statements to the log during tests. This is basically
some kind of manual/visual checking of conditions. This does not work since in most cases
nobody scans test logs manually/visually. I think this is often a smell for missing assertions.
2019-02-07 16:58:49 +01:00
SarahNoack
b186e95dec
Fix another code climate issue
2019-02-07 16:44:04 +01:00
SarahNoack
ed99ac6bf7
Fix code climate issues
2019-02-07 16:42:18 +01:00
SarahNoack
214bc7a7c3
Make minor linguistic changes
2019-02-07 16:33:33 +01:00
SarahNoack
287eab8fae
Rework scenario
2019-02-07 16:16:10 +01:00
Noack
8e99bd4c63
Add CAP scenario
2019-02-07 13:57:57 +01:00
Marcus Holl
8d1786fa8d
DevelopmentInstance for upload file rfc
2019-02-07 11:46:45 +01:00
Marcus Holl
3a982a8f04
provide developent instance for transportRequest release RFC
2019-02-07 11:24:39 +01:00
Marcus Holl
54018be2f0
Provide developmentInstance for transportRequestCreate RFC
2019-02-07 11:18:32 +01:00
Marcus Holl
e9c1834f9d
Provide development instance for create transport request RFC
2019-02-07 11:12:17 +01:00
Marcus Holl
d8d2d8b1fd
abap development client always under changeManagement.rfc
2019-02-07 10:11:22 +01:00
Marcus Holl
fb9ec4992f
development client not via flat parameter
2019-02-07 09:44:17 +01:00
Marcus Holl
074929a6ac
echo command line also in case of RFC related tasks
2019-02-07 09:25:56 +01:00
Marcus Holl
5aecea02b6
control flow: Replace if with case
2019-02-07 09:21:50 +01:00
