1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Commit Graph

1848 Commits

Author SHA1 Message Date
Marcus Holl
dea2dbcbaa neoDeploy: assert deployable exists before starting deployment.
Up to now the presence of the deployable (source) was checked late
by the NeoCommandLineHelper. The code doing this is surrounded by
the try/catch which finally also puts the log written by the neo
toolset into the job log in case an exception occured.

The check for the deployable returns with the same type of
exception like a failed neo command. Hence we cannot distiguish (ok,
would be possible to parse the exception message, but that is ugly).
When the exception is triggered by the missing deployable we try to
cat the neo log into the job log. But at this point the neo log has
not been provided - neo has not been called at all in this case.
Hence `cat logs/neo/*` in turn fails.

In order to avoid such a failure we check now for the presence of the
deployable earlier before launching the neo toolset.

Since the deployable is used in any deploy mode case no further check
for the deploy mode is required prior to the check for the deployable.
2019-04-02 13:53:31 +02:00
Oliver Nocon
24563db155
update stashing behavior (#628)
* update stashing behavior

close #619

* add test
2019-04-02 13:13:25 +02:00
Sven Merk
7f4f0eef00 JSON strings into tripple quotes 2019-04-01 16:33:10 +02:00
Sven Merk
b618764a00 Use ExpectedException 2019-04-01 16:13:48 +02:00
Sven Merk
a43760d34a Use JenkinsCredentialsRule 2019-04-01 15:59:20 +02:00
Sven Merk
4e144b80a1 Refactor test to address last review comments 2019-04-01 14:43:44 +02:00
Alejandra Ferreiro Vidal
4f93f1f07a healthExecuteCheck: generate docu 2019-04-01 11:14:38 +02:00
Sven Merk
8d1ce13e4e Refactor test to address review comments 2019-04-01 09:03:56 +02:00
Sven Merk
1b7b1c5214 Refactor test to address review comments 2019-04-01 09:01:31 +02:00
Marcus Holl
2b1b743082 provide the log in case of a failure always, not only in docker context
from property dockerImage we cannot conclude that we are in fact running inside a docker environment.
Step dockerExecute has some checks if we are in a docker context. If not there is a fallback to the
local environment.

The docker image property is provided from resources/default_pipeline_environment (value: 's4sdk/docker-neo-cli').
Hence a value will be present all the time (exception: someone configured null/ empty string explicitly). So we
will enter the corresponding code block anyway.

It is IMO also desirable to have the neo log in the job log when running inside a non-docker setup since this
simplifies troubleshooting anyway.
2019-03-29 16:31:09 +01:00
Sven Merk
3191d8bb26 Fix mime type for accept header 2019-03-29 14:45:05 +01:00
Sven Merk
55e3622e6b Remove obsolete code, avoid caching of request 2019-03-29 14:38:43 +01:00
Sven Merk
8698795ba6 Fix NonCPS 2019-03-29 14:24:46 +01:00
Sven Merk
d169bfb619 Refactor file download 2019-03-29 14:22:42 +01:00
Sven Merk
c82bcc9c86 Addressed feedback 2019-03-29 13:58:41 +01:00
Sven Merk
50b0e8e377 Use new failErrorLevel parameter 2019-03-29 12:11:10 +01:00
Sven Merk
aaf969e0cf
Merge branch 'master' into whitesource-step 2019-03-29 11:01:15 +01:00
Alejandra Ferreiro Vidal
78400cad9b
Merge pull request #589 from alejandraferreirovidal/cleanUpToolValidate
Remove step toolValidate
2019-03-29 09:31:19 +01:00
Sven Merk
069d2d69f9
Merge branch 'master' into whitesource-step 2019-03-29 09:01:09 +01:00
Alejandra Ferreiro Vidal
eba4c68a49 remove documentation 2019-03-29 08:44:36 +01:00
Alejandra Ferreiro Vidal
6b98d642da removes toolValidate 2019-03-29 08:44:36 +01:00
Alejandra Ferreiro Vidal
a3b050b184
Merge pull request #595 from alejandraferreirovidal/formatNeoDeploy
Format neo deploy test
2019-03-29 08:36:47 +01:00
Sven Merk
452158256c
Merge branch 'master' into whitesource-step 2019-03-28 16:59:14 +01:00
Alejandra Ferreiro Vidal
8e59531789 format: add new lines following format 2019-03-28 14:10:32 +01:00
Alejandra Ferreiro Vidal
060c5066e8 remove deprecated code 2019-03-28 14:10:32 +01:00
Alejandra Ferreiro Vidal
e55ccc3fe9 add JenkinsFileExistsRule 2019-03-28 14:10:32 +01:00
Alejandra Ferreiro Vidal
1a1a7559d5 rename war properties file 2019-03-28 14:10:32 +01:00
Christopher Fenner
2369573f14
web analytics: use httpRequest step (#587)
* change reporting to use httpRequest step

* Update TelemetryTest.groovy

* adapt tests

* remove import

* avoid NonSerialisableException on HashMap.Entry

* Update Telemetry.groovy

* decrease timeout to 10 seconds

* remove null check

* make helper method static

* fix codeclimate issues
2019-03-28 11:54:45 +01:00
Sven Merk
4ed0f8df36 Trigger build 2019-03-27 23:46:43 +01:00
Marcus Holl
97c4ebf3dd provide the docu metadata as json 2019-03-27 17:21:08 +01:00
Marcus Holl
5ad99599ab Make use of the step tracker 2019-03-27 16:02:04 +01:00
Marcus Holl
a42e727da2 Create step specific plugin lists: Helper class for tracking step calls
Before the test we remmber which test is currently running.
During the test we collect all the calls to steps.

Beside that we persist the names of all steps within this shared
lib itself.

After the test(s) we write a corresponding json file. In fact we
write the file after each test, which is too often. But since we
don't know which test is the last test we can't do better.

The resulting file can be used later on for resolving the plugins
contributing the particular steps.

With that we are able to create a list of required plugins for each
step.
2019-03-27 16:02:04 +01:00
Marcus Holl
5710ac48ec Introduce step helper 2019-03-27 15:54:25 +01:00
Sven Merk
da549bc2e6
Merge branch 'master' into whitesource-step 2019-03-27 14:36:37 +01:00
Sven Merk
b9596aa84f Add deletion of downloaded JVM archive 2019-03-27 14:11:54 +01:00
Sven Merk
6b1caf5a3c Add deletion of downloaded JVM archive 2019-03-27 14:10:29 +01:00
Sven Merk
ea211f5987 Add archiving of debug output to new step 2019-03-27 14:03:11 +01:00
Marcus Holl
ec58986ac5
Merge pull request #593 from marcusholl/pr/solmanMinVersion
Prerequiste transportRequestCreate: SOLMAN ST720 SP08 or higher
2019-03-27 13:57:17 +01:00
Marcus Holl
0e2c90bd79
Merge branch 'master' into pr/solmanMinVersion 2019-03-27 13:03:54 +01:00
Sven Merk
eab1dacde6 Fix stashes 2019-03-27 12:58:54 +01:00
Sven Merk
f1c3311b3d
Merge branch 'master' into whitesource-step 2019-03-27 12:06:26 +01:00
Sven Merk
6c85699689 Fix docu template 2019-03-27 11:57:48 +01:00
Thorsten Duda
d8ef8eb577 [docu] remove old reference pipelines (#594)
* remove old reference pipelines

* fix trailing space
2019-03-27 11:42:07 +01:00
Sven Merk
ae083f5aa7
Merge branch 'master' into whitesource-step 2019-03-27 09:32:05 +01:00
Sven Merk
9466beec42 Fix tests 2019-03-26 17:45:29 +01:00
Sven Merk
b188a59ee5 Fix config 2019-03-26 17:33:04 +01:00
Sven Merk
b2929a9070 Fix path 2 2019-03-26 17:26:09 +01:00
Sven Merk
957bad0d45 Fix path 2019-03-26 17:22:51 +01:00
Sven Merk
8adf183395 Fix quoting 2019-03-26 17:16:44 +01:00
Sven Merk
e5420b1e8a Add parameter 2019-03-26 17:07:15 +01:00