Daniel Kurzynski
d91fb9053f
Use devxci/mbtci:1.0.16.1 ( #2389 )
...
* Use docker.pkg.github.com/sap/cloud-mta-build-tool/mbtci:1.0.16
* Revert and use devxci/mbtci:1.0.16.1
* Fix typo
2020-11-17 14:24:36 +01:00
Kevin Stiehl
dfab156427
Feature/approle secret id rotation ( #2311 )
...
* add new step vault secret
* add debug log
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-17 13:49:31 +01:00
Daniel Kurzynski
8653780cf6
Stash also original jar ( #2387 )
2020-11-17 12:04:25 +01:00
Dominik Lendle
948b90b35a
catch error in ATC step ( #2380 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-17 11:18:16 +01:00
tiloKo
109f5cd1bf
Wait between posts ( #2355 )
...
* Update abapEnvironmentAssemblePackages.go
* Save 6 Seconds in Unit Tests
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-17 10:26:15 +01:00
Christopher Fenner
1514be9857
chore: fix markdownlint findings ( #2385 )
...
* activate MD022
* fix MD022 findings
* activate MD030
* fix MD030 findings
* activate MD038
* fix MD038 findings
* activate MD031
* fix MD031 findings
* activate MD042
* fix MD042 findings
* activate MD032
* fix MD032 findings
* activate MD039
* activate MD007
* fix MD007 findings
* activate MD026
* fix MD026 findings
* activate MD001
* fix MD001 findings
* acknowledge disabled rules
* fix code climate MD032 finding
2020-11-17 09:20:47 +01:00
Christopher Fenner
052a65d495
chore(code climate): ignore generated mock files ( #2378 )
...
fixes #2377
2020-11-17 08:23:39 +01:00
Christopher Fenner
20fd6e82ff
fix: markdownlint findings for MD012 ( #2383 )
...
* activate MD012
* activate MD012
* fix MD012 findings
* fix MD012
2020-11-16 18:22:38 +01:00
Christopher Fenner
70eab49cb7
chore(code climate):sync config with local mdlint config ( #2381 )
2020-11-16 17:50:31 +01:00
Stephan Aßmus
0491bf3712
Always use artifactPrepareVersion ( #2360 )
...
artifactSetVersion was documented as being "deprecated" since a while, but was still used.
2020-11-16 16:38:17 +01:00
Christopher Fenner
81c8553d6a
refactor(hadolint): implement step in GO ( #1169 )
...
* initial commit of yaml file
* initial commit for HaDoLint in GO
* add helper function to load file from url
* load config file
* write report information to disk
* comment the code
* refactor groovy code
* remove download function from FileUtils
* use http.Downloader
* rename step files
* update generated files
* update generated files
* remove duplicate commands
* add credentials for config url
* add generated test file
* reuse piperExecuteBin functions
* correct step name
* update go step
* deactivate test
* fix import
* use differing go step name
* rename step
* correct result publishing
* correct command name
* expose tls insecure flag
* hand through error
* disable tls verification
* fix tls disabling
* use credentials
* mow
* reformat
* add qgate only if set
* correct report name
* remove old defaults
* add qgate to defaults
* handle report name
* restore default
* remove unused step config
* use piperExecuteBin
* remove obsolete type
* add test cases
* remove groovy tests
* move client parameter handling to run function
* use custom interfaces and mockery
* remove commented code
* correct struct names
* rename parameter dockerfile
* add further asserts
* cleanup
* change file permission to read/write
* remove tokenize
* add further comments
* init http client only if necessary
* add todo
* Revert "rename parameter dockerfile"
This reverts commit 2a570685b8
2020-11-16 15:14:54 +01:00
Christopher Fenner
e8c74a4867
chore(sonar): set proper error categories ( #2358 )
...
* expose GetExitCode
* set error category for user issues
* fix typo
* Update command.go
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-16 14:54:22 +01:00
tiloKo
2a5514c116
AAK endpoint default ( #2356 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-16 13:40:57 +01:00
Kevin Stiehl
9cb605ba60
[Documentation ]fix checkmarx docs ( #2372 )
...
* fix checkmarx docs
* go generate
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-16 13:03:31 +01:00
Kevin Stiehl
6c51b76fcf
(documentation) Vault Setup documentation ( #2366 )
...
* add vault documentation
* fix test
* fix typo
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-16 11:53:52 +01:00
shellmann
61c190bb2b
Install artifacts before Fortify scan ( #2351 )
...
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-11-16 10:29:21 +01:00
Peter Persiel
fb36f9545a
abapEnvironmentCreateSystem instead of Clone Repo ( #2353 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-16 09:19:05 +01:00
Christopher Fenner
b6e4ae5094
Update config.yml ( #2371 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-13 16:51:25 +01:00
Florian Wilhelm
647e1ef0bd
Add deployment to performance tests stage and enable stage ( #2370 )
...
Co-authored-by: Kevin Hudemann <kevin.hudemann@sap.com>
2020-11-13 16:31:45 +01:00
Marcus Holl
3e3a29ffd2
Support additional volume mounts for cm related steps ( #2287 )
...
* Fix asserts
* support additional volume mounts for cm related steps
2020-11-13 13:45:30 +01:00
Kevin Hudemann
83daa33e65
Update defaults for npmExecuteScripts and mavenExecuteIntegration to run install ( #2369 )
...
This change updates the defaults for npmExecuteScripts to run npm install and mavenExecuteIntegration to install all artifacts by default.
2020-11-13 13:01:02 +01:00
Srinikitha Kondreddy
6c26a791a3
Add an option to clone from specific repository ( #2322 )
2020-11-12 20:35:59 +01:00
Kevin Hudemann
7a04bb9749
Add runStep conditions for mavenExecuteIntegration and npmExecuteScripts in Integration stage ( #2361 )
...
This change adds runStep conditions for the steps mavenExecuteIntegration and
npmExecuteScripts for the stage Integration.
2020-11-12 16:50:57 +01:00
Florian Wilhelm
5fa2985d31
Unstash sources in integration tests ( #2362 )
...
* Unstash sources in integration tests
* Use stashSettings.yml instead
2020-11-12 16:23:55 +01:00
Christopher Fenner
fe58c3fed2
refactor: remove duplicate function from interface ( #2359 )
...
* remove duplicate function from interface
* remove import to net/http
2020-11-12 15:24:10 +01:00
Stephan Aßmus
23d378d4ce
Conditions for npmExecuteScripts in Additional Unit Tests ( #2357 )
2020-11-12 12:41:11 +01:00
Kevin Hudemann
8fd6927854
Add mavenExecuteIntegration, mavenExecuteStaticCodeChecks, npmExecuteLint and npmExecuteScripts to piperPipelineStagePRVoting ( #2352 )
...
This change adds the steps mavenExecuteIntegration, mavenExecuteStaticCodeChecks,
npmExecuteLint and npmExecuteScripts to the stage piperPipelineStagePRVoting.
2020-11-12 09:25:44 +01:00
Daniel Mieg
712c568087
Create groovy step for abapEnvironmentCreateSystem ( #2303 )
...
* Create groovy step
* add to pipeline
* add includeAddon
* Adapt docu
* Adapt groovy test
* adapt stage addonBuild
* add comma
* Add to docu
* Upper case spelling
* Update docu
* adapt docu
2020-11-11 17:08:24 +01:00
Stephan Aßmus
115cfb5bae
Run nexusUpload in stage Promote ( #2349 )
2020-11-11 16:32:23 +01:00
Florian Wilhelm
0356f13853
Improve error message for legacy cloud sdk config ( #2348 )
2020-11-11 14:47:55 +01:00
Marcus Holl
56586cae1b
Remove assert.Error right before assert.EqualError ( #2344 )
...
Is there any benefit from having
```
assert.Error(./.)
assert.EqualError(./.)
```
?
assert.Error ensures that we have an error.
assert.EqualError ensures that we have an error and
moreover it checks for a specific error. Hence
assert.EqualError does all and more what assert.Error
does.
In case there is a benefit from that pattern this PR should not be merged.
In case there is not benefit from that pattern we should abandong that pattern.
2020-11-11 14:14:55 +01:00
Oliver Nocon
51c63c9da1
update icon and favicon ( #2347 )
2020-11-11 13:51:54 +01:00
Sven Merk
3c7712f2ee
Retry capabilities for HTTP requests + enablement for Checkmarx step ( #2346 )
2020-11-11 13:35:53 +01:00
Oliver Nocon
a70933bbd4
fortifyExecuteScan: improve error categorization ( #2295 )
...
* fortifyExecuteScan: improve error categorization
* reset error category in success case
2020-11-11 13:04:45 +01:00
Marcus Holl
d327c2e061
Revert "Avoid CPS serialization issue in setupCPE ( #2261 )" ( #2305 )
...
This reverts commit c9b50d7f10
2020-11-11 10:44:49 +01:00
Peter Persiel
f5dfcc4a21
Add limitation for only using master branch in software components ( #2330 )
...
* Add limitation for only using master branch
* Update documentation/docs/scenarios/abapEnvironmentAddons.md
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-10 18:40:33 +01:00
Peter Persiel
921a9abd13
Fix is_development_allowed typo ( #2328 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-10 17:46:22 +01:00
Daniel Kurzynski
9a18489cc4
Refactor maven utils and add tests for install artifacts ( #2318 )
...
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-10 17:14:55 +01:00
Daniel Mieg
2c432124fc
Unify strategy spelling ( #2345 )
...
* Update abapEnvironmentPipelineStageCloneRepositories.groovy
* Adapt test
2020-11-10 16:45:16 +01:00
Kevin Stiehl
9df9ec8ca4
(kubernetesDeploy) allow to keep a failed deployment ( #2338 )
...
* new 'keepFailedDeployments' parameter which removes the --atomic flag
* Update resources/metadata/kubernetesdeploy.yaml
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
* go generate
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-10 15:43:19 +01:00
Fabian Reh
12d61bc287
Marks tests as parallizable ( #2343 )
...
* Makes tests properly parallelized
* Makes tests properly parallelized
2020-11-10 15:22:03 +01:00
Fabian Reh
3451e07532
Enhance development documentation regarding parallel testing ( #2336 )
...
* Adds section about parallelized testing
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-10 14:28:01 +01:00
Stephan Aßmus
87e8d5d160
Extend the legacy config check for "required" config keys ( #2332 )
2020-11-10 14:18:37 +01:00
Marcus Holl
76fddec4c0
introduce tmsUpload to stageDefaults ( #2321 )
...
Without that the release stage does not perform tms uploads
2020-11-10 10:00:44 +01:00
Christopher Fenner
b71825fac9
feat(pipeline): add sonar step to PR and Build stage ( #1651 )
...
* add sonar scan to build stage
* add sonar scan to PR stage
* add step activation condition
* adjust whitespaces
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-10 09:18:14 +01:00
Stephan Aßmus
eff38f6c9d
whitesourcExecuteScan-go: Additional fixes ( #2315 )
...
* Make sure the UA scan is known to the scan object. Fixes downloading reports later on.
* Move polling into pkg/whitesource, add test for e2e scan
* Remove conditions from stash config resource
* Don't use version stored in CPE. This will prevent the versioningModel from being applied.
2020-11-10 09:09:51 +01:00
Fabian Reh
bf39d2aacc
Enable parallel execution with reused mocks ( #2331 )
...
* Enables parallel execution and prevent reuse of file mock
* Fixes warnings
* Makes tests proper parallelized
* Update cmd/mavenExecuteIntegration_test.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-11-10 08:44:52 +01:00
Srinikitha Kondreddy
0234e4908c
Invalidate cache for neo deployments ( #2209 )
...
* Add additional parameters for invalidating cache
* Fetch bearer token
* Fetch x-csrf token
* Add echo for testing
* Add echo
* Add another echo
* Check status
* Debug
* Clean up
* Throw exception
* Code review changes
* Review changes
* Add test
* Fix tests
* Fetch bearer token
* Fetch x-csrf token
* Add echo for testing
* Add echo
* Add another echo
* Check status
* Debug
* Resolve conflicts
* Resolve conflicts
* Code review changes
* Review changes
* fix conflicts
* Fix indent
* Add new parameter to define portal landscape region
* Add default value for new param
* Fix test
* Remove example
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
* Check cache invalidation for html5 apps
* Add nesting
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
* Add docu for invalidating cache for html5 apps (#2306 )
* Add docu for invalidating cache for html5 apps
* Improve content
* Docu review changes
* Remove heading
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
* Update documentation/docs/steps/neoDeploy.md
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
2020-11-09 12:15:00 +01:00
Christopher Fenner
e859ed3375
feat(http): expose tls insecure flag ( #2324 )
...
* expose tls insecure flag
* fix tls disabling
* move debug message
* add test case
2020-11-09 11:47:03 +01:00
Florian Wilhelm
73a2c256cc
Move legacy config check to step so it can be reused in other pipelines ( #2325 )
2020-11-09 10:15:43 +01:00
