Christopher Fenner
8e40a4cf62
Merge branch 'master' into pr/trUploadFileApplicationIdFromConfiguration
2018-08-15 09:59:25 +02:00
Marcus Holl
45f4952c71
Read applicationId also from configuration
2018-08-15 09:48:59 +02:00
Marcus Holl
bfb131407d
Merge remote-tracking branch 'github/master' into HEAD
2018-08-14 12:13:30 +02:00
Christopher Fenner
c538e896f3
Merge branch 'master' into CCFenner/newman
2018-08-09 14:25:22 +02:00
Oliver Nocon
71f7f05427
add telemetry reporting to steps ( #243 )
...
add telemetry to all steps using ConfigurationHelper.
Other steps need to be switched to ConfigurationHelper first.
update docs
2018-08-09 11:35:33 +02:00
Thorsten Willenbacher
9dfc7fcd01
refactor withCredentials to ChangeManagement util class
...
fix tests to match refactoring
2018-08-09 11:03:30 +02:00
Christopher Fenner
059268459a
Merge branch 'master' into CCFenner/newman
2018-08-09 10:34:00 +02:00
Oliver Nocon
65b582dc9d
artifactSetVersion - add new artifact types & cleanup ( #242 )
...
* artifactSetVersion - add new artifact types & cleanup
added:
* dlang
* golang
* npm
* pip
* scala
* add documentation update
2018-08-08 22:21:26 +02:00
Christopher Fenner
240df88882
add stashing & private test repositories
2018-08-08 11:22:08 +02:00
Marcus Holl
3d78affc3b
Merge branch 'master' into pr/transportRequestUploadFilewithMtarFileFromCPE
2018-08-03 08:49:05 +02:00
Christopher Fenner
2c2700f10a
Merge branch 'master' into CCFenner-patch-2
2018-08-01 08:54:45 +02:00
Christopher Fenner
30f0c5a6cc
correct test cases
2018-08-01 08:50:21 +02:00
Christopher Fenner
0db93df011
fix closure
2018-08-01 08:41:49 +02:00
Christopher Fenner
8c7dc44d1d
add tests
2018-08-01 08:30:10 +02:00
Marcus Holl
0bac7ac27e
Take mtarFilePath in commonPipelineEnviroment into account
...
This allows the steps to interact without using return values (which is not possible in
declarative pipelines). On the other hand we have depencencies between the steps based
on the status of the commonPipelineEnvironment.
2018-07-31 16:55:15 +02:00
Marcus Holl
f2e0e81802
Merge branch 'master' into fix/rolebackNeoDeployChange
2018-07-31 16:41:36 +02:00
Oliver Nocon
d844b23b90
add cloudFoundryDeploy step ( #173 )
...
* add cloudFoundryDeploy step
* added cf-cli docker image
* support existing parameters
* support check script with flexible STATUS_CODE
* add mandatory parameters
* fix compatibility handling
* address PR feedback
* fix access to smokeTest script
* make credentialsId mandatory to avoid NPE
2018-07-30 09:28:24 +02:00
Marcus Holl
d49a9ad68c
Revert "remove the tool descriptor from neo deploy"
...
This reverts commit c3c7d8b142
.
2018-07-27 14:09:08 +02:00
Florian Wilhelm
0a86c8534d
Improve check for batch mode in mavenExecute ( #226 )
...
The old naive check fails if an argument starts with '-B'. Now we use a
regular expression, which should correctly match if batch mode was
already supplied, and add it if not.
2018-07-26 16:03:05 +02:00
rodibrin
9e547cd605
Merge branch 'master' into pr/neoimage
2018-07-26 10:04:20 +02:00
Roland Stengel
c3c7d8b142
remove the tool descriptor from neo deploy
2018-07-25 15:23:56 +02:00
Marcus Holl
f16d5c766b
Merge remote-tracking branch 'github/master' into HEAD
2018-07-25 12:26:20 +02:00
Christopher Fenner
aa57127e84
Merge branch 'master' into pr/readNestedProperties
2018-07-25 09:49:33 +02:00
Marcus Holl
411fd7fe62
Access to nested properties
...
yaml configuration supports nested properties. With this change
we can read those nested properties.
2018-07-25 09:47:16 +02:00
Marcus Holl
2a851abdfd
Merge remote-tracking branch 'github/master' into HEAD
2018-07-23 09:41:02 +02:00
Marcus Holl
b65a5d5699
Release transport request: decouple tests
...
Focus on only one class under test, not having the step and the util class under
test at once.
2018-07-23 09:39:40 +02:00
Marcus Holl
43a9dcbcfd
Do not fail immediatly in case commit history does not contain a changeDocumentId
...
we emit a log message and fail later at withManadotoryProperty check.
2018-07-19 10:26:34 +02:00
Marcus Holl
1e0fa0799e
[fix] Remove early check for mandatory param 'changeDocumentId'
...
otherwise we will never try to read the change document id from commit history.
2018-07-19 10:09:24 +02:00
Marcus Holl
46f6587a97
Merge remote-tracking branch 'github/master' into HEAD
2018-07-19 09:17:07 +02:00
Marcus Holl
3effe404b0
Merge remote-tracking branch 'github/master' into HEAD
2018-07-19 08:54:57 +02:00
Marcus Holl
0678019efb
Merge remote-tracking branch 'github/master' into HEAD
2018-07-18 12:49:41 +02:00
Marcus Holl
ab0a0c6882
Introduce CredentialsRule
...
Instead of configuring the credentials setup
o withCredentials
o usename
in each of our tests (for the moment change-management related)
we collect the common coding in a JUnitRule.
2018-07-18 12:45:30 +02:00
Marcus Holl
f2bf406dee
Merge remote-tracking branch 'github/master' into HEAD
2018-07-18 12:42:54 +02:00
Marcus Holl
9d9c17d937
Merge remote-tracking branch 'github/master' into HEAD
2018-07-18 12:23:34 +02:00
Marcus Holl
3e3af733f2
Merge remote-tracking branch 'github/master' into pr/fixExceptionMessage
2018-07-18 11:45:48 +02:00
Roland Stengel
4851ba94bf
drop NEO version verification - remove neo version check
2018-07-18 09:46:11 +02:00
Roland Stengel
38360f1d0c
drop NEO version verification - introduce getVersion
2018-07-17 20:56:31 +02:00
Marcus Holl
9b4d55d0d9
switch to nested configuration for change management related steps
2018-07-17 16:41:42 +02:00
Marcus Holl
1e23a9ba3e
Merge remote-tracking branch 'mholl/pr/readNestedProperties' into HEAD
2018-07-17 11:22:23 +02:00
Marcus Holl
4b2ee0d4ad
[fix] Excpetion message contains config key instead of value.
2018-07-17 10:08:47 +02:00
Marcus Holl
4f8f7be6aa
Access to nested properties
...
yaml configuration supports nested properties. With this change
we can read those nested properties.
2018-07-16 17:26:22 +02:00
Marcus Holl
83e757475a
Merge remote-tracking branch 'github/master' into HEAD
2018-07-16 12:09:49 +02:00
Marcus Holl
b72cb656d5
Merge remote-tracking branch 'github/master' into HEAD
2018-07-16 11:15:22 +02:00
Marcus Holl
7482b58dc2
UploadFileToTransport: Read transportRequestId from commit history
2018-07-16 10:28:59 +02:00
Marcus Holl
bb0e9b92ce
transport request upload file: decouple tests.
2018-07-13 16:09:51 +02:00
Marcus Holl
0337b34cef
[whitespace only] increase readability
2018-07-13 14:40:54 +02:00
Marcus Holl
254a4e2017
Remove unused sh registerAllowedMethod
...
registerAllowedMethod for sh call not used anymore since we mock the ChangeManagement utils class.
The sh calls was triggered from the utils class. Since we mock that class, there is no sh call
anymore.
2018-07-13 13:23:10 +02:00
Marcus Holl
63b0fd6f67
Merge remote-tracking branch 'github/master' into HEAD
2018-07-13 10:30:29 +02:00
Marcus Holl
b73df0f682
ReleaseTransportRequest: Read transportRequestId from commit history
2018-07-12 16:00:27 +02:00
Marcus Holl
8d60a81ec5
Read transportId from commit history: split getChangeID method
2018-07-12 14:17:33 +02:00
Marcus Holl
c9572d187b
Merge remote-tracking branch 'github/master' into HEAD
2018-07-12 13:23:00 +02:00
Marcus Holl
52052cc99d
Merge pull request #196 from marcusholl/transportRequestCreateChangeDocumentIdFromCommitHistory
...
transportRequestCreate: retrieve changeDocumentId from commit history
2018-07-12 13:14:34 +02:00
Marcus Holl
3cb8912456
Merge pull request #180 from marcusholl/pr/supportCmClientOptsUploadFileToTransport
...
Support CM clientOpts for uploadFileToTransport
2018-07-12 10:16:07 +02:00
Marcus Holl
52bb1e842d
Validate required parameters via config helper
...
- In case a parameter is missing we do not thrown and AbortException
anmore, but an IllegalArgumentExcpetion, since that exception is
thrown by the configuration helper. The difference is: AbortExceptions
are contained in the log without stacktrace, other exceptions are
printed with stack trace.
- Exception messages are changed to the standard error message triggered
inside the configuration helper. In case the changeDocumentId is
retrieved also from the commit history we keep an exception message
pointing to that.
- Having references to the parameters is droped. Instead the parameters
are directly used from the configuration map.
- in case of long signatures line breaks are inserted in order to
simplify reading the code.
2018-07-12 09:34:06 +02:00
Christopher Fenner
1423522e2f
Merge pull request #201 from marcusholl/pr/fixQuotationMark
...
[fix] misplaced quotation mark in assertion message
2018-07-12 09:21:30 +02:00
rodibrin
4cb5ba5f3f
Merge pull request #194 from rodibrin/pr/newmanexecutetest
...
adapt the NewmanExecuteTest to windows file system
2018-07-12 08:56:28 +02:00
Marcus Holl
c1927da33f
[fix] misplaced quotation mark in assertion message
2018-07-12 08:12:32 +02:00
Marcus Holl
239e8cc054
Merge pull request #199 from marcusholl/pr/supportAssertOfLogMessageInCaseOfFailures
...
Support check for log messages in case of exceptions in code under test
2018-07-11 12:29:21 +02:00
Christopher Fenner
aa865f145f
Merge pull request #172 from SAP/CCFenner/mtaVersioning
...
add versioning for MTAs
2018-07-11 11:53:20 +02:00
Marcus Holl
111802cfd2
Support check for log messages in case of exceptions in code under test
...
With the current approach of checking log entries we are not able to
check log entries in case of a failure. But is is important to assert
log messages in case of a failure. Having reasonable log messages
simplified troubleshooting.
Hence we add JenkinsLoggingRule.expect(substring) and check after the
base of that rule has been called.
This interfears with other rules also working with an expect approach,
like e.g. ExpectedException. Which violation is presented depends on
the order or the rules around the test case.
2018-07-10 17:34:58 +02:00
Marcus Holl
cada0e7882
transportRequestCreate: retrieve changeDocumentId from commit history
2018-07-10 16:41:43 +02:00
Marcus Holl
a7ea15ac58
transportRequestUploadFile: retrieveChangeDocumentId from commit history
2018-07-10 16:40:26 +02:00
Marcus Holl
4a9c0695ca
transportRequestRelease: get changeDocumentId from commit history
2018-07-10 16:34:42 +02:00
Roland Stengel
81c0110740
adapt the NewmanExecuteTest to windows file system
2018-07-10 13:10:16 +02:00
Marcus Holl
5e09e2fb88
No forwarding of config map in to ChangeManagement class.
2018-07-10 12:30:31 +02:00
Marcus Holl
bb2ed27c10
Switch from gitLabel to gitChangeDocumentLabel
...
since we will have two labels in future. One for scanning changeDocumentIds and
another one for scanning transportRequestIds
2018-07-10 11:15:09 +02:00
Marcus Holl
71ca78e0a9
Switch from git_xxx to gitXxx like properties
2018-07-10 11:14:43 +02:00
Marcus Holl
74b6ac0c8e
Support cmclient_opts in transportRequestCreate
2018-07-09 15:41:13 +02:00
Marcus Holl
d8d2249862
Support cmclientOpts for uploadFileToTransport
2018-07-09 09:40:07 +02:00
Marcus Holl
6829319ca5
Remove wrong package declaration and stange grovvy shebang
...
o we are in the default package, hence package 'steps' is inappropriate
o there is also no grovvy shebang in other test files, why should it be here?
2018-07-06 13:37:20 +02:00
Marcus Holl
44cee0475d
Merge pull request #176 from marcusholl/pr/decoupleTests
...
Pr/decouple tests
2018-07-06 13:09:44 +02:00
Marcus Holl
cf09b45025
Merge pull request #161 from marcusholl/marcusholl/pr/landscapeConfigLayer
...
Provide configuration layer for custom configuration
2018-07-06 12:47:52 +02:00
Christopher Fenner
96b2880ea0
Merge pull request #186 from SAP/CCFenner/newmanExecute
...
add step for Newman test execution
2018-07-06 10:27:55 +02:00
Marcus Holl
20612c726f
Add tests asserting log messages
2018-07-04 11:56:53 +02:00
Marcus Holl
99c6012f4a
Merge pull request #177 from marcusholl/pr/customMessageForWithMandatoryParameter
...
withMandatoryParameter supports a error message from the caller
2018-07-04 11:42:52 +02:00
Christopher Fenner
cd891acc97
remove println
2018-07-04 11:13:41 +02:00
Marcus Holl
22b6dd63f6
Merge custom defaults with library defaults.
2018-07-03 17:01:22 +02:00
Marcus Holl
c29fb02dd9
wip
2018-07-03 17:01:22 +02:00
Christopher Fenner
232705f58c
add tests
2018-07-03 14:39:20 +02:00
Christopher Fenner
12cf07a73d
align used node images
2018-07-03 14:22:22 +02:00
Roland Stengel
b00a8c203a
restore tracked methods on afterTestMethod
2018-07-02 14:03:41 +02:00
Marcus Holl
aa900d7dcf
withMandatoryParameter supports a error message from the caller
2018-06-29 11:15:37 +02:00
Marcus Holl
d270a2d232
Decouple tests: transport request upload file
2018-06-29 10:53:47 +02:00
Marcus Holl
5a73af4c02
Decouple tests: transport request create
2018-06-29 10:15:20 +02:00
Alejandra Ferreiro Vidal
cc9332ae79
Merge pull request #175 from alejandraferreirovidal/changeParameters
...
change credentialsId and endpoint
2018-06-29 10:12:58 +02:00
Marcus Holl
3766bf4794
Merge pull request #166 from marcusholl/cm
...
isChangeInDevelopment
2018-06-29 08:25:15 +02:00
Marcus Holl
1a815c32cd
Merge pull request #165 from marcusholl/pr/scriptCallRuleWithRegex
...
Return a return value based on a regex comparism
2018-06-29 08:24:37 +02:00
Alejandra Ferreiro Vidal
ab8a1bb837
change credentialsId and endpoint
2018-06-28 16:24:14 +02:00
Marcus Holl
1493393805
Improve log message in case a call to cmclient for getting change status fails.
2018-06-28 15:37:14 +02:00
Marcus Holl
bdef708522
Assert logging
2018-06-28 15:37:14 +02:00
Marcus Holl
6d943d2005
Support CMCLIENT_OPTS
...
needed e.g. for providing a trust store.
2018-06-28 15:37:13 +02:00
Marcus Holl
5d0ffa3e69
Make use of unified cmCommandLine
2018-06-28 15:37:13 +02:00
Marcus Holl
38c6d35adb
Introde getCMCommandLine
2018-06-28 15:37:13 +02:00
Marcus Holl
9d0eb79d94
filter null values from changeId array.
2018-06-28 15:37:13 +02:00
Marcus Holl
c494e33c1d
Tests for isChangeInDevelopment
2018-06-28 15:37:13 +02:00
Marcus Holl
37ba20d060
more tests
2018-06-28 15:37:13 +02:00
Marcus Holl
00304d67db
[refactoring] getting the gitUtils mock
2018-06-28 15:37:12 +02:00
Marcus Holl
cdb26e6b91
Introduce test for pipeline step checkChangeInDevelopment
2018-06-28 15:37:12 +02:00
Marcus Holl
9adad5ba37
Get changeDocumentId from git commits.
2018-06-28 15:37:12 +02:00
Marcus Holl
d8dca885bb
Change parameter name 'changeId' to 'changeDocumentId'
...
the official term in SAP-SolutionManager is 'change document'.
The term 'change' as reflected in 'changeId' is ambigous and could also be understand in the
sense of a change in a revision control system.
Choosing appropriate terms for parameters here deceases the amount of documentation
required for explaining what is really denoted by the parameter.
2018-06-28 13:46:00 +02:00