1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Commit Graph

758 Commits

Author SHA1 Message Date
Marcus Holl
52bb1e842d Validate required parameters via config helper
- In case a parameter is missing we do not thrown and AbortException
    anmore, but an IllegalArgumentExcpetion, since that exception is
    thrown by the configuration helper. The difference is: AbortExceptions
    are contained in the log without stacktrace, other exceptions are
    printed with stack trace.
  - Exception messages are changed to the standard error message triggered
    inside the configuration helper. In case the changeDocumentId is
    retrieved also from the commit history we keep an exception message
    pointing to that.
  - Having references to the parameters is droped. Instead the parameters
    are directly used from the configuration map.
  - in case of long signatures line breaks are inserted in order to
    simplify reading the code.
2018-07-12 09:34:06 +02:00
Christopher Fenner
1423522e2f
Merge pull request #201 from marcusholl/pr/fixQuotationMark
[fix] misplaced quotation mark in assertion message
2018-07-12 09:21:30 +02:00
rodibrin
4cb5ba5f3f
Merge pull request #194 from rodibrin/pr/newmanexecutetest
adapt the NewmanExecuteTest to windows file system
2018-07-12 08:56:28 +02:00
Marcus Holl
c1927da33f [fix] misplaced quotation mark in assertion message 2018-07-12 08:12:32 +02:00
Marcus Holl
239e8cc054
Merge pull request #199 from marcusholl/pr/supportAssertOfLogMessageInCaseOfFailures
Support check for log messages in case of exceptions in code under test
2018-07-11 12:29:21 +02:00
Marcus Holl
d3dde491f6
Merge pull request #181 from marcusholl/pr/streamlineScript
Streamline and fix usage of script
2018-07-11 12:28:26 +02:00
Marcus Holl
c978d02532 Make use of decent helper function of configuration helper 2018-07-11 11:55:19 +02:00
Marcus Holl
3ddac5633d Introduce dedicated variable for script 2018-07-11 11:55:19 +02:00
Christopher Fenner
aa865f145f
Merge pull request #172 from SAP/CCFenner/mtaVersioning
add versioning for MTAs
2018-07-11 11:53:20 +02:00
Marcus Holl
a4f62e6f6e
Merge pull request #182 from marcusholl/pr/supportCmClientOptsForReleaseTransport
Support cmClientOpts for releasing a transport
2018-07-11 11:50:34 +02:00
Marcus Holl
111802cfd2 Support check for log messages in case of exceptions in code under test
With the current approach of checking log entries we are not able to
check log entries in case of a failure. But is is important to assert
log messages in case of a failure. Having reasonable log messages
simplified troubleshooting.

Hence we add JenkinsLoggingRule.expect(substring) and check after the
base of that rule has been called.

This interfears with other rules also working with an expect approach,
like e.g. ExpectedException. Which violation is presented depends on
the order or the rules around the test case.
2018-07-10 17:34:58 +02:00
Marcus Holl
cada0e7882 transportRequestCreate: retrieve changeDocumentId from commit history 2018-07-10 16:41:43 +02:00
Marcus Holl
a7ea15ac58 transportRequestUploadFile: retrieveChangeDocumentId from commit history 2018-07-10 16:40:26 +02:00
Marcus Holl
4a9c0695ca transportRequestRelease: get changeDocumentId from commit history 2018-07-10 16:34:42 +02:00
Marcus Holl
4a92f65e66
Merge pull request #195 from marcusholl/pr/noConfigInChangeManagmentUtils
No forwarding of config map in to ChangeManagement class.
2018-07-10 14:07:48 +02:00
Roland Stengel
4d726d6c5f Merge branch 'pr/newmanexecutetest' of github.com:rodibrin/jenkins-library into pr/newmanexecutetest 2018-07-10 13:13:54 +02:00
Roland Stengel
81c0110740 adapt the NewmanExecuteTest to windows file system 2018-07-10 13:10:16 +02:00
Marcus Holl
5e09e2fb88 No forwarding of config map in to ChangeManagement class. 2018-07-10 12:30:31 +02:00
Marcus Holl
87c61ae7fb
Merge pull request #193 from marcusholl/pr/gitFormat
Add missing docu for parameter gitFormat
2018-07-10 12:13:01 +02:00
Roland Stengel
f32c9f495d adapt the NewmanExecuteTest to windows file system 2018-07-10 12:02:58 +02:00
Marcus Holl
67b2d34b5c Add missing docu for parameter gitFormat 2018-07-10 11:27:19 +02:00
Marcus Holl
0ccabb7c40
Merge pull request #192 from marcusholl/pr/CamelCaseInsteadUnderscore
camel case instead underscore
2018-07-10 11:20:44 +02:00
Marcus Holl
bb2ed27c10 Switch from gitLabel to gitChangeDocumentLabel
since we will have two labels in future. One for scanning changeDocumentIds and
another one for scanning transportRequestIds
2018-07-10 11:15:09 +02:00
Marcus Holl
71ca78e0a9 Switch from git_xxx to gitXxx like properties 2018-07-10 11:14:43 +02:00
Marcus Holl
568008efb8
Merge pull request #179 from marcusholl/pr/supportCmClientOps
Support CM clientOpts in transportRequestCreate
2018-07-10 10:18:35 +02:00
Marcus Holl
839afa9f9f
Merge pull request #178 from marcusholl/pr/addCredentialIdConfigForCreateTransport
Add default config for transport related steps
2018-07-10 10:09:40 +02:00
Marcus Holl
6d78a9c6a3 Support cmClientOpts for releasing a transport 2018-07-09 16:02:08 +02:00
Marcus Holl
74b6ac0c8e Support cmclient_opts in transportRequestCreate 2018-07-09 15:41:13 +02:00
Marcus Holl
a63cb59ceb Add default config for credentialsId 2018-07-09 14:58:50 +02:00
Marcus Holl
8c4c76dd05
Merge pull request #191 from marcusholl/pr/exceptionChaining
Pr/exception chaining
2018-07-09 13:54:26 +02:00
Marcus Holl
8e63e45133 Support exception chaining in ChangeMangementException 2018-07-09 13:43:52 +02:00
Marcus Holl
1d51641cce fix whitespaces 2018-07-09 13:43:00 +02:00
Marcus Holl
d8d2249862 Support cmclientOpts for uploadFileToTransport 2018-07-09 09:40:07 +02:00
Christopher Fenner
875d221cc3
Merge pull request #190 from marcusholl/pr/wrongPackageDeclaration
Remove wrong package declaration and stange grovvy shebang
2018-07-06 13:52:58 +02:00
Marcus Holl
6829319ca5 Remove wrong package declaration and stange grovvy shebang
o we are in the default package, hence package 'steps' is inappropriate
o there is also no grovvy shebang in other test files, why should it be here?
2018-07-06 13:37:20 +02:00
Marcus Holl
44cee0475d
Merge pull request #176 from marcusholl/pr/decoupleTests
Pr/decouple tests
2018-07-06 13:09:44 +02:00
Marcus Holl
cf09b45025
Merge pull request #161 from marcusholl/marcusholl/pr/landscapeConfigLayer
Provide configuration layer for custom configuration
2018-07-06 12:47:52 +02:00
Christopher Fenner
96b2880ea0
Merge pull request #186 from SAP/CCFenner/newmanExecute
add step for Newman test execution
2018-07-06 10:27:55 +02:00
Christopher Fenner
d2e023f512
Update newmanExecute.groovy 2018-07-04 15:01:12 +02:00
Marcus Holl
20612c726f Add tests asserting log messages 2018-07-04 11:56:53 +02:00
Marcus Holl
99c6012f4a
Merge pull request #177 from marcusholl/pr/customMessageForWithMandatoryParameter
withMandatoryParameter supports a error message from the caller
2018-07-04 11:42:52 +02:00
Christopher Fenner
cd891acc97
remove println 2018-07-04 11:13:41 +02:00
Christopher Fenner
af753d3c54
build new config on the fly 2018-07-04 11:12:32 +02:00
Christopher Fenner
0d5e49e9d4 fix echo 2018-07-03 17:01:22 +02:00
Christopher Fenner
2f0dce1a5e Update prepareDefaultValues.groovy 2018-07-03 17:01:22 +02:00
Marcus Holl
22b6dd63f6 Merge custom defaults with library defaults. 2018-07-03 17:01:22 +02:00
Marcus Holl
c29fb02dd9 wip 2018-07-03 17:01:22 +02:00
Christopher Fenner
7ce0c85fe9 only merge lists 2018-07-03 17:01:22 +02:00
Christopher Fenner
e70c40bdfc revert changes 2018-07-03 17:01:22 +02:00
Christopher Fenner
3ebe599f52 merge custom default configuration 2018-07-03 17:01:22 +02:00