Marcus Holl
a1823aeb98
checksPublishResults: prepare reports only if the reporting is active ( #2971 )
...
* checksPublishResults: prepare reports only if the reporting is active
* test
* remove un-used import
* dummy in order to trigger checks
2021-07-12 10:02:09 +02:00
Oliver Nocon
006aaab50d
fix(handlePipelineStepError): correct handling of failed steps ( #2498 )
...
* WIP: debug incorrect error message
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update commonPipelineEnvironment.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update commonPipelineEnvironment.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update vars/piperExecuteBin.groovy
* Update vars/handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Apply suggestions from code review
* correct test case
* change test case
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Christopher Fenner <Christopher.Fenner@sap.com>
2021-01-11 10:49:33 +01:00
Christopher Fenner
eff1933a61
refactor(checks): use warnings-ng plugin ( #2398 )
...
* use recordIssues
* fix c&p issue
* simplify code
* fix
* add quality gates
* change qgates to TOTAL_HIGH
* remove pattern for tasks
* use TOTAL_ERROR for checkstyle
* fix indent
* use deprecated threshold parameters
* debug messages
* transform legacy qgates
* fix
* adjust test cases
* correct qgates
* correct legacy thresholds
* fix typo
* remove deprecated defaults
* add test case
* log use tool
* add notification
* remove deprecated defaults
* remove deprecated parameter
* adjust legacy threshold message
* add q gates on error and high for all check tools
* Apply suggestions from code review
* adjust test cases
* remove duplicate assert
* Fail if aggregation is still defined
* update docs
* fix indent
* Update documentation/docs/steps/checksPublishResults.md
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-25 15:39:33 +01:00
Marcus Holl
fd568c9174
do not swallow exception triggered inside SWA handling ( #1839 )
...
* do not swallow exception triggered inside SWA handling
--> write it to the log
The real change is in src/com/sap/piper/Utils.groovy
All the changes in the tests are dealing with mocking the echo method
used in the Utils class mentioned above.
2020-09-24 13:47:20 +02:00
Marcus Holl
d0d4b37b24
Revert "ConfigurationLoader, ConfigurationHelper working without script reference"
...
This reverts commit 9962060254
2019-11-26 10:51:32 +01:00
Marcus Holl
74365f7419
Remove unused import
2019-11-12 15:49:02 +01:00
Marcus Holl
9962060254
ConfigurationLoader, ConfigurationHelper working without script reference
2019-08-08 16:14:29 +02:00
Marcus Holl
b486f32dc1
Better readable rule names: stepRule
2019-01-23 14:54:50 +01:00
Christopher Fenner
10ec0473c1
correct step invokation in tests ( #368 )
...
* correct step invokation in tests
* correct step invokation in tests
* correct step invokation in tests
2018-11-07 11:45:38 +01:00
Marcus Holl
c03a75da9f
Ensure script is mandatory parameter
...
... only in case a step uses the script at all.
2018-10-30 16:24:47 +01:00
Marcus Holl
8a019f5b86
Remove read yaml rule from common rules
...
read yaml rule is a very frequently used rule. But having the rule in the common rules
means we cannot register text or files to that rule, which makes it less handy to work
with yaml files in the tests.
2018-08-31 10:22:46 +02:00
Oliver Nocon
f8e5733486
speed up tests
...
* use new base class for testing
* initialize jenkins unit test framework only once for all test classes
* minor test cleanups
2018-06-06 11:19:19 +02:00
Christopher Fenner
76fd77f907
Update ChecksPublishResultsTest.groovy
2018-03-02 10:53:46 +01:00
Christopher Fenner
158a60aecc
use new rules
2018-02-28 13:11:09 +01:00
Christopher Fenner
3f5d0c74db
use Integer for step invocation
2018-02-09 12:15:26 +01:00
Christopher Fenner
91e0b3294e
rename test script variable name
2018-02-08 16:38:55 +01:00
Christopher Fenner
c6300f4570
correct handling of parameter maps
2018-02-08 10:50:11 +01:00
Christopher Fenner
ebedbb01e0
add test for default thresholds
2018-02-08 10:43:06 +01:00
Christopher Fenner
02c983e374
remove wrapping RuleChain
2018-02-06 09:53:27 +01:00
Christopher Fenner
8c02b8bc86
mock step configuration change
2018-02-05 16:02:59 +01:00
Christopher Fenner
87de7417ca
add further tests
2018-02-05 13:48:39 +01:00
Christopher Fenner
853bc963c0
add additional test case
2018-02-05 13:33:15 +01:00
Christopher Fenner
bf1a2a98e0
remove debug log
2018-02-02 15:08:22 +01:00
Christopher Fenner
64046b6de2
rename step to checksPublishResults
2018-02-02 14:50:26 +01:00
