Stephan Aßmus
8007a1a6c6
New step gatlingExecuteTests, used in Performance stage ( #2298 )
...
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-11-03 17:42:02 +01:00
Kevin Hudemann
f13ccabe1e
Add preDeploymentHook to multicloudDeploy step ( #2308 )
2020-11-03 16:46:33 +01:00
Peter Persiel
279c8814d9
Review "Build and Publish Add-on Products on SAP Cloud Platform ABAP Environment" ( #2230 )
...
* Update abapEnvironmentAddons.md
Review of scenario documentation Build and Publish Add-on Products on SAP Cloud Platform ABAP Environment
* Fix Trailing spaces [Expected: 0 or 2; Actual: 1]
* Update documentation/docs/scenarios/abapEnvironmentAddons.md
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
* Exclude draft doc link
* pipeline image for ABAP Environment Build scenario
* Update abapEnvironmentAddons.md
* Revert "A Patch delivery contains Patch deliveries"
A Patch delivery contains Patch deliveries of the contained software component versions.
* Revert "Delivery Production Tools"
* Remove 40: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
* Add Limitation software component structure
* Limitation with packages+objects
* Update abapEnvironmentAddons.md
* Change Limitation software component
* Deployment/Delivery Tools explanation
* Adjustsments delivery/deployment tools
* →
* Update abapEnvironmentAddons.md
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Dominik Lendle <59923031+dominiklendle@users.noreply.github.com>
2020-11-03 16:03:25 +01:00
Daniel Mieg
02a5131256
Adapt parameter names ( #2304 )
...
* Adapt parameter names
* add ignore addon option
* change ignore to include
2020-11-03 13:41:39 +01:00
Oliver Feldmann
5b5f1fe873
Remove closure in switch case ( #2302 )
...
Before this commit, if the closure of the switch case is executed a
CpsCallableInvocation exception is thrown.
2020-11-03 12:50:00 +01:00
Daniel Mieg
aa9dd3b199
Add step abapEnvironmentCreateSystem ( #2273 )
...
* Create initial step
* Add parameters for system creation
* Creating a tmp manifest.yml
* Add descriptions
* regenerate
* Create tests
* fix codeclimate issue
* Test
* Test2
* Test3
* Replace os.getTempDir
* Change to fileUtils
* Remove FileUtil
2020-11-03 12:02:13 +01:00
Daniel Kurzynski
7946265e21
Install maven artifacts before running Detect ( #2292 )
2020-11-03 11:08:23 +01:00
Dominik Lendle
c6afd7696b
Abap pipeline extension for cloneGitRepo & checkoutBranch to be used ( #2004 )
...
* Added CFDeleteServiceKeys
* Added ServiceKey deletion tests
* added cfServiceKeys flag explanation to documentation
* removed trailing spaces from documentation
* resolving conflicts
* Changed deletion message an variable naming
* Changed tests
* Changed tests
* Changed tests
* Changed tests
* Changed CloudFoundryDeleteServiceOptions to options
* Changed CloudFoundryDeleteServiceOptions to options
* Minor changes
* Minor changes
* Changed variable naming
* Changed error handling
* Changed error handling and logging
* Changed documentation
* Simplified code
* Fixed CodeClimate issues
* Changed from returning err to nil where no errur returned needed
* Add cloudFoundryCreateServiceKey Go Step
* Changed Groovy File
* Changed aliases
* Removed unneccessary parts
* Minor changes
* Minor changes
* Adapted documentation
* Adapted tests
* Adapted Groovy File
* Changed Groovy file
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed Groovy Tests for cfCreateServiceKey
* Minor changes
* Added ATC Check YAML
* Added ATC Check generated files
* Added test class
* Added abapEnvironmentRunATCCheck
* Minor changes
* Minor changes
* Changed groovy
* Minor changes
* Changed groovy
* Changed groovy
* Minor changes
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy
* Getting ATC results
* Changed error message
* changed groovy
* removed trailing spaces
* Added login check
* Minor changes
* Added step to whitelistScriptReference
* Added ATC error message handling
* Added groovy file
* Added step to groovy tests
* corrected metadata file
* Debugging
* Debugging
* Added yaml config parameter for ATC run
* Adapted file location of ATC run config to jenkins specific location
* Implementing universal pipeline logic for finding yaml config regardless of pipeline
* Changed error handling for reading config yaml file
* Changed atcrunconfig alias
* minor changes
* Minor changes
* Minor changes
* Changed back to dynamic file reading
* Minor changes
* filepath changes
* Removing CF Login
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed whitespaces
* Added CF functions unit tests
* Added invalid parameter handling
* Removed package and SC flag
* Minor changes
* Changed tests
* Changed tests
* Changed tests
* Minor changes
* Changed tests
* removed unnecessary logout
* Added documentation
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaces
* Added newline at end of file
* code climate fixes
* code climate fixes
* code climate fixes
* Minor changes
* Minor changes
* Minor changes
* Changed tests
* Test changes
* Splitted Cloud Foundry functions into two classes
* Removed two steps from whtielistScriptReference
* removed atcrunConfig alias
* issue fixes
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaced from docu
* Changed docu
* Go generator run
* Issue fixes
* Remove unnecessary imports
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update whitelistScript
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Adding piperutils for writing xml file
* Persisting ATC Results with piperutils
* Set failonMissingReports to true
* Refactoring for CodeClimate
* Changed result file name
* Changed credentials aliases
* changing secret name
* Removing trailing spaces
* Added secret name and alias to docu
* Add cloneGitRepo & checkoutBranch steps
* Tests added
* Docu added
* docu changes
* remark changes
* Class name changed
* minor changes
* Test added for prepare system stage
* Review changes
* Tests
* Step order tests
* Step order tests
* Step order tests
* Step order tests
* strategy parameter tests
* configHelper import added
* Default value for strategy added and remove pull config check
* corrected stage default
* Tests added
* changes in TestConfig
* Tests adapted for no prepare system stage
* tests changed
* changed tests
* input added
* changed tests
* changed tests
* changed tests
* commonPipeline removed
* add input register
* remove step key
* remove return
* remove comment
* correct method usage
* CodeClimate Fixes
* PR fixes
* addonBuild rename
* removed trailing spaces
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-03 10:16:57 +01:00
Kevin Stiehl
67727147f8
switch to debug logging for some vault log messages ( #2299 )
2020-11-03 08:45:12 +01:00
Stephan Aßmus
b070d2f4ed
fortifyExecuteScan: fix quoting of default values for "src" ( #2297 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-02 17:21:14 +01:00
Christopher Fenner
8d682abc83
add package for Jenkins interactions ( #2296 )
2020-11-02 17:11:18 +01:00
Christopher Fenner
19e90f04f2
refactor: remove obsolete mandatory:false ( #2191 )
...
* refactor: remove obsolete mandatory:false
* refactor: remove obsolete mandatory:false
2020-11-02 16:42:17 +01:00
Daniel Mieg
7639175def
Add commit to clone and pull ( #2258 )
...
* commit ID for clone
* commit ID for clone
* Remove old default values
* Add commitID to Pull
* Print http response on debug level
* Fix tests
* Adapt tests
* Shorten sleep
* Fix clone tests
* Add ignore commit option
* Adapt tests
* Adapt docu
* Implement feedback
* fix codeclimate issue
2020-11-02 14:17:13 +01:00
Oliver Nocon
edd5ef7709
fix(descriptorUtils) improve error message ( #2294 )
2020-11-02 13:50:04 +01:00
Oliver Nocon
9725b2a9d7
fix(permissions) allow deletion of errors file ( #2293 )
2020-11-02 12:34:28 +01:00
Marcus Holl
c9b50d7f10
Avoid CPS serialization issue in setupCPE ( #2261 )
...
* Avoid CPS serialization issue in setupCPE
When handing over an instance of SCMInfo we got a
CPS serialization issue. Hence we don't hand over
that instance any more
o git commit id is resolved with exising git tooling
o git branch is handed over as parameter to setupCPE
2020-11-02 11:23:34 +01:00
Marcus Holl
073a2a8599
generator: Don't swallow output from go fmt ( #2222 )
...
* generator: Don't swallow output from go fmt
* fix formatting
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-02 10:31:00 +01:00
Kevin Stiehl
ea5e91672d
mask secret also when they are url encoded ( #2289 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-02 10:08:34 +01:00
Kevin Stiehl
ff7204fcdf
fetch github token from vault ( #2290 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-02 09:04:36 +01:00
Oliver Nocon
26cfbf7357
fix(whitesourceExecuteScan) properly handle output resources ( #2266 )
...
* fix(whitesourceExecuteScan) properly handle output resources
* fix merge issues
* add required aliases
* update generation
* fix reading custom and container environment parameters from cpe
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-02 08:51:58 +01:00
Florian Wilhelm
c05479e99e
Unstash "source" for npmExecuteScripts ( #2285 )
2020-10-30 15:33:13 +01:00
Daniel Kurzynski
a2656a5f71
Install artifacts before whitesource scan ( #2280 )
2020-10-30 15:05:14 +01:00
Florian Wilhelm
efa85a0f0e
Allow npm install in e2e tests ( #2281 )
...
Remove hard-coded install: false in npmExecuteScripts call to allow the pipeline to configure the step according to how it is right for that pipeline.
2020-10-30 11:56:29 +01:00
Florian Wilhelm
020ed15f34
Replace deprecated set-env github actions command ( #2264 )
...
cf https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-10-30 10:47:03 +01:00
Daniel Kurzynski
1015371efd
Pass settings file also to install-file ( #2279 )
2020-10-30 10:04:38 +01:00
Kevin Hudemann
546bc7b692
Add default stashes for npmExecuteScripts ( #2271 )
2020-10-30 09:25:26 +01:00
Oliver Nocon
690b27ed48
fix(config) conversion of small ints into string ( #2274 )
...
* fix(config) conversion of small ints into string
* beautify and improve comment
2020-10-30 08:01:30 +01:00
Daniel Kurzynski
6ba8b7968b
Add option to install artifacts before running static code checks ( #2270 )
...
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-10-29 18:58:40 +01:00
Sven Merk
c204abb9cf
checkmarxExecuteScan: Relax timeout ( #2265 )
2020-10-29 18:03:22 +01:00
Stephan Aßmus
582419e2f5
Up for discussion: Embed best practices (?) in generated steps ( #1913 )
...
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-10-29 17:29:07 +01:00
Daniel Kurzynski
6afb0ae507
Pass project settings to flatten command ( #2269 )
2020-10-29 16:33:58 +01:00
Daniel Mieg
c2bd05fb3d
Add option to include a deletion prompt for Steampunk systems ( #2198 )
...
* Test out delete confirmation
* Second try
* Add confirmation for Integration Tests system
* Fix defaults
* Change default
* Adapt text
* Change default handling
* Adapt addIfEmpty
* Add pipeline test
* Add tests
2020-10-29 10:30:50 +01:00
Stephan Aßmus
86f335811c
whitesourceExecuteScan-go: Implement parameters "timeout", "createProductFromPipeline" ( #2246 )
2020-10-29 09:21:01 +01:00
Daniel Kurzynski
f5df553dae
Change defaultimage for npmExecuteLint ( #2262 )
2020-10-28 18:07:40 +01:00
Stephan Aßmus
d1fedd9ba8
Remove "onlyInProductiveBranch" check ( #2253 )
2020-10-28 17:08:38 +01:00
Srinikitha Kondreddy
43f15d4524
Fix typos ( #2260 )
2020-10-28 13:47:50 +01:00
Florian Wilhelm
99155de455
Bump mta builder default image to 1.0.16.1 ( #2252 )
...
The old image still configures the not used anymore registry npm.sap.com. Update to get rid of that.
2020-10-28 09:58:36 +01:00
Oliver Nocon
a8c154d275
Update Fortify Documentation ( #2250 )
2020-10-27 16:55:31 +01:00
Oliver Nocon
e5f1f16738
fix(config) fail on incorrect conversions ( #2239 )
...
* fix(config) fail for incorrect conversions
* update error handling
* add comment
2020-10-27 15:14:00 +01:00
Stephan Aßmus
2f83ba56da
Make sure detect.sh is removed after use ( #2238 )
...
Should avoid issues with this file being owned by root (perhaps via running in docker container), preventing the workspace from being cleaned properly.
2020-10-27 14:29:22 +01:00
Fabian Reh
9c870b2514
Gitops update deployment fixes ( #2234 )
...
* makes containerImage not mandatory
* Adds kubectl container
* Adds log statement to debug
* adds general to container image
* removes GENERAL again
Removes condition from Kubectl container
* removes workDir
* marks logs as debug
* adds workingdir again
* Adds author to commits
* Adds commit time now
* remove deprecated and reorder
* adds deprecated again to containerRegistryUrl
Adds GENERAL scope to containerImage
* updates generated file
* Renames containerImageNameTag
* adds else case
* adds debug log
* code cleanup
* adds debug log
* revert
* adds debug logs
* revert
* makes root path not hidden
* revert
* Read container properties
* Removes debug message
* Removes debug message
* Removes general scope again
* Fixes unit test
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-27 13:45:34 +01:00
Sven Merk
9d737575aa
fortifyExecuteScan: Fix report download ( #2244 )
...
* Fix report download
* Update fortifyExecuteScan.go
* Update fortifyExecuteScan_test.go
* Update fortify.go
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-27 13:12:31 +01:00
Oliver Nocon
d0f987c7b5
fortifyExecuteScan: increase timeout ( #2240 )
...
fixes #2183
2020-10-27 11:11:53 +01:00
Srinikitha Kondreddy
e0c09992ce
Read properties from plain text ( #2228 )
...
* Read properties from plain text
* Adapt changes
* Support for properties provided as text (#2241 )
* Fix indent and clean up exceptions
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2020-10-27 10:52:24 +01:00
Dominik Lendle
514f4ca897
Check variant fix ( #2220 )
...
* minor changes
* minor changes
* Changed yaml with aliases
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* minor changes
* Changed yaml aliases
* Adapted naming conventions
* Removed error code at the end
* Adapted configuration
* Minor changes
* Minor changes
* Minor changes
* Removed spaces
* Removed docker-related config from groovy file
* Minor changes
* Minor changes
* Removed container config
* Corrected testing function name
* Deleted unnecessary parts
* Changed service deletion message
* Changed service deletion message
* Logging out before throwing error service deletion step fails
* Minor changes
* Minor changes
* Minor changes
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Delete .DS_Store
* Minor changes
* Minor changes
* Minor changes
* Added newline at end of file
* Added newline at end of file
* Changes for Pull request optimization
* added documentaion
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Adapted documentation
* Added CFDeleteServiceKeys
* Added ServiceKey deletion tests
* added cfServiceKeys flag explanation to documentation
* removed trailing spaces from documentation
* resolving conflicts
* Changed deletion message an variable naming
* Changed tests
* Changed tests
* Changed tests
* Changed tests
* Changed CloudFoundryDeleteServiceOptions to options
* Changed CloudFoundryDeleteServiceOptions to options
* Minor changes
* Minor changes
* Changed variable naming
* Changed error handling
* Changed error handling and logging
* Changed documentation
* Simplified code
* Fixed CodeClimate issues
* Changed from returning err to nil where no errur returned needed
* Add cloudFoundryCreateServiceKey Go Step
* Changed Groovy File
* Changed aliases
* Removed unneccessary parts
* Minor changes
* Minor changes
* Adapted documentation
* Adapted tests
* Adapted Groovy File
* Changed Groovy file
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed Groovy Tests for cfCreateServiceKey
* Minor changes
* Added ATC Check YAML
* Added ATC Check generated files
* Added test class
* Added abapEnvironmentRunATCCheck
* Minor changes
* Minor changes
* Changed groovy
* Minor changes
* Changed groovy
* Changed groovy
* Minor changes
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy
* Getting ATC results
* Changed error message
* changed groovy
* removed trailing spaces
* Added login check
* Minor changes
* Added step to whitelistScriptReference
* Added ATC error message handling
* Added groovy file
* Added step to groovy tests
* corrected metadata file
* Debugging
* Debugging
* Added yaml config parameter for ATC run
* Adapted file location of ATC run config to jenkins specific location
* Implementing universal pipeline logic for finding yaml config regardless of pipeline
* Changed error handling for reading config yaml file
* Changed atcrunconfig alias
* minor changes
* Minor changes
* Minor changes
* Changed back to dynamic file reading
* Minor changes
* filepath changes
* Removing CF Login
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed whitespaces
* Added CF functions unit tests
* Added invalid parameter handling
* Removed package and SC flag
* Minor changes
* Changed tests
* Changed tests
* Changed tests
* Minor changes
* Changed tests
* removed unnecessary logout
* Added documentation
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaces
* Added newline at end of file
* code climate fixes
* code climate fixes
* code climate fixes
* Minor changes
* Minor changes
* Minor changes
* Changed tests
* Test changes
* Splitted Cloud Foundry functions into two classes
* Removed two steps from whtielistScriptReference
* removed atcrunConfig alias
* issue fixes
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaced from docu
* Changed docu
* Go generator run
* Issue fixes
* Remove unnecessary imports
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update whitelistScript
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Adding piperutils for writing xml file
* Persisting ATC Results with piperutils
* Set failonMissingReports to true
* Refactoring for CodeClimate
* Changed result file name
* Changed credentials aliases
* changing secret name
* Removing trailing spaces
* Added secret name and alias to docu
* CheckVariant name changed for xml body + tests adapted
* Removing duplicate
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-10-27 09:56:00 +01:00
Daniel Kurzynski
63756dc81c
Fix cloudFoundryDeploy documentation ( #2236 )
...
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-10-26 16:59:51 +01:00
Kevin Stiehl
72dd34d910
rename versioning credential to "gitHttpsCredential" ( #2185 )
...
* rename versioning credential to "gitHttpsCredential"
* renmae secret to gitHttpsCredential
Co-authored-by: lndrschlz <leander.schulz01@sap.com>
2020-10-26 15:55:37 +01:00
Kevin Stiehl
24aafb0b69
add vaultSecretFileReferences ( #2203 )
...
* add vaultSecretFileReferences
* fix test
* fix test
* go generate
* remove code duplication
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-10-26 14:20:04 +01:00
Florian Wilhelm
5eca4c307a
Update spotbugs-maven-plugin to 4.1.4 ( #2227 )
2020-10-23 15:43:34 +02:00
Christopher Fenner
bdfe90ed49
feat(hadolint): enable authentication when fetching config file ( #2225 )
...
* use httpRequest to fetch config file
* set default
* provide authentication for config url
* adjust test case
2020-10-23 13:57:22 +02:00
