mirror of
https://github.com/SAP/jenkins-library.git
synced 2024-12-14 11:03:09 +02:00
0f4e30e9db
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
70 lines
2.0 KiB
Go
70 lines
2.0 KiB
Go
package cmd
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/SAP/jenkins-library/pkg/mock"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type apiProxyDownloadMockUtils struct {
|
|
*mock.ExecMockRunner
|
|
*mock.FilesMock
|
|
}
|
|
|
|
func TestRunApiProxyDownload(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("Successfull Download of API Proxy", func(t *testing.T) {
|
|
tempDir := t.TempDir()
|
|
apiServiceKey := `{
|
|
"oauth": {
|
|
"url": "https://demo",
|
|
"clientid": "demouser",
|
|
"clientsecret": "******",
|
|
"tokenurl": "https://demo/oauth/token"
|
|
}
|
|
}`
|
|
config := apiProxyDownloadOptions{
|
|
APIServiceKey: apiServiceKey,
|
|
APIProxyName: "flow1",
|
|
DownloadPath: tempDir,
|
|
}
|
|
httpClient := httpMockCpis{CPIFunction: "APIProxyDownload", ResponseBody: ``, TestType: "PositiveAndGetetIntegrationArtifactDownloadResBody"}
|
|
err := runApiProxyDownload(&config, nil, &httpClient)
|
|
absolutePath := filepath.Join(tempDir, "flow1.zip")
|
|
if assert.NoError(t, err) {
|
|
t.Run("check file", func(t *testing.T) {
|
|
assert.Equal(t, fileExists(absolutePath), true)
|
|
})
|
|
t.Run("check url", func(t *testing.T) {
|
|
assert.Equal(t, "https://demo/apiportal/api/1.0/Transport.svc/APIProxies?name=flow1", httpClient.URL)
|
|
})
|
|
|
|
t.Run("check method", func(t *testing.T) {
|
|
assert.Equal(t, "GET", httpClient.Method)
|
|
})
|
|
}
|
|
})
|
|
|
|
t.Run("Failed case of api proxy artifact Download", func(t *testing.T) {
|
|
apiServiceKey := `{
|
|
"oauth": {
|
|
"url": "https://demo",
|
|
"clientid": "demouser",
|
|
"clientsecret": "******",
|
|
"tokenurl": "https://demo/oauth/token"
|
|
}
|
|
}`
|
|
config := apiProxyDownloadOptions{
|
|
APIServiceKey: apiServiceKey,
|
|
APIProxyName: "proxy1",
|
|
DownloadPath: "tmp",
|
|
}
|
|
httpClient := httpMockCpis{CPIFunction: "APIProxyDownloadFailure", ResponseBody: ``, TestType: "Negative"}
|
|
err := runApiProxyDownload(&config, nil, &httpClient)
|
|
assert.EqualError(t, err, "HTTP GET request to https://demo/apiportal/api/1.0/Transport.svc/APIProxies?name=proxy1 failed with error: Service not Found")
|
|
})
|
|
}
|