1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
sap-jenkins-library/pkg/sonar/sonar_test.go
Marcus Holl 56586cae1b
Remove assert.Error right before assert.EqualError (#2344)
Is there any benefit from having

```
assert.Error(./.)
assert.EqualError(./.)
```

?

assert.Error ensures that we have an error.
assert.EqualError ensures that we have an error and
moreover it checks for a specific error. Hence
assert.EqualError does all and more what assert.Error
does.

In case there is a benefit from that pattern this PR should not be merged.
In case there is not benefit from that pattern  we should abandong that pattern.
2020-11-11 14:14:55 +01:00

39 lines
1.2 KiB
Go

package sonar
import (
"testing"
"github.com/stretchr/testify/assert"
)
func TestReadTaskReport(t *testing.T) {
t.Run("default", func(t *testing.T) {
// test
result, err := ReadTaskReport("./testData/valid")
// assert
assert.Equal(t, "piper-test", result.ProjectKey)
assert.Equal(t, "AXERR2JBbm9IiM5TEST", result.TaskID)
assert.Equal(t, "https://sonarcloud.io/api/ce/task?id=AXERR2JBbm9IiMTEST", result.TaskURL)
assert.Equal(t, "https://sonarcloud.io/dashboard/index/piper-test", result.DashboardURL)
assert.Equal(t, "https://sonarcloud.io", result.ServerURL)
assert.Equal(t, "8.0.0.12345", result.ServerVersion)
assert.NoError(t, err)
})
t.Run("missing file", func(t *testing.T) {
// test
result, err := ReadTaskReport("./testData/missing")
// assert
assert.Empty(t, result.ProjectKey)
assert.EqualError(t, err, "open testData/missing/.scannerwork/report-task.txt: no such file or directory")
})
t.Run("invalid file", func(t *testing.T) {
// test
result, err := ReadTaskReport("./testData/invalid")
// assert
assert.Empty(t, result.ProjectKey)
assert.EqualError(t, err, "decode testData/invalid/.scannerwork/report-task.txt: missing required key projectKey")
})
}