1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
sap-jenkins-library/pkg
Oliver Feldmann 4f6b99cead
Don't allow empty strings as default container parameters (#2406)
First a bug fix is addressed in which the pull policy could not be configured to false by configuring the general configuration. It could neither be configured via dockerExecute or dockerExecuteOnKubernetes, even though this parameter is docker specific. Only by configuring the specific step where one wants to set the pull policy to false can it be configured.

As the bug stems from zero values being in the context config map, which is also addressed with this PR. That is the second part: Context config parameters are only set if they have a value.

* Don't set pull image if not configured

Otherwise, if the pull policy is not set explicitly for a step, dockerPullImage is set to true. Thus, before this change, it cannot be set in the general, or in dockerExecute or in dockerExecuteOnKubernetes configuration.

* Fix unit tests

* Add pullImage parameter test

* Do not place empty default values in context config

* Use putIfNotEmpty for sidecar container options

* Export common configuration

Keys that are set by both main and sidecar container can be exported

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-12-10 11:28:39 +01:00
..
abap AAKaaS upload in chunks (#2422) 2020-11-26 13:45:51 +01:00
abaputils Fix: Change URL creation for abapEnvironmentCloneGitRepo (#2452) 2020-12-08 09:31:08 +01:00
checkmarx fix backslash mess (#2428) 2020-11-26 11:22:54 +01:00
cloudfoundry Vars handling centralized (#1934) 2020-09-24 09:39:18 +02:00
command fix(typo): found by misspell (#2064) 2020-09-24 07:41:06 +02:00
config Don't allow empty strings as default container parameters (#2406) 2020-12-10 11:28:39 +01:00
docker kanikoExecute: improve user experience (#2141) 2020-10-14 11:13:08 +02:00
documentation (documentation) fix documentation render bug (#2423) 2020-11-26 07:51:43 +01:00
fortify fortifyExecuteScan: improve error categorization (#2295) 2020-11-11 13:04:45 +01:00
generator generator helper: support for map[string]interface{} (#2232) 2020-11-23 07:55:20 +01:00
git Remove assert.Error right before assert.EqualError (#2344) 2020-11-11 14:14:55 +01:00
github Add step for GitHub branch protection check (2) (#2016) 2020-09-14 12:05:12 +02:00
hadolint/mocks refactor(hadolint): implement step in GO (#1169) 2020-11-16 15:14:54 +01:00
http Retry capabilities for HTTP requests + enablement for Checkmarx step (#2346) 2020-11-11 13:35:53 +01:00
jenkins chore(jenkins): expose artifacts save method (#2426) 2020-11-26 10:06:14 +01:00
log fix(permissions) allow deletion of errors file (#2293) 2020-11-02 12:34:28 +01:00
maven Removed hardcoded pom.xml and added test (#2393) 2020-11-25 17:03:11 +01:00
mock Refactor maven utils and add tests for install artifacts (#2318) 2020-11-10 17:14:55 +01:00
nexus Extend nexusUpload to also handle npm (#1379) 2020-04-11 12:56:44 +02:00
npm WhiteSource: Force update of project when "checkPolicies" failed (#2401) 2020-11-26 11:45:53 +01:00
piperenv kanikoExecute: improve user experience (#2141) 2020-10-14 11:13:08 +02:00
piperutils WhiteSource: Force update of project when "checkPolicies" failed (#2401) 2020-11-26 11:45:53 +01:00
protecode chore(go): simplify code using gofmt -s (#2065) 2020-09-24 08:58:53 +02:00
sonar Remove assert.Error right before assert.EqualError (#2344) 2020-11-11 14:14:55 +01:00
telemetry Telemetry: report error category (#2085) 2020-09-29 13:49:40 +02:00
vault Feature/approle secret id rotation (#2311) 2020-11-17 13:49:31 +01:00
versioning Refactor maven utils and add tests for install artifacts (#2318) 2020-11-10 17:14:55 +01:00
whitesource WhiteSource: Force update of project when "checkPolicies" failed (#2401) 2020-11-26 11:45:53 +01:00
yaml chore(go): simplify code using gofmt -s (#2065) 2020-09-24 08:58:53 +02:00