mirror of
https://github.com/SAP/jenkins-library.git
synced 2024-12-14 11:03:09 +02:00
4f6b99cead
First a bug fix is addressed in which the pull policy could not be configured to false by configuring the general configuration. It could neither be configured via dockerExecute or dockerExecuteOnKubernetes, even though this parameter is docker specific. Only by configuring the specific step where one wants to set the pull policy to false can it be configured. As the bug stems from zero values being in the context config map, which is also addressed with this PR. That is the second part: Context config parameters are only set if they have a value. * Don't set pull image if not configured Otherwise, if the pull policy is not set explicitly for a step, dockerPullImage is set to true. Thus, before this change, it cannot be set in the general, or in dockerExecute or in dockerExecuteOnKubernetes configuration. * Fix unit tests * Add pullImage parameter test * Do not place empty default values in context config * Use putIfNotEmpty for sidecar container options * Export common configuration Keys that are set by both main and sidecar container can be exported Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com> |
||
|---|---|---|
| .. | ||
| interpolation | ||
| mocks | ||
| config_test.go | ||
| config.go | ||
| defaults_test.go | ||
| defaults.go | ||
| errors_test.go | ||
| errors.go | ||
| flags_test.go | ||
| flags.go | ||
| resources.go | ||
| stepmeta_test.go | ||
| stepmeta.go | ||
| vault_test.go | ||
| vault.go | ||