mirror of
https://github.com/SAP/jenkins-library.git
synced 2025-01-06 04:13:55 +02:00
0f4e30e9db
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
108 lines
2.5 KiB
Go
108 lines
2.5 KiB
Go
package piperenv
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func Test_writeMapToDisk(t *testing.T) {
|
|
t.Parallel()
|
|
testMap := CPEMap{
|
|
"A/B": "Hallo",
|
|
"sub": map[string]interface{}{
|
|
"A/B": "Test",
|
|
},
|
|
"number": 5,
|
|
}
|
|
|
|
tmpDir := t.TempDir()
|
|
err := testMap.WriteToDisk(tmpDir)
|
|
require.NoError(t, err)
|
|
|
|
testData := []struct {
|
|
Path string
|
|
ExpectedValue string
|
|
}{
|
|
{
|
|
Path: "A/B",
|
|
ExpectedValue: "Hallo",
|
|
},
|
|
{
|
|
Path: "sub.json",
|
|
ExpectedValue: "{\"A/B\":\"Test\"}",
|
|
},
|
|
{
|
|
Path: "number.json",
|
|
ExpectedValue: "5",
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testData {
|
|
t.Run(fmt.Sprintf("check path %s", testCase.Path), func(t *testing.T) {
|
|
tPath := path.Join(tmpDir, testCase.Path)
|
|
bytes, err := ioutil.ReadFile(tPath)
|
|
require.NoError(t, err)
|
|
require.Equal(t, testCase.ExpectedValue, string(bytes))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCPEMap_LoadFromDisk(t *testing.T) {
|
|
t.Parallel()
|
|
tmpDir := t.TempDir()
|
|
|
|
err := ioutil.WriteFile(path.Join(tmpDir, "Foo"), []byte("Bar"), 0644)
|
|
require.NoError(t, err)
|
|
err = ioutil.WriteFile(path.Join(tmpDir, "Hello"), []byte("World"), 0644)
|
|
require.NoError(t, err)
|
|
subPath := path.Join(tmpDir, "Batman")
|
|
err = os.Mkdir(subPath, 0744)
|
|
require.NoError(t, err)
|
|
err = ioutil.WriteFile(path.Join(subPath, "Bruce"), []byte("Wayne"), 0644)
|
|
require.NoError(t, err)
|
|
err = ioutil.WriteFile(path.Join(subPath, "Robin"), []byte("toBeEmptied"), 0644)
|
|
require.NoError(t, err)
|
|
err = ioutil.WriteFile(path.Join(subPath, "Test.json"), []byte("54"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
cpe := CPEMap{}
|
|
err = cpe.LoadFromDisk(tmpDir)
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, "Bar", cpe["Foo"])
|
|
require.Equal(t, "World", cpe["Hello"])
|
|
require.Equal(t, "", cpe["Batman/Robin"])
|
|
require.Equal(t, "Wayne", cpe["Batman/Bruce"])
|
|
require.Equal(t, json.Number("54"), cpe["Batman/Test"])
|
|
}
|
|
|
|
func TestNumbersArePassedCorrectly(t *testing.T) {
|
|
t.Parallel()
|
|
tmpDir := t.TempDir()
|
|
|
|
const jsonNumber = "5.5000"
|
|
err := ioutil.WriteFile(path.Join(tmpDir, "test.json"), []byte(jsonNumber), 0644)
|
|
require.NoError(t, err)
|
|
|
|
cpeMap := CPEMap{}
|
|
err = cpeMap.LoadFromDisk(tmpDir)
|
|
require.NoError(t, err)
|
|
|
|
rawJSON, err := json.Marshal(cpeMap["test"])
|
|
require.NoError(t, err)
|
|
require.Equal(t, jsonNumber, string(rawJSON))
|
|
}
|
|
|
|
func TestCommonPipelineEnvDirNotPresent(t *testing.T) {
|
|
cpe := CPEMap{}
|
|
err := cpe.LoadFromDisk("/path/does/not/exist")
|
|
require.NoError(t, err)
|
|
require.Len(t, cpe, 0)
|
|
}
|