mirror of
https://github.com/SAP/jenkins-library.git
synced 2024-12-14 11:03:09 +02:00
0f4e30e9db
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
38 lines
1.0 KiB
Go
38 lines
1.0 KiB
Go
package http
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/SAP/jenkins-library/pkg/log"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestDownloadRequest(t *testing.T) {
|
|
// Start a local HTTP server
|
|
server := httptest.NewServer(
|
|
http.HandlerFunc(
|
|
func(rw http.ResponseWriter, req *http.Request) { rw.Write([]byte("my fancy file content")) }))
|
|
// Close the server when test finishes
|
|
defer server.Close()
|
|
|
|
client := Client{
|
|
logger: log.Entry().WithField("package", "SAP/jenkins-library/pkg/http"),
|
|
}
|
|
|
|
workingDir := t.TempDir()
|
|
targetFile := filepath.Join(workingDir, "abc/123/abc.xml")
|
|
|
|
// function under test
|
|
err := client.DownloadFile(server.URL, targetFile, nil, nil)
|
|
// asserts
|
|
assert.NoError(t, err, "Error occurred but none expected")
|
|
assert.FileExists(t, targetFile, "File not found")
|
|
bytes, err := ioutil.ReadFile(targetFile)
|
|
assert.NoError(t, err, "Error occurred but none expected")
|
|
assert.Equal(t, "my fancy file content", string(bytes))
|
|
}
|