krak/jenkins-lib
1
0
Fork 0
forked from jenkins/jenkins-lib
Code Activity

Рефакторинг VersionParser

Browse Source
This commit is contained in:
Nikita Gryzlov
2020-04-15 13:43:01 +03:00
parent 5762353fe1
commit 6aaad1d6e2
9 changed files with 144 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/unit/groovy/ru/pulsar/jenkins/library/utils/TestUtils.java
View File

@@ -28,6 +28,12 @@ public class TestUtils {
);
});
when(steps.readFile(anyString(), anyString())).thenAnswer(invocation -> {
String file = invocation.getArgument(0);
String encoding = invocation.getArgument(1);
return FileUtils.readFileToString(new File(file), encoding);
});
return steps;
}

88
test/unit/groovy/ru/pulsar/jenkins/library/utils/VersionParserTest.java Normal file
View File

@@ -0,0 +1,88 @@
package ru.pulsar.jenkins.library.utils;
import org.apache.commons.io.FileUtils;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import ru.pulsar.jenkins.library.IStepExecutor;
import java.io.File;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import static org.assertj.core.api.Assertions.assertThat;
class VersionParserTest {
private final IStepExecutor steps = TestUtils.getMockedStepExecutor();
private File file;
@BeforeEach
void setUp() throws IOException {
TestUtils.setupMockedContext(steps);
file = File.createTempFile("version", ".xml");
}
@AfterEach
void tearDown() {
FileUtils.deleteQuietly(file);
}
@Test
void testStorage() throws IOException {
// given
FileUtils.writeStringToFile(file, "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
"<VERSION>3487</VERSION>", StandardCharsets.UTF_8);
// when
String storage = VersionParser.storage(file.toString());
// then
assertThat(storage).isEqualTo("3487");
}
@Test
void testEmptyConfiguration() throws IOException {
// given
FileUtils.writeStringToFile(file,
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
"<MetaDataObject xmlns=\"http://v8.1c.ru/8.3/MDClasses\" xmlns:app=\"http://v8.1c.ru/8.2/managed-application/core\" xmlns:cfg=\"http://v8.1c.ru/8.1/data/enterprise/current-config\" xmlns:cmi=\"http://v8.1c.ru/8.2/managed-application/cmi\" xmlns:ent=\"http://v8.1c.ru/8.1/data/enterprise\" xmlns:lf=\"http://v8.1c.ru/8.2/managed-application/logform\" xmlns:style=\"http://v8.1c.ru/8.1/data/ui/style\" xmlns:sys=\"http://v8.1c.ru/8.1/data/ui/fonts/system\" xmlns:v8=\"http://v8.1c.ru/8.1/data/core\" xmlns:v8ui=\"http://v8.1c.ru/8.1/data/ui\" xmlns:web=\"http://v8.1c.ru/8.1/data/ui/colors/web\" xmlns:win=\"http://v8.1c.ru/8.1/data/ui/colors/windows\" xmlns:xen=\"http://v8.1c.ru/8.3/xcf/enums\" xmlns:xpr=\"http://v8.1c.ru/8.3/xcf/predef\" xmlns:xr=\"http://v8.1c.ru/8.3/xcf/readable\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" version=\"2.8\">\n" +
"\t<Configuration uuid=\"1e4190e9-76c2-456e-a607-4d817110ffd9\">\n" +
"\t\t<Properties>\n" +
"\t\t\t<Vendor>Some vendor</Vendor>\n" +
"\t\t\t<Version/>\n" +
"\t\t</Properties>\n" +
"\t</Configuration>" +
"</MetaDataObject>"
, StandardCharsets.UTF_8);
// when
String storage = VersionParser.configuration(file.toString());
// then
assertThat(storage).isEmpty();
}
@Test
void testConfiguration() throws IOException {
// given
FileUtils.writeStringToFile(file,
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
"<MetaDataObject xmlns=\"http://v8.1c.ru/8.3/MDClasses\" xmlns:app=\"http://v8.1c.ru/8.2/managed-application/core\" xmlns:cfg=\"http://v8.1c.ru/8.1/data/enterprise/current-config\" xmlns:cmi=\"http://v8.1c.ru/8.2/managed-application/cmi\" xmlns:ent=\"http://v8.1c.ru/8.1/data/enterprise\" xmlns:lf=\"http://v8.1c.ru/8.2/managed-application/logform\" xmlns:style=\"http://v8.1c.ru/8.1/data/ui/style\" xmlns:sys=\"http://v8.1c.ru/8.1/data/ui/fonts/system\" xmlns:v8=\"http://v8.1c.ru/8.1/data/core\" xmlns:v8ui=\"http://v8.1c.ru/8.1/data/ui\" xmlns:web=\"http://v8.1c.ru/8.1/data/ui/colors/web\" xmlns:win=\"http://v8.1c.ru/8.1/data/ui/colors/windows\" xmlns:xen=\"http://v8.1c.ru/8.3/xcf/enums\" xmlns:xpr=\"http://v8.1c.ru/8.3/xcf/predef\" xmlns:xr=\"http://v8.1c.ru/8.3/xcf/readable\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" version=\"2.8\">\n" +
"\t<Configuration uuid=\"1e4190e9-76c2-456e-a607-4d817110ffd9\">\n" +
"\t\t<Properties>\n" +
"\t\t\t<Vendor>Some vendor</Vendor>\n" +
"\t\t\t<Version>1.0.0.1</Version>\n" +
"\t\t</Properties>\n" +
"\t</Configuration>" +
"</MetaDataObject>"
, StandardCharsets.UTF_8);
// when
String storage = VersionParser.configuration(file.toString());
// then
assertThat(storage).isEqualTo("1.0.0.1");
}
}