From 596f7d12560f8fb46edcc9ba16c0da5c791f2206 Mon Sep 17 00:00:00 2001 From: "W. Felix Handte" Date: Mon, 12 Nov 2018 12:07:57 -0800 Subject: [PATCH] Fix #1412: Perform Signed Comparison When Setting Attach Dict Param --- lib/compress/zstd_compress.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/compress/zstd_compress.c b/lib/compress/zstd_compress.c index 7721325d7..436522ed3 100644 --- a/lib/compress/zstd_compress.c +++ b/lib/compress/zstd_compress.c @@ -412,11 +412,14 @@ size_t ZSTD_CCtxParam_setParameter( CCtxParams->forceWindow = (value > 0); return CCtxParams->forceWindow; - case ZSTD_p_forceAttachDict : - CCtxParams->attachDictPref = value ? - (value > 0 ? ZSTD_dictForceAttach : ZSTD_dictForceCopy) : + case ZSTD_p_forceAttachDict : { + int signed_val = (int)value; + CCtxParams->attachDictPref = signed_val ? + (signed_val > 0 ? ZSTD_dictForceAttach : + ZSTD_dictForceCopy) : ZSTD_dictDefaultAttach; return CCtxParams->attachDictPref; + } case ZSTD_p_nbWorkers : #ifndef ZSTD_MULTITHREAD