LazStats: Less hints and warnings

git-svn-id: https://svn.code.sf.net/p/lazarus-ccr/svn@7829 8e941d3f-bd1b-0410-a28a-d453659cc2b4

applications/lazstats/source/forms/analysis/comparisons/onecaseanovaunit.pas

@@ -7,7 +7,7 @@ interface
 uses
   Classes, SysUtils, FileUtil, LResources, Forms, Controls, Graphics, Dialogs,
   StdCtrls, Buttons, ExtCtrls,
-  MainUnit, Globals, FunctionsLib, OutputUnit, DataProcs, GraphLib,
+  MainUnit, Globals, OutputUnit, DataProcs, GraphLib,
   ANOVATestsUnit, contexthelpunit;
 
 type

applications/lazstats/source/forms/analysis/descriptive/groupfrequnit.pas

@@ -29,7 +29,7 @@ type
     procedure GrpInBtnClick(Sender: TObject);
     procedure GrpOutBtnClick(Sender: TObject);
     procedure VarListDblClick(Sender: TObject);
-    procedure VarListSelectionChange(Sender: TObject; User: boolean);
+    procedure VarListSelectionChange(Sender: TObject; {%H-}User: boolean);
   private
     FLabelsSource: TListChartSource;
 

applications/lazstats/source/forms/analysis/descriptive/smoothdataunit.pas

@@ -35,7 +35,7 @@ type
     procedure HelpBtnClick(Sender: TObject);
     procedure ResetBtnClick(Sender: TObject);
     procedure VarInBtnClick(Sender: TObject);
-    procedure VarListSelectionChange(Sender: TObject; User: boolean);
+    procedure VarListSelectionChange(Sender: TObject; {%H-}User: boolean);
     procedure VarOutBtnClick(Sender: TObject);
   private
     { private declarations }
@@ -69,7 +69,8 @@ end;
 
 procedure TDataSmoothingForm.ComputeBtnClick(Sender: TObject);
 var
-  DataPts, OutPts: DblDyneVec;
+  DataPts: DblDyneVec = nil;
+  OutPts: DblDyneVec = nil;
   N, Reps, i, j, VarCol: integer;
   VarLabel, strValue: string;
 begin

applications/lazstats/source/forms/analysis/measurement_programs/gradebookunit.pas

@@ -105,7 +105,7 @@ implementation
 
 uses
   Math,
-  Utils, MatrixUnit;
+  MatrixUnit;
 
 { TGradebookFrm }
 

applications/lazstats/source/forms/analysis/measurement_programs/gradingunit.pas

@@ -51,7 +51,7 @@ type
     procedure FormShow(Sender: TObject);
     procedure LoadBtnClick(Sender: TObject);
     procedure LowScoreGridKeyDown(Sender: TObject; var Key: Word;
-      Shift: TShiftState);
+      {%H-}Shift: TShiftState);
     procedure ResetBtnClick(Sender: TObject);
     procedure SaveBtnClick(Sender: TObject);
   private
@@ -73,7 +73,7 @@ implementation
 
 uses
   Math,
-  Utils, MatrixUnit, GradebookUnit;
+  MatrixUnit, GradebookUnit;
 
 { TGradingFrm }
 

applications/lazstats/source/forms/analysis/measurement_programs/polydifunit.pas

@@ -84,7 +84,7 @@ type
     procedure NextBtnClick(Sender: TObject);
     procedure ResetBtnClick(Sender: TObject);
     procedure UpBoundEditEditingDone(Sender: TObject);
-    procedure VarListSelectionChange(Sender: TObject; User: boolean);
+    procedure VarListSelectionChange(Sender: TObject; {%H-}User: boolean);
   private
     { private declarations }
     FAutoSized: Boolean;

applications/lazstats/source/forms/analysis/multiple_regression/twoslsunit.pas

@@ -41,7 +41,7 @@ type
     procedure DepOutClick(Sender: TObject);
     procedure ExpInClick(Sender: TObject);
     procedure ExplanatoryListDblClick(Sender: TObject);
-    procedure ExplanatoryListSelectionChange(Sender: TObject; User: boolean);
+    procedure ExplanatoryListSelectionChange(Sender: TObject; {%H-}User: boolean);
     procedure ExpOutClick(Sender: TObject);
     procedure InstInClick(Sender: TObject);
     procedure InstOutClick(Sender: TObject);
@@ -99,21 +99,36 @@ end;
 
 procedure TTwoSLSForm.Compute;
 var
+  IndepCols: IntDyneVec = nil;
+  ProxSrcCols: IntDyneVec = nil;
+  ExpCols: IntDyneVec = nil;
+  InstCols: IntDyneVec = nil;
+  ProxCols: IntDyneVec = nil;
+  ExpLabels: StrDyneVec = nil;
+  InstLabels: StrDyneVec = nil;
+  ProxLabels: StrDyneVec = nil;
+  RowLabels: StrDyneVec = nil;
+  ProxSrcLabels: StrDyneVec = nil;
+  Means: DblDyneVec = nil;
+  Variances: DblDyneVec = nil;
+  StdDevs: DblDyneVec = nil;
+  BWeights: DblDyneVec = nil;
+  BetaWeights: DblDyneVec = nil;
+  BStdErrs: DblDyneVec = nil;
+  Bttests: DblDyneVec = nil;
+  tProbs: DblDyneVec = nil;
+  R2: Double = 0.0;
+  stdErrEst: Double = 0.0;
+
   i, j, k, DepCol,  NoInst, NoExp, NoProx, Noindep : integer;
-     IndepCols, ProxSrcCols, ExpCols, InstCols, ProxCols : IntDyneVec;
   DepProx,  NCases, col, counter : integer;
-     ExpLabels, InstLabels, ProxLabels, RowLabels, ProxSrcLabels : StrDyneVec;
   X, Y : double;
-     Means, Variances, StdDevs, BWeights : DblDyneVec;
-     BetaWeights, BStdErrs, Bttests, tprobs : DblDyneVec;
 //     ProxVals : DblDyneMat;
   PrintDesc: Boolean;
 //     PrintCorrs, PrintInverse, PrintCoefs, SaveCorrs : boolean;
   found : boolean;
   lReport: TStrings;
   errorcode: Boolean = false;
-     R2: Double = 0.0;
-     stdErrEst: Double = 0.0;
 begin
      if DepVarEdit.Text = '' then
      begin

applications/lazstats/source/forms/analysis/multiple_regression/wlsunit.pas

@@ -93,7 +93,7 @@ type
       const ARowLabels: StrDyneVec; const xValues: DblDyneMat;
       out AWeights: DblDyneVec; const ABadRows: IntDyneVec): Boolean;
 
-    function Process_WeightedRegression(AIndepCols: IntDyneVec;
+    function Process_WeightedRegression(
       const ARowLabels: StrDyneVec; const xValues: DblDyneMat;
       const yValues: DblDyneVec; const AWeights: DblDyneVec;
       SubtractMeans: Boolean): Boolean;
@@ -301,7 +301,7 @@ begin
     useOrigin := Origin2Chk.Checked;
 
   // Do the weighted regression, finally
-  Process_WeightedRegression(indepCols, RowLabels, xValues, yValues, weights, useOrigin);
+  Process_WeightedRegression(RowLabels, xValues, yValues, weights, useOrigin);
 end;
 
 
@@ -840,7 +840,7 @@ begin
 end;
 
 
-function TWLSForm.Process_WeightedRegression(AIndepCols: IntDyneVec;
+function TWLSForm.Process_WeightedRegression(
   const ARowLabels: StrDyneVec; const xValues: DblDyneMat;
   const yValues: DblDyneVec; const AWeights: DblDyneVec; SubtractMeans: Boolean): Boolean;
 var

applications/lazstats/source/forms/analysis/multivariate/singlelinkunit.pas

@@ -63,7 +63,7 @@ implementation
 
 uses
   Math,
-  Utils, MatrixUnit;
+  {%H-}Utils, MatrixUnit;
 
 { TSingleLinkFrm }
 

applications/lazstats/source/forms/analysis/nonparametric/friedmanunit.pas

@@ -52,7 +52,7 @@ implementation
 {$R *.lfm}
 
 uses
-  Math, Utils;
+  Utils;
 
 
 { TFriedmanFrm }

applications/lazstats/source/forms/analysis/nonparametric/kaplanmeierunit.pas

@@ -233,14 +233,9 @@ var
   CntrlProp: DblDyneVec = nil;
   CumPropExp: DblDyneVec = nil;
   CumPropCntrl: DblDyneVec = nil;
-  TimeLabel, GroupLabel, DeathsLabel: string;
   lReport: TStrings;
 begin
-  // get variable columns and labels
+  // Get variable columns
-  TimeLabel := TimeVarEdit.Text;
-  GroupLabel := GroupVarEdit.Text;
-  DeathsLabel := EventVarEdit.Text;
-
   TimeCol := GetVariableIndex(OS3MainFrm.DataGrid, TimeVarEdit.Text);
   DeathsCol := GetVariableIndex(OS3MainFrm.DataGrid, EventVarEdit.Text);
   GroupCol := GetVariableIndex(OS3MainFrm.DataGrid, GroupVarEdit.Text);

applications/lazstats/source/forms/analysis/nonparametric/riditunit.pas

@@ -51,7 +51,7 @@ type
               NoToAnalyze: integer; Freq: IntDyneMat;
               Props: DblDyneMat; NoRows: integer; AReport: TStrings);
     procedure VarListDblClick(Sender: TObject);
-    procedure VarListSelectionChange(Sender: TObject; User: boolean);
+    procedure VarListSelectionChange(Sender: TObject; {%H-}User: boolean);
 
   private
 	
@@ -101,16 +101,16 @@ procedure TRIDITForm.Analyze(RefCol : integer; ColNoSelected : IntDyneVec;
               Props : DblDyneMat; NoRows : integer;
               AReport: TStrings);
 var
-  probdists : DblDyneMat;
+  probdists : DblDyneMat = nil;
-  refprob : DblDyneMat;
+  refprob : DblDyneMat = nil;
-  sizes : DblDyneVec;
+  sizes : DblDyneVec = nil;
-  meanridits : DblDyneVec;
+  meanridits : DblDyneVec = nil;
-  Cratios : DblDyneVec;
+  StdErr : DblDyneVec = nil;
+  Cratios : DblDyneVec = nil;
   OverMeanRidit : double;
   chisquare : double;
   probchi : double;
   alpha : double;
-  StdErr : DblDyneVec;
   Bonferroni : double;
   i, j : integer;
   outline : string;
@@ -302,15 +302,17 @@ end;
 
 procedure TRIDITForm.Compute;
 var
+  Prop: DblDyneMat = nil;
+  Expected: DblDyneMat = nil;
+  CellChi: DblDyneMat = nil;
+  ColNoSelected: IntDyneVec = nil;
+  Freq : IntDyneMat = nil;
+  RowLabels: StrDyneVec = nil;
+  ColLabels: StrDyneVec = nil;
   AllRefs : boolean;
   i, j, RowNo, RefColNo, NoToAnalyze : integer;
   Row, Col, Ncases, Nrows, Ncols, df : integer;
-  RowLabels, ColLabels : StrDyneVec;
-  ColNoSelected : IntDyneVec = nil;
-  cellstring : string;
   outline : string;
-  Freq : IntDyneMat = nil;
-  Prop, Expected, CellChi : DblDyneMat;
   ChiSquare, ProbChi : double;
   yates : boolean;
   Adjchisqr, Adjprobchi: double;

applications/lazstats/source/forms/analysis/nonparametric/srhtestunit.pas

@@ -614,7 +614,7 @@ procedure TSRHTest.TwoWayPlot(Sender: TObject);
 var
    i, j : integer;
    maxmean, XBar : double;
-   XValue : DblDyneVec;
+   XValue : DblDyneVec = nil;
    title : string;
    plottype : integer;
    setstring : string[11];

applications/lazstats/source/forms/misc/dictionaryunit.pas

@@ -28,8 +28,8 @@ type
     CancelBtn: TButton;
     DictGrid: TStringGrid;
     Panel1: TPanel;
-    procedure DictGridKeyDown(Sender: TObject; var Key: Word; Shift: TShiftState);
+    procedure DictGridKeyDown(Sender: TObject; var Key: Word; {%H-}Shift: TShiftState);
-    procedure DictGridSelectEditor(Sender: TObject; aCol, aRow: Integer;
+    procedure DictGridSelectEditor(Sender: TObject; aCol, {%H-}aRow: Integer;
       var Editor: TWinControl);
     procedure DictGridSetEditText(Sender: TObject; ACol, ARow: Integer;
       const Value: string);

applications/lazstats/source/forms/simulations/fprobunit.pas

@@ -6,8 +6,7 @@ interface
 
 uses
   Classes, SysUtils, FileUtil, LResources, Forms, Controls, Graphics, Dialogs,
-  StdCtrls, ExtCtrls,
+  StdCtrls, ExtCtrls;
-  Functionslib;
 
 type