From 82f8f98e86dbf4f3a4a5501686d9743de8bebc7c Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 3 Mar 2023 13:03:00 +0100 Subject: [PATCH 1/5] Fix lint_python so tests pass again --- .github/workflows/lint_python.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint_python.yml b/.github/workflows/lint_python.yml index eee4a73..6a72afd 100644 --- a/.github/workflows/lint_python.yml +++ b/.github/workflows/lint_python.yml @@ -8,7 +8,7 @@ jobs: - uses: actions/setup-python@v4 with: python-version: '3.x' - - run: pip install --upgrade pip wheel + - run: pip install --upgrade pip setuptools wheel - run: pip install bandit black codespell flake8 flake8-bugbear flake8-return flake8-comprehensions isort mypy pytest pyupgrade safety - run: bandit --recursive --skip B404,B603,B605,B607 . From ac7f2909dbccaeb27964dbd7090b51c6f62c1214 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sat, 4 Mar 2023 13:25:33 +0100 Subject: [PATCH 2/5] Update lint_python.yml --- .github/workflows/lint_python.yml | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/workflows/lint_python.yml b/.github/workflows/lint_python.yml index 6a72afd..c03d3c0 100644 --- a/.github/workflows/lint_python.yml +++ b/.github/workflows/lint_python.yml @@ -7,20 +7,21 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-python@v4 with: - python-version: '3.x' - - run: pip install --upgrade pip setuptools wheel - - run: pip install bandit black codespell flake8 flake8-bugbear flake8-return - flake8-comprehensions isort mypy pytest pyupgrade safety - - run: bandit --recursive --skip B404,B603,B605,B607 . + python-version: 3.x + - run: pip install --upgrade pip ruff setuptools wheel + - name: "Ruff: Show stopper (must-fix) issues" + run: ruff . --select=E9,F63,F7,F82,PLE,YTT --show-source . + - name: "Ruff: All issues" + run: ruff --exit-zero --select=ALL --statistics --target-version=py37 . + - name: "Ruff: All fixable (ruff --fix) issues" + run: ruff --exit-zero --select=ALL --ignore=ANN204,COM812,ERA001,RSE102 + --statistics --target-version=py37 . || true | grep "\[\*\]" + - run: pip install black codespell mypy pytest safety - run: black --check . || true - - run: codespell --ignore-words-list="WAN" || true # --skip="*.css,*.js,*.lock" - - run: flake8 --ignore=E124,E128,E225,E251,E302,R502,R503,W291,W293,W605 - --max-complexity=11 --max-line-length=265 --show-source --statistics . - - run: isort --check-only --profile black . || true - - run: pip install -r requirement.txt || pip install -r requirements.txt || pip install --editable . || pip install . || true + - run: codespell # --ignore-words-list="" --skip="*.css,*.js,*.lock" + - run: pip install -r requirements.txt || pip install --editable . || pip install . || true - run: mkdir --parents --verbose .mypy_cache - run: mypy --ignore-missing-imports --install-types --non-interactive . || true - run: pytest . || true - run: pytest --doctest-modules . || true - - run: shopt -s globstar && pyupgrade --py36-plus **/*.py || true - run: safety check From 80dc79f85eb7175dd04b2c2ff28b3b1c5da292db Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sat, 4 Mar 2023 13:29:05 +0100 Subject: [PATCH 3/5] Update lint_python.yml --- .github/workflows/lint_python.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint_python.yml b/.github/workflows/lint_python.yml index c03d3c0..a081a28 100644 --- a/.github/workflows/lint_python.yml +++ b/.github/workflows/lint_python.yml @@ -18,7 +18,7 @@ jobs: --statistics --target-version=py37 . || true | grep "\[\*\]" - run: pip install black codespell mypy pytest safety - run: black --check . || true - - run: codespell # --ignore-words-list="" --skip="*.css,*.js,*.lock" + - run: codespell || true # --ignore-words-list="" --skip="*.css,*.js,*.lock" - run: pip install -r requirements.txt || pip install --editable . || pip install . || true - run: mkdir --parents --verbose .mypy_cache - run: mypy --ignore-missing-imports --install-types --non-interactive . || true From cd610e56bf381628cbc00f07f56bd9adc4b07a05 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sat, 4 Mar 2023 13:33:57 +0100 Subject: [PATCH 4/5] Update lint_python.yml --- .github/workflows/lint_python.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint_python.yml b/.github/workflows/lint_python.yml index a081a28..53c0c67 100644 --- a/.github/workflows/lint_python.yml +++ b/.github/workflows/lint_python.yml @@ -15,7 +15,7 @@ jobs: run: ruff --exit-zero --select=ALL --statistics --target-version=py37 . - name: "Ruff: All fixable (ruff --fix) issues" run: ruff --exit-zero --select=ALL --ignore=ANN204,COM812,ERA001,RSE102 - --statistics --target-version=py37 . || true | grep "\[\*\]" + --statistics --target-version=py37 . | grep "\[\*\]" - run: pip install black codespell mypy pytest safety - run: black --check . || true - run: codespell || true # --ignore-words-list="" --skip="*.css,*.js,*.lock" From 2ff5e7051e7a1e7496fc35ca7ff9a31d4db44430 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sat, 4 Mar 2023 14:47:17 +0100 Subject: [PATCH 5/5] Update lint_python.yml --- .github/workflows/lint_python.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint_python.yml b/.github/workflows/lint_python.yml index 53c0c67..d082fa3 100644 --- a/.github/workflows/lint_python.yml +++ b/.github/workflows/lint_python.yml @@ -1,5 +1,9 @@ name: lint_python -on: [pull_request, push] +on: + pull_request: + branches: [master] + push: + branches: [master] jobs: lint_python: runs-on: ubuntu-latest