python/httpie-cli
1
0
Fork 0
mirror of https://github.com/httpie/cli.git synced 2025-06-23 00:37:52 +02:00
Code Activity

exit 0 constant: OK => SUCCESS to avoid confusion w/ HTTP 200 OK

Browse Source
This commit is contained in:
Jakub Roztocil
2018-11-02 16:07:39 +01:00
parent 96444f3345
commit b596fedf13
6 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
httpie/core.py
View File

@ -43,7 +43,7 @@ def get_exit_status(http_status, follow=False):
# Server Error
return ExitStatus.ERROR_HTTP_5XX
else:
return ExitStatus.OK
return ExitStatus.SUCCESS
def print_debug_info(env):
@ -82,7 +82,7 @@ def program(args, env, log_error):
:return: status code
"""
exit_status = ExitStatus.OK
exit_status = ExitStatus.SUCCESS
downloader = None
show_traceback = args.debug or args.traceback
@ -109,7 +109,7 @@ def program(args, env, log_error):
http_status=response.status_code,
follow=args.follow
)
if not env.stdout_isatty and exit_status != ExitStatus.OK:
if not env.stdout_isatty and exit_status != ExitStatus.SUCCESS:
log_error(
'HTTP %s %s', response.raw.status, response.raw.reason,
level='warning'
@ -143,7 +143,7 @@ def program(args, env, log_error):
else:
raise
if downloader and exit_status == ExitStatus.OK:
if downloader and exit_status == ExitStatus.SUCCESS:
# Last response body download.
download_stream, download_to = downloader.start(final_response)
write_stream(
@ -202,9 +202,9 @@ def main(args=sys.argv[1:], env=Environment(), custom_log_error=None):
if include_debug_info:
print_debug_info(env)
if args == ['--debug']:
return ExitStatus.OK
return ExitStatus.SUCCESS
exit_status = ExitStatus.OK
exit_status = ExitStatus.SUCCESS
try:
parsed_args = parser.parse_args(args=args, env=env)
@ -214,7 +214,7 @@ def main(args=sys.argv[1:], env=Environment(), custom_log_error=None):
raise
exit_status = ExitStatus.ERROR_CTRL_C
except SystemExit as e:
if e.code != ExitStatus.OK:
if e.code != ExitStatus.SUCCESS:
env.stderr.write('\n')
if include_traceback:
raise
@ -232,7 +232,7 @@ def main(args=sys.argv[1:], env=Environment(), custom_log_error=None):
raise
exit_status = ExitStatus.ERROR_CTRL_C
except SystemExit as e:
if e.code != ExitStatus.OK:
if e.code != ExitStatus.SUCCESS:
env.stderr.write('\n')
if include_traceback:
raise