rust/comprehensive-rust
1
0
Fork 0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-04-26 09:12:58 +02:00
Code Issues Releases Activity

Don't allocate in success case (#506)

Browse Source 
`format!` was being called (and allocating a string) even in the success case.
This commit is contained in:
Andrew Walbran 2023-03-15 08:06:35 +00:00 committed by GitHub
parent 9ee562c267
commit 7a22d5567a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/error-handling/error-contexts.md
View File

@ -12,7 +12,7 @@ use anyhow::{Context, Result, bail};
fn read_username(path: &str) -> Result<String> { fn read_username(path: &str) -> Result<String> {
let mut username = String::with_capacity(100); let mut username = String::with_capacity(100);
fs::File::open(path) fs::File::open(path)
.context(format!("Failed to open {path}"))? .with_context(|| format!("Failed to open {path}"))?
.read_to_string(&mut username) .read_to_string(&mut username)
.context("Failed to read")?; .context("Failed to read")?;
if username.is_empty() { if username.is_empty() {